[INFO] crate quoted_printable 0.4.0 is already in cache [INFO] extracting crate quoted_printable 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/quoted_printable/0.4.0 [INFO] extracting crate quoted_printable 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quoted_printable/0.4.0 [INFO] validating manifest of quoted_printable-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quoted_printable-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quoted_printable-0.4.0 [INFO] finished frobbing quoted_printable-0.4.0 [INFO] frobbed toml for quoted_printable-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/quoted_printable/0.4.0/Cargo.toml [INFO] started frobbing quoted_printable-0.4.0 [INFO] finished frobbing quoted_printable-0.4.0 [INFO] frobbed toml for quoted_printable-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quoted_printable/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quoted_printable-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quoted_printable/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a09ad0b18854a38b96e5ca19a812b3a35ca5ea4f92baebde6a28066abc4a2307 [INFO] running `"docker" "start" "-a" "a09ad0b18854a38b96e5ca19a812b3a35ca5ea4f92baebde6a28066abc4a2307"` [INFO] [stderr] Checking quoted_printable v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | / if mode == ParseMode::Strict { [INFO] [stderr] 202 | | if upper_char.to_uppercase().next() != Some(upper_char) || [INFO] [stderr] 203 | | lower_char.to_uppercase().next() != Some(lower_char) [INFO] [stderr] 204 | | { [INFO] [stderr] 205 | | return Err(QuotedPrintableError::LowercaseHexOctet); [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 201 | if mode == ParseMode::Strict && (upper_char.to_uppercase().next() != Some(upper_char) || [INFO] [stderr] 202 | lower_char.to_uppercase().next() != Some(lower_char)) { [INFO] [stderr] 203 | return Err(QuotedPrintableError::LowercaseHexOctet); [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | / if mode == ParseMode::Strict { [INFO] [stderr] 202 | | if upper_char.to_uppercase().next() != Some(upper_char) || [INFO] [stderr] 203 | | lower_char.to_uppercase().next() != Some(lower_char) [INFO] [stderr] 204 | | { [INFO] [stderr] 205 | | return Err(QuotedPrintableError::LowercaseHexOctet); [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 201 | if mode == ParseMode::Strict && (upper_char.to_uppercase().next() != Some(upper_char) || [INFO] [stderr] 202 | lower_char.to_uppercase().next() != Some(lower_char)) { [INFO] [stderr] 203 | return Err(QuotedPrintableError::LowercaseHexOctet); [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | *bytes_on_line = *bytes_on_line + to_append.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*bytes_on_line += to_append.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:279:29 [INFO] [stderr] | [INFO] [stderr] 279 | while let Some(&byte) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for &byte in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | b'\t' | b' '...b'~' => append(result, &[to_append], on_line, backup_pos), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | b'=' => append(result, b"=3D", on_line, backup_pos), [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:139:10 [INFO] [stderr] | [INFO] [stderr] 139 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | *bytes_on_line = *bytes_on_line + to_append.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*bytes_on_line += to_append.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:279:29 [INFO] [stderr] | [INFO] [stderr] 279 | while let Some(&byte) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for &byte in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | b'\t' | b' '...b'~' => append(result, &[to_append], on_line, backup_pos), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | b'=' => append(result, b"=3D", on_line, backup_pos), [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:463:51 [INFO] [stderr] | [INFO] [stderr] 463 | assert_eq!("hello, world!", encode_to_str("hello, world!".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello, world!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "a09ad0b18854a38b96e5ca19a812b3a35ca5ea4f92baebde6a28066abc4a2307"` [INFO] running `"docker" "rm" "-f" "a09ad0b18854a38b96e5ca19a812b3a35ca5ea4f92baebde6a28066abc4a2307"` [INFO] [stdout] a09ad0b18854a38b96e5ca19a812b3a35ca5ea4f92baebde6a28066abc4a2307