[INFO] crate quickersort 3.0.1 is already in cache [INFO] extracting crate quickersort 3.0.1 into work/ex/clippy-test-run/sources/stable/reg/quickersort/3.0.1 [INFO] extracting crate quickersort 3.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickersort/3.0.1 [INFO] validating manifest of quickersort-3.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickersort-3.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickersort-3.0.1 [INFO] finished frobbing quickersort-3.0.1 [INFO] frobbed toml for quickersort-3.0.1 written to work/ex/clippy-test-run/sources/stable/reg/quickersort/3.0.1/Cargo.toml [INFO] started frobbing quickersort-3.0.1 [INFO] finished frobbing quickersort-3.0.1 [INFO] frobbed toml for quickersort-3.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickersort/3.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickersort-3.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickersort/3.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3fde746f608fa2831f390aa3677e2a1cf3f6028bddf350a014e2be45a698335 [INFO] running `"docker" "start" "-a" "a3fde746f608fa2831f390aa3677e2a1cf3f6028bddf350a014e2be45a698335"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking quickersort v3.0.1 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sort.rs:211:17 [INFO] [stderr] | [INFO] [stderr] 211 | p1: p1, [INFO] [stderr] | ^^^^^^ help: replace it with: `p1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sort.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | p2: p2, [INFO] [stderr] | ^^^^^^ help: replace it with: `p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sort.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | let mut d = c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | let r = compare_idxs_safe(v, b, 0, compare); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | let r = compare_idxs_safe(v, c, 0, compare); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:354:9 [INFO] [stderr] | [INFO] [stderr] 354 | let n = v.len(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | let l = min(a, b - a); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | let r = min(d - c, n - 1 - d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | let mut i = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sort.rs:504:9 [INFO] [stderr] | [INFO] [stderr] 504 | let y = v.get_unchecked(b); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-traits`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e1` [INFO] [stderr] ... [INFO] [stderr] 111 | maybe_swap!(v, &mut e1, &mut e2, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e2` [INFO] [stderr] ... [INFO] [stderr] 111 | maybe_swap!(v, &mut e1, &mut e2, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e4` [INFO] [stderr] ... [INFO] [stderr] 112 | maybe_swap!(v, &mut e4, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e5` [INFO] [stderr] ... [INFO] [stderr] 112 | maybe_swap!(v, &mut e4, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e3` [INFO] [stderr] ... [INFO] [stderr] 113 | maybe_swap!(v, &mut e3, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e5` [INFO] [stderr] ... [INFO] [stderr] 113 | maybe_swap!(v, &mut e3, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e3` [INFO] [stderr] ... [INFO] [stderr] 114 | maybe_swap!(v, &mut e3, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e4` [INFO] [stderr] ... [INFO] [stderr] 114 | maybe_swap!(v, &mut e3, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e2` [INFO] [stderr] ... [INFO] [stderr] 115 | maybe_swap!(v, &mut e2, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e5` [INFO] [stderr] ... [INFO] [stderr] 115 | maybe_swap!(v, &mut e2, &mut e5, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e1` [INFO] [stderr] ... [INFO] [stderr] 116 | maybe_swap!(v, &mut e1, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e4` [INFO] [stderr] ... [INFO] [stderr] 116 | maybe_swap!(v, &mut e1, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e1` [INFO] [stderr] ... [INFO] [stderr] 117 | maybe_swap!(v, &mut e1, &mut e3, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e3` [INFO] [stderr] ... [INFO] [stderr] 117 | maybe_swap!(v, &mut e1, &mut e3, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e2` [INFO] [stderr] ... [INFO] [stderr] 118 | maybe_swap!(v, &mut e2, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e4` [INFO] [stderr] ... [INFO] [stderr] 118 | maybe_swap!(v, &mut e2, &mut e4, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e2` [INFO] [stderr] ... [INFO] [stderr] 119 | maybe_swap!(v, &mut e2, &mut e3, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/sort.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | if compare_idxs($v, *$a, *$b, $compare) == Greater { [INFO] [stderr] | ^^^ help: try this: `e3` [INFO] [stderr] ... [INFO] [stderr] 119 | maybe_swap!(v, &mut e2, &mut e3, compare, swapped); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sort.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sort.rs:360:5 [INFO] [stderr] | [INFO] [stderr] 360 | return (b - a, d - c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(b - a, d - c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/float.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | return left; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/sort.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / fn dual_pivot_sort Ordering>(v: &mut [T], (p1, p2): (usize, usize), [INFO] [stderr] 198 | | compare: &C, rec: u32, heapsort_depth: u32) { [INFO] [stderr] 199 | | debug_assert!(v.len() > 9); [INFO] [stderr] 200 | | let (left, right) = unsafe { [INFO] [stderr] ... | [INFO] [stderr] 289 | | introsort(&mut v[right_pivot + 1..], compare, rec + 1, heapsort_depth); [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/float.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | self != self [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> src/float.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | self != self [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/float.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | sort_by(&mut v[..rnan + 1], &|x: &T, y: &T| [INFO] [stderr] | ^^^^^^^^^^ help: use: `..=rnan` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/float.rs:111:35 [INFO] [stderr] | [INFO] [stderr] 111 | let left = find_first_zero(&v[..rnan + 1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `..=rnan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/float.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if v.len() == 0 { return 0; } [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickersort`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a3fde746f608fa2831f390aa3677e2a1cf3f6028bddf350a014e2be45a698335"` [INFO] running `"docker" "rm" "-f" "a3fde746f608fa2831f390aa3677e2a1cf3f6028bddf350a014e2be45a698335"` [INFO] [stdout] a3fde746f608fa2831f390aa3677e2a1cf3f6028bddf350a014e2be45a698335