[INFO] crate qptrie 0.2.3 is already in cache [INFO] extracting crate qptrie 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/qptrie/0.2.3 [INFO] extracting crate qptrie 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qptrie/0.2.3 [INFO] validating manifest of qptrie-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qptrie-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qptrie-0.2.3 [INFO] finished frobbing qptrie-0.2.3 [INFO] frobbed toml for qptrie-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/qptrie/0.2.3/Cargo.toml [INFO] started frobbing qptrie-0.2.3 [INFO] finished frobbing qptrie-0.2.3 [INFO] frobbed toml for qptrie-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qptrie/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qptrie-0.2.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qptrie/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4eb22df26d9a0e2131cd840df6d439e77c87bf97b655d0a06d90ecbc60a76c5 [INFO] running `"docker" "start" "-a" "f4eb22df26d9a0e2131cd840df6d439e77c87bf97b655d0a06d90ecbc60a76c5"` [INFO] [stderr] Checking qptrie v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/trie.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | / if leaf.key.as_ref().starts_with(prefix.as_ref()) { [INFO] [stderr] 317 | | if include_prefix || leaf.key.as_ref() != prefix.as_ref() { [INFO] [stderr] 318 | | return Some(leaf); [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if leaf.key.as_ref().starts_with(prefix.as_ref()) && (include_prefix || leaf.key.as_ref() != prefix.as_ref()) { [INFO] [stderr] 317 | return Some(leaf); [INFO] [stderr] 318 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/trie.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | / if leaf.key.as_ref().starts_with(prefix.as_ref()) { [INFO] [stderr] 317 | | if include_prefix || leaf.key.as_ref() != prefix.as_ref() { [INFO] [stderr] 318 | | return Some(leaf); [INFO] [stderr] 319 | | } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | if leaf.key.as_ref().starts_with(prefix.as_ref()) && (include_prefix || leaf.key.as_ref() != prefix.as_ref()) { [INFO] [stderr] 317 | return Some(leaf); [INFO] [stderr] 318 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/test.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / fn test_gen() { [INFO] [stderr] 5 | | let mut trie = Trie::default(); [INFO] [stderr] 6 | | trie.insert(vec![0x12, 0x34, 0x56, 0x78], "12345678"); [INFO] [stderr] 7 | | trie.insert(vec![0x12, 0x34, 0xab, 0xcd], "1234abcd"); [INFO] [stderr] ... | [INFO] [stderr] 85 | | assert!(trie3.is_empty()); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "f4eb22df26d9a0e2131cd840df6d439e77c87bf97b655d0a06d90ecbc60a76c5"` [INFO] running `"docker" "rm" "-f" "f4eb22df26d9a0e2131cd840df6d439e77c87bf97b655d0a06d90ecbc60a76c5"` [INFO] [stdout] f4eb22df26d9a0e2131cd840df6d439e77c87bf97b655d0a06d90ecbc60a76c5