[INFO] crate pythonic 0.3.0 is already in cache
[INFO] extracting crate pythonic 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/pythonic/0.3.0
[INFO] extracting crate pythonic 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pythonic/0.3.0
[INFO] validating manifest of pythonic-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pythonic-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pythonic-0.3.0
[INFO] finished frobbing pythonic-0.3.0
[INFO] frobbed toml for pythonic-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/pythonic/0.3.0/Cargo.toml
[INFO] started frobbing pythonic-0.3.0
[INFO] finished frobbing pythonic-0.3.0
[INFO] frobbed toml for pythonic-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pythonic/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pythonic-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pythonic/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1767cd4315457f18bdd04c64253284c3b2eee4f9f3dcfedf24d3f37c9389914e
[INFO] running `"docker" "start" "-a" "1767cd4315457f18bdd04c64253284c3b2eee4f9f3dcfedf24d3f37c9389914e"`
[INFO] [stderr]     Checking pythonic v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assignment.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             lhs: lhs,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `lhs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/block.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |         write!(f, "{}\n", statements)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/function.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/function.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             arguments: arguments,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/statement.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             arguments: arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/assignment.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             lhs: lhs,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `lhs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/block.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |         write!(f, "{}\n", statements)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/function.rs:93:13
[INFO] [stderr]    |
[INFO] [stderr] 93 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/function.rs:164:13
[INFO] [stderr]     |
[INFO] [stderr] 164 |             arguments: arguments,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/statement.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |             arguments: arguments,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/argument.rs:84:9
[INFO] [stderr]    |
[INFO] [stderr] 84 | /         match self {
[INFO] [stderr] 85 | |             &Argument::FunctionDefinition{ref help, .. } => help.is_some(),
[INFO] [stderr] 86 | |             _ => false,
[INFO] [stderr] 87 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 84 |         match *self {
[INFO] [stderr] 85 |             Argument::FunctionDefinition{ref help, .. } => help.is_some(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:91:9
[INFO] [stderr]     |
[INFO] [stderr] 91  | /         match self {
[INFO] [stderr] 92  | |             &Argument::FunctionDefinition{ref help,  ref name, ..} => {
[INFO] [stderr] 93  | |                 let mut formatted_help = format!(":param {}:", name);
[INFO] [stderr] 94  | |
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => None,
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 91  |         match *self {
[INFO] [stderr] 92  |             Argument::FunctionDefinition{ref help,  ref name, ..} => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:95:17
[INFO] [stderr]     |
[INFO] [stderr] 95  | /                 if let &Some(ref help_str) = help {
[INFO] [stderr] 96  | |                     formatted_help.push_str(&format!(" {}", help_str)[..]);
[INFO] [stderr] 97  | |                     Some(formatted_help)
[INFO] [stderr] 98  | |                 } else {
[INFO] [stderr] 99  | |                     None
[INFO] [stderr] 100 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 95  |                 if let Some(ref help_str) = *help {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         match self {
[INFO] [stderr] 108 | |             &Argument::FunctionDefinition{ref arg_type, ref name, ..} => {
[INFO] [stderr] 109 | |                 let mut help = format!(":type {}:", name);
[INFO] [stderr] 110 | |                 if let &Some(ref t) = arg_type {
[INFO] [stderr] ...   |
[INFO] [stderr] 117 | |             _ => None,
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 107 |         match *self {
[INFO] [stderr] 108 |             Argument::FunctionDefinition{ref arg_type, ref name, ..} => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:110:17
[INFO] [stderr]     |
[INFO] [stderr] 110 | /                 if let &Some(ref t) = arg_type {
[INFO] [stderr] 111 | |                     help.push_str(&format!(" {}", t)[..]);
[INFO] [stderr] 112 | |                     Some(help)
[INFO] [stderr] 113 | |                 } else {
[INFO] [stderr] 114 | |                     None
[INFO] [stderr] 115 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if let Some(ref t) = *arg_type {
[INFO] [stderr]     |                        ^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 | /         match self {
[INFO] [stderr] 126 | |             &Argument::FunctionDefinition{ref name, ref default, ..} => {
[INFO] [stderr] 127 | |                 output.push_str(&name[..]);
[INFO] [stderr] 128 | |                 if let &Some(ref default) = default {
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |             },
[INFO] [stderr] 138 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 125 |         match *self {
[INFO] [stderr] 126 |             Argument::FunctionDefinition{ref name, ref default, ..} => {
[INFO] [stderr] 127 |                 output.push_str(&name[..]);
[INFO] [stderr] 128 |                 if let &Some(ref default) = default {
[INFO] [stderr] 129 |                     output.push_str(&format!("={}", default));
[INFO] [stderr] 130 |                 }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:128:17
[INFO] [stderr]     |
[INFO] [stderr] 128 | /                 if let &Some(ref default) = default {
[INFO] [stderr] 129 | |                     output.push_str(&format!("={}", default));
[INFO] [stderr] 130 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 128 |                 if let Some(ref default) = *default {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/argument.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 output.push_str(&format!("{}", name)[..]);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::Block`
[INFO] [stderr]   --> src/block.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> Block {
[INFO] [stderr] 56 | |         Block {
[INFO] [stderr] 57 | |             indentation: 0,
[INFO] [stderr] 58 | |             statements: vec![],
[INFO] [stderr] 59 | |         }
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/function.rs:135:12
[INFO] [stderr]     |
[INFO] [stderr] 135 |         if arg_help.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg_help.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/function.rs:139:12
[INFO] [stderr]     |
[INFO] [stderr] 139 |         if docstring.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!docstring.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/statement.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let s: String = match self {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 19 | |             &Statement::Argument(ref s) => format!("{}", s),
[INFO] [stderr] 20 | |             &Statement::Assignment(ref s) => format!("{}", s),
[INFO] [stderr] 21 | |             &Statement::Comment(ref s) => format!("{}", s),
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |             &Statement::KeywordArgument(ref s) => format!("{}", s),
[INFO] [stderr] 26 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let s: String = match *self {
[INFO] [stderr] 19 |             Statement::Argument(ref s) => format!("{}", s),
[INFO] [stderr] 20 |             Statement::Assignment(ref s) => format!("{}", s),
[INFO] [stderr] 21 |             Statement::Comment(ref s) => format!("{}", s),
[INFO] [stderr] 22 |             Statement::Class(ref s) => format!("{}", s),
[INFO] [stderr] 23 |             Statement::FunctionCall(ref s) => format!("{}", s),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/argument.rs:84:9
[INFO] [stderr]    |
[INFO] [stderr] 84 | /         match self {
[INFO] [stderr] 85 | |             &Argument::FunctionDefinition{ref help, .. } => help.is_some(),
[INFO] [stderr] 86 | |             _ => false,
[INFO] [stderr] 87 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 84 |         match *self {
[INFO] [stderr] 85 |             Argument::FunctionDefinition{ref help, .. } => help.is_some(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:91:9
[INFO] [stderr]     |
[INFO] [stderr] 91  | /         match self {
[INFO] [stderr] 92  | |             &Argument::FunctionDefinition{ref help,  ref name, ..} => {
[INFO] [stderr] 93  | |                 let mut formatted_help = format!(":param {}:", name);
[INFO] [stderr] 94  | |
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |             _ => None,
[INFO] [stderr] 103 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 91  |         match *self {
[INFO] [stderr] 92  |             Argument::FunctionDefinition{ref help,  ref name, ..} => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:95:17
[INFO] [stderr]     |
[INFO] [stderr] 95  | /                 if let &Some(ref help_str) = help {
[INFO] [stderr] 96  | |                     formatted_help.push_str(&format!(" {}", help_str)[..]);
[INFO] [stderr] 97  | |                     Some(formatted_help)
[INFO] [stderr] 98  | |                 } else {
[INFO] [stderr] 99  | |                     None
[INFO] [stderr] 100 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 95  |                 if let Some(ref help_str) = *help {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 | /         match self {
[INFO] [stderr] 108 | |             &Argument::FunctionDefinition{ref arg_type, ref name, ..} => {
[INFO] [stderr] 109 | |                 let mut help = format!(":type {}:", name);
[INFO] [stderr] 110 | |                 if let &Some(ref t) = arg_type {
[INFO] [stderr] ...   |
[INFO] [stderr] 117 | |             _ => None,
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 107 |         match *self {
[INFO] [stderr] 108 |             Argument::FunctionDefinition{ref arg_type, ref name, ..} => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:110:17
[INFO] [stderr]     |
[INFO] [stderr] 110 | /                 if let &Some(ref t) = arg_type {
[INFO] [stderr] 111 | |                     help.push_str(&format!(" {}", t)[..]);
[INFO] [stderr] 112 | |                     Some(help)
[INFO] [stderr] 113 | |                 } else {
[INFO] [stderr] 114 | |                     None
[INFO] [stderr] 115 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if let Some(ref t) = *arg_type {
[INFO] [stderr]     |                        ^^^^^^^^^^^   ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 | /         match self {
[INFO] [stderr] 126 | |             &Argument::FunctionDefinition{ref name, ref default, ..} => {
[INFO] [stderr] 127 | |                 output.push_str(&name[..]);
[INFO] [stderr] 128 | |                 if let &Some(ref default) = default {
[INFO] [stderr] ...   |
[INFO] [stderr] 137 | |             },
[INFO] [stderr] 138 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 125 |         match *self {
[INFO] [stderr] 126 |             Argument::FunctionDefinition{ref name, ref default, ..} => {
[INFO] [stderr] 127 |                 output.push_str(&name[..]);
[INFO] [stderr] 128 |                 if let &Some(ref default) = default {
[INFO] [stderr] 129 |                     output.push_str(&format!("={}", default));
[INFO] [stderr] 130 |                 }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/argument.rs:128:17
[INFO] [stderr]     |
[INFO] [stderr] 128 | /                 if let &Some(ref default) = default {
[INFO] [stderr] 129 | |                     output.push_str(&format!("={}", default));
[INFO] [stderr] 130 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 128 |                 if let Some(ref default) = *default {
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/argument.rs:136:34
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 output.push_str(&format!("{}", name)[..]);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::Block`
[INFO] [stderr]   --> src/block.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> Block {
[INFO] [stderr] 56 | |         Block {
[INFO] [stderr] 57 | |             indentation: 0,
[INFO] [stderr] 58 | |             statements: vec![],
[INFO] [stderr] 59 | |         }
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/function.rs:135:12
[INFO] [stderr]     |
[INFO] [stderr] 135 |         if arg_help.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!arg_help.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/function.rs:139:12
[INFO] [stderr]     |
[INFO] [stderr] 139 |         if docstring.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!docstring.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/statement.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |           let s: String = match self {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 19 | |             &Statement::Argument(ref s) => format!("{}", s),
[INFO] [stderr] 20 | |             &Statement::Assignment(ref s) => format!("{}", s),
[INFO] [stderr] 21 | |             &Statement::Comment(ref s) => format!("{}", s),
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |             &Statement::KeywordArgument(ref s) => format!("{}", s),
[INFO] [stderr] 26 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |         let s: String = match *self {
[INFO] [stderr] 19 |             Statement::Argument(ref s) => format!("{}", s),
[INFO] [stderr] 20 |             Statement::Assignment(ref s) => format!("{}", s),
[INFO] [stderr] 21 |             Statement::Comment(ref s) => format!("{}", s),
[INFO] [stderr] 22 |             Statement::Class(ref s) => format!("{}", s),
[INFO] [stderr] 23 |             Statement::FunctionCall(ref s) => format!("{}", s),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.34s
[INFO] running `"docker" "inspect" "1767cd4315457f18bdd04c64253284c3b2eee4f9f3dcfedf24d3f37c9389914e"`
[INFO] running `"docker" "rm" "-f" "1767cd4315457f18bdd04c64253284c3b2eee4f9f3dcfedf24d3f37c9389914e"`
[INFO] [stdout] 1767cd4315457f18bdd04c64253284c3b2eee4f9f3dcfedf24d3f37c9389914e