[INFO] crate promises 0.2.0 is already in cache [INFO] extracting crate promises 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/promises/0.2.0 [INFO] extracting crate promises 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promises/0.2.0 [INFO] validating manifest of promises-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of promises-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing promises-0.2.0 [INFO] finished frobbing promises-0.2.0 [INFO] frobbed toml for promises-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/promises/0.2.0/Cargo.toml [INFO] started frobbing promises-0.2.0 [INFO] finished frobbing promises-0.2.0 [INFO] frobbed toml for promises-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promises/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting promises-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/promises/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8da6aebf74a3528df014b9bb4b391459158dce5c58d281a4c124c641502c21f [INFO] running `"docker" "start" "-a" "e8da6aebf74a3528df014b9bb4b391459158dce5c58d281a4c124c641502c21f"` [INFO] [stderr] Checking promises v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Promise { receiver: rx }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise { receiver: rx }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/tests.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | return Promise { receiver: rx }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Promise { receiver: rx }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file` [INFO] [stderr] --> src/tests.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(file) => println!("Created a file!"), [INFO] [stderr] | ^^^^ help: consider using `_file` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p` [INFO] [stderr] --> src/tests.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let p: Promise<(), ()> = Promise::new(|| { [INFO] [stderr] | ^ help: consider using `_p` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `create_file` [INFO] [stderr] --> src/tests.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | fn create_file() -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / 'outer: loop { [INFO] [stderr] 239 | | // Don't get stuck in an infinite loop [INFO] [stderr] 240 | | if recs.len() == 0 { return; } [INFO] [stderr] 241 | | for i in 0..recs.len() { [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if recs.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `recs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / 'outer: loop { [INFO] [stderr] 262 | | for i in 0..mut_receivers.len() { [INFO] [stderr] 263 | | match mut_receivers[i].try_recv() { [INFO] [stderr] 264 | | Ok(val) => { [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:283:16 [INFO] [stderr] | [INFO] [stderr] 283 | if mut_receivers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mut_receivers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / 'outer: loop { [INFO] [stderr] 239 | | // Don't get stuck in an infinite loop [INFO] [stderr] 240 | | if recs.len() == 0 { return; } [INFO] [stderr] 241 | | for i in 0..recs.len() { [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if recs.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `recs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/lib.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | / 'outer: loop { [INFO] [stderr] 262 | | for i in 0..mut_receivers.len() { [INFO] [stderr] 263 | | match mut_receivers[i].try_recv() { [INFO] [stderr] 264 | | Ok(val) => { [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:283:16 [INFO] [stderr] | [INFO] [stderr] 283 | if mut_receivers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `mut_receivers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "e8da6aebf74a3528df014b9bb4b391459158dce5c58d281a4c124c641502c21f"` [INFO] running `"docker" "rm" "-f" "e8da6aebf74a3528df014b9bb4b391459158dce5c58d281a4c124c641502c21f"` [INFO] [stdout] e8da6aebf74a3528df014b9bb4b391459158dce5c58d281a4c124c641502c21f