[INFO] crate primes 0.2.3 is already in cache [INFO] extracting crate primes 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/primes/0.2.3 [INFO] extracting crate primes 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/primes/0.2.3 [INFO] validating manifest of primes-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of primes-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing primes-0.2.3 [INFO] finished frobbing primes-0.2.3 [INFO] frobbed toml for primes-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/primes/0.2.3/Cargo.toml [INFO] started frobbing primes-0.2.3 [INFO] finished frobbing primes-0.2.3 [INFO] frobbed toml for primes-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/primes/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting primes-0.2.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/primes/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c90f20baa0fc479c73875cbae676ad1818a6224c567b15555b422836cee12b40 [INFO] running `"docker" "start" "-a" "c90f20baa0fc479c73875cbae676ad1818a6224c567b15555b422836cee12b40"` [INFO] [stderr] Checking primes v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:168:48 [INFO] [stderr] | [INFO] [stderr] 168 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:168:48 [INFO] [stderr] | [INFO] [stderr] 168 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:168:48 [INFO] [stderr] | [INFO] [stderr] 168 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `wrong_self_convention` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:168:48 [INFO] [stderr] | [INFO] [stderr] 168 | #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::wrong_self_convention` [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benches.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `primes`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:62:27 [INFO] [stderr] | [INFO] [stderr] 62 | assert!(pset.is_prime(954377)); [INFO] [stderr] | ^^^^^^ help: consider: `954_377` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | assert!(pset.is_prime(954379)); [INFO] [stderr] | ^^^^^^ help: consider: `954_379` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | assert!(!pset.is_prime(954377*954379)); [INFO] [stderr] | ^^^^^^ help: consider: `954_377` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | assert!(!pset.is_prime(954377*954379)); [INFO] [stderr] | ^^^^^^ help: consider: `954_379` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | assert!(!is_prime(18409199*18409201)); [INFO] [stderr] | ^^^^^^^^ help: consider: `18_409_199` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | assert!(!is_prime(18409199*18409201)); [INFO] [stderr] | ^^^^^^^^ help: consider: `18_409_201` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:67:27 [INFO] [stderr] | [INFO] [stderr] 67 | assert!(pset.is_prime(18409199)); [INFO] [stderr] | ^^^^^^^^ help: consider: `18_409_199` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | assert!(pset.is_prime(18409201)); [INFO] [stderr] | ^^^^^^^^ help: consider: `18_409_201` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | assert!(!pset.is_prime(2147483643)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_643` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | assert!(pset.is_prime(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(!pset.is_prime(2147483649)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(!pset.is_prime(63061493)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_493` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | assert!(!pset.is_prime(63061491)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_491` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:75:27 [INFO] [stderr] | [INFO] [stderr] 75 | assert!(pset.is_prime(63061489)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:76:28 [INFO] [stderr] | [INFO] [stderr] 76 | assert!(!pset.is_prime(63061487)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_487` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:77:28 [INFO] [stderr] | [INFO] [stderr] 77 | assert!(!pset.is_prime(63061485)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_485` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | assert!(pset.is_prime(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | assert!(pset.is_prime(63061489)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:80:23 [INFO] [stderr] | [INFO] [stderr] 80 | assert!(!is_prime(63061489 * 2147483647)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | assert!(!is_prime(63061489 * 2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:81:23 [INFO] [stderr] | [INFO] [stderr] 81 | assert!(!is_prime(63061489 * 63061489)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/basictests.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | assert!(!is_prime(63061489 * 63061489)); [INFO] [stderr] | ^^^^^^^^ help: consider: `63_061_489` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> tests/basictests.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / fn test_primes(){ [INFO] [stderr] 40 | | let mut pset = PrimeSet::new(); [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | // note: some are repeated, because the pset list grows as it goes [INFO] [stderr] ... | [INFO] [stderr] 82 | | // assert!(!is_prime(2147483647 * 2147483647)); // Runs very long [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> tests/basictests.rs:113:49 [INFO] [stderr] | [INFO] [stderr] 113 | let mut unique_factors_exp : Vec = v.iter().map(|&x| {x}).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `v.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c90f20baa0fc479c73875cbae676ad1818a6224c567b15555b422836cee12b40"` [INFO] running `"docker" "rm" "-f" "c90f20baa0fc479c73875cbae676ad1818a6224c567b15555b422836cee12b40"` [INFO] [stdout] c90f20baa0fc479c73875cbae676ad1818a6224c567b15555b422836cee12b40