[INFO] crate prettify_pinyin 1.0.1 is already in cache [INFO] extracting crate prettify_pinyin 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/prettify_pinyin/1.0.1 [INFO] extracting crate prettify_pinyin 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prettify_pinyin/1.0.1 [INFO] validating manifest of prettify_pinyin-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of prettify_pinyin-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing prettify_pinyin-1.0.1 [INFO] finished frobbing prettify_pinyin-1.0.1 [INFO] frobbed toml for prettify_pinyin-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/prettify_pinyin/1.0.1/Cargo.toml [INFO] started frobbing prettify_pinyin-1.0.1 [INFO] finished frobbing prettify_pinyin-1.0.1 [INFO] frobbed toml for prettify_pinyin-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prettify_pinyin/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting prettify_pinyin-1.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/prettify_pinyin/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0ba84356786a6aa294ccce1160b886d14df23b2720986067b32762b3b0ba58a [INFO] running `"docker" "start" "-a" "f0ba84356786a6aa294ccce1160b886d14df23b2720986067b32762b3b0ba58a"` [INFO] [stderr] Checking prettify_pinyin v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return pretty_pinyin; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pretty_pinyin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return pretty_pinyin; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pretty_pinyin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:76:40 [INFO] [stderr] | [INFO] [stderr] 76 | let syllables: Vec<_> = text.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:102:21 [INFO] [stderr] | [INFO] [stderr] 102 | / let to_replace; [INFO] [stderr] 103 | | [INFO] [stderr] 104 | | if replacements.contains_key(&next_letter) && medials.contains_key(¤t_letter) { [INFO] [stderr] 105 | | to_replace = next_letter; [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | to_replace = current_letter; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let to_replace = if replacements.contains_key(&next_letter) && medials.contains_key(¤t_letter) { next_letter } else { current_letter };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:110:74 [INFO] [stderr] | [INFO] [stderr] 110 | let replaced: String = syllable.replace(&to_replace, replacements.get(&to_replace).unwrap().get((tone - (1 as i32)) as usize).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&replacements[&to_replace]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | j = j + (1 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `j += (1 as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:76:40 [INFO] [stderr] | [INFO] [stderr] 76 | let syllables: Vec<_> = text.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:102:21 [INFO] [stderr] | [INFO] [stderr] 102 | / let to_replace; [INFO] [stderr] 103 | | [INFO] [stderr] 104 | | if replacements.contains_key(&next_letter) && medials.contains_key(¤t_letter) { [INFO] [stderr] 105 | | to_replace = next_letter; [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | to_replace = current_letter; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let to_replace = if replacements.contains_key(&next_letter) && medials.contains_key(¤t_letter) { next_letter } else { current_letter };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:110:74 [INFO] [stderr] | [INFO] [stderr] 110 | let replaced: String = syllable.replace(&to_replace, replacements.get(&to_replace).unwrap().get((tone - (1 as i32)) as usize).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&replacements[&to_replace]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | j = j + (1 as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `j += (1 as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "f0ba84356786a6aa294ccce1160b886d14df23b2720986067b32762b3b0ba58a"` [INFO] running `"docker" "rm" "-f" "f0ba84356786a6aa294ccce1160b886d14df23b2720986067b32762b3b0ba58a"` [INFO] [stdout] f0ba84356786a6aa294ccce1160b886d14df23b2720986067b32762b3b0ba58a