[INFO] crate pretable 0.3.3 is already in cache [INFO] extracting crate pretable 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/pretable/0.3.3 [INFO] extracting crate pretable 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretable/0.3.3 [INFO] validating manifest of pretable-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pretable-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pretable-0.3.3 [INFO] finished frobbing pretable-0.3.3 [INFO] frobbed toml for pretable-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/pretable/0.3.3/Cargo.toml [INFO] started frobbing pretable-0.3.3 [INFO] finished frobbing pretable-0.3.3 [INFO] frobbed toml for pretable-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretable/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pretable-0.3.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pretable/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e572b2473c37ebcd56657fe5a3018aec5f2d4bfb9692a9e14033f22af340a06 [INFO] running `"docker" "start" "-a" "7e572b2473c37ebcd56657fe5a3018aec5f2d4bfb9692a9e14033f22af340a06"` [INFO] [stderr] Checking pretable v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PreTable` [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | items: Vec::new(), [INFO] [stderr] 17 | | header_len: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | for ref value in r { [INFO] [stderr] | ^^^^^^^^^ - help: try: `let value = &r;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | Self::format_center(match value { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 94 | | &Some(vv) => vv, [INFO] [stderr] 95 | | &None => "", [INFO] [stderr] 96 | | }, value_len_vec[inc()] + 2, &mut result); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | Self::format_center(match *value { [INFO] [stderr] 94 | Some(vv) => vv, [INFO] [stderr] 95 | None => "", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn is_body_split(&mut self, b: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `PreTable` [INFO] [stderr] --> src/lib.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | Self { [INFO] [stderr] 16 | | items: Vec::new(), [INFO] [stderr] 17 | | header_len: 0, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | for ref value in r { [INFO] [stderr] | ^^^^^^^^^ - help: try: `let value = &r;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | Self::format_center(match value { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 94 | | &Some(vv) => vv, [INFO] [stderr] 95 | | &None => "", [INFO] [stderr] 96 | | }, value_len_vec[inc()] + 2, &mut result); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | Self::format_center(match *value { [INFO] [stderr] 94 | Some(vv) => vv, [INFO] [stderr] 95 | None => "", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:128:26 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn is_body_split(&mut self, b: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.91s [INFO] running `"docker" "inspect" "7e572b2473c37ebcd56657fe5a3018aec5f2d4bfb9692a9e14033f22af340a06"` [INFO] running `"docker" "rm" "-f" "7e572b2473c37ebcd56657fe5a3018aec5f2d4bfb9692a9e14033f22af340a06"` [INFO] [stdout] 7e572b2473c37ebcd56657fe5a3018aec5f2d4bfb9692a9e14033f22af340a06