[INFO] crate pnet_macros_support 0.21.0 is already in cache
[INFO] extracting crate pnet_macros_support 0.21.0 into work/ex/clippy-test-run/sources/stable/reg/pnet_macros_support/0.21.0
[INFO] extracting crate pnet_macros_support 0.21.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_macros_support/0.21.0
[INFO] validating manifest of pnet_macros_support-0.21.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pnet_macros_support-0.21.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pnet_macros_support-0.21.0
[INFO] finished frobbing pnet_macros_support-0.21.0
[INFO] frobbed toml for pnet_macros_support-0.21.0 written to work/ex/clippy-test-run/sources/stable/reg/pnet_macros_support/0.21.0/Cargo.toml
[INFO] started frobbing pnet_macros_support-0.21.0
[INFO] finished frobbing pnet_macros_support-0.21.0
[INFO] frobbed toml for pnet_macros_support-0.21.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_macros_support/0.21.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pnet_macros_support-0.21.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pnet_macros_support/0.21.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b09eed22bc415781358c78c7ccc4a790f2f8694817fdf08afb9dc80e6dc78b2b
[INFO] running `"docker" "start" "-a" "b09eed22bc415781358c78c7ccc4a790f2f8694817fdf08afb9dc80e6dc78b2b"`
[INFO] [stderr]     Checking pnet_base v0.21.0
[INFO] [stderr]     Checking pnet_macros_support v0.21.0 (/opt/crater/workdir)
[INFO] [stderr] warning: item `packet::PacketData<'p>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/packet.rs:91:1
[INFO] [stderr]     |
[INFO] [stderr] 91  | / impl<'p> PacketData<'p> {
[INFO] [stderr] 92  | |     /// Get a slice of the packet data
[INFO] [stderr] 93  | |     pub fn as_slice(&self) -> &[u8] {
[INFO] [stderr] 94  | |         match self {
[INFO] [stderr] ...   |
[INFO] [stderr] 108 | |     }
[INFO] [stderr] 109 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/packet.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self {
[INFO] [stderr] 95 | |             &PacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 96 | |             &PacketData::Borrowed(ref data) => data,
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |         match *self {
[INFO] [stderr] 95 |             PacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 96 |             PacketData::Borrowed(ref data) => data,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/packet.rs:101:25
[INFO] [stderr]     |
[INFO] [stderr] 101 |     pub fn to_immutable(self) -> PacketData<'p> {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: item `packet::MutPacketData<'p>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/packet.rs:126:1
[INFO] [stderr]     |
[INFO] [stderr] 126 | / impl<'p> MutPacketData<'p> {
[INFO] [stderr] 127 | |     /// Get packet data as a slice
[INFO] [stderr] 128 | |     pub fn as_slice(&self) -> &[u8] {
[INFO] [stderr] 129 | |         match self {
[INFO] [stderr] ...   |
[INFO] [stderr] 154 | |     }
[INFO] [stderr] 155 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/packet.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match self {
[INFO] [stderr] 130 | |             &MutPacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 131 | |             &MutPacketData::Borrowed(ref data) => data,
[INFO] [stderr] 132 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *self {
[INFO] [stderr] 130 |             MutPacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 131 |             MutPacketData::Borrowed(ref data) => data,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/packet.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 | /         match self {
[INFO] [stderr] 138 | |             &mut MutPacketData::Owned(ref mut data) => data.deref_mut(),
[INFO] [stderr] 139 | |             &mut MutPacketData::Borrowed(ref mut data) => data,
[INFO] [stderr] 140 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 137 |         match *self {
[INFO] [stderr] 138 |             MutPacketData::Owned(ref mut data) => data.deref_mut(),
[INFO] [stderr] 139 |             MutPacketData::Borrowed(ref mut data) => data,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/packet.rs:144:25
[INFO] [stderr]     |
[INFO] [stderr] 144 |     pub fn to_immutable(self) -> PacketData<'p> {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: item `packet::PacketData<'p>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/packet.rs:91:1
[INFO] [stderr]     |
[INFO] [stderr] 91  | / impl<'p> PacketData<'p> {
[INFO] [stderr] 92  | |     /// Get a slice of the packet data
[INFO] [stderr] 93  | |     pub fn as_slice(&self) -> &[u8] {
[INFO] [stderr] 94  | |         match self {
[INFO] [stderr] ...   |
[INFO] [stderr] 108 | |     }
[INFO] [stderr] 109 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/packet.rs:94:9
[INFO] [stderr]    |
[INFO] [stderr] 94 | /         match self {
[INFO] [stderr] 95 | |             &PacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 96 | |             &PacketData::Borrowed(ref data) => data,
[INFO] [stderr] 97 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |         match *self {
[INFO] [stderr] 95 |             PacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 96 |             PacketData::Borrowed(ref data) => data,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/packet.rs:101:25
[INFO] [stderr]     |
[INFO] [stderr] 101 |     pub fn to_immutable(self) -> PacketData<'p> {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: item `packet::MutPacketData<'p>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/packet.rs:126:1
[INFO] [stderr]     |
[INFO] [stderr] 126 | / impl<'p> MutPacketData<'p> {
[INFO] [stderr] 127 | |     /// Get packet data as a slice
[INFO] [stderr] 128 | |     pub fn as_slice(&self) -> &[u8] {
[INFO] [stderr] 129 | |         match self {
[INFO] [stderr] ...   |
[INFO] [stderr] 154 | |     }
[INFO] [stderr] 155 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/packet.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         match self {
[INFO] [stderr] 130 | |             &MutPacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 131 | |             &MutPacketData::Borrowed(ref data) => data,
[INFO] [stderr] 132 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 129 |         match *self {
[INFO] [stderr] 130 |             MutPacketData::Owned(ref data) => data.deref(),
[INFO] [stderr] 131 |             MutPacketData::Borrowed(ref data) => data,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/packet.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 | /         match self {
[INFO] [stderr] 138 | |             &mut MutPacketData::Owned(ref mut data) => data.deref_mut(),
[INFO] [stderr] 139 | |             &mut MutPacketData::Borrowed(ref mut data) => data,
[INFO] [stderr] 140 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 137 |         match *self {
[INFO] [stderr] 138 |             MutPacketData::Owned(ref mut data) => data.deref_mut(),
[INFO] [stderr] 139 |             MutPacketData::Borrowed(ref mut data) => data,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/packet.rs:144:25
[INFO] [stderr]     |
[INFO] [stderr] 144 |     pub fn to_immutable(self) -> PacketData<'p> {
[INFO] [stderr]     |                         ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.21s
[INFO] running `"docker" "inspect" "b09eed22bc415781358c78c7ccc4a790f2f8694817fdf08afb9dc80e6dc78b2b"`
[INFO] running `"docker" "rm" "-f" "b09eed22bc415781358c78c7ccc4a790f2f8694817fdf08afb9dc80e6dc78b2b"`
[INFO] [stdout] b09eed22bc415781358c78c7ccc4a790f2f8694817fdf08afb9dc80e6dc78b2b