[INFO] crate plotlib 0.3.0 is already in cache [INFO] extracting crate plotlib 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/plotlib/0.3.0 [INFO] extracting crate plotlib 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plotlib/0.3.0 [INFO] validating manifest of plotlib-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of plotlib-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing plotlib-0.3.0 [INFO] finished frobbing plotlib-0.3.0 [INFO] frobbed toml for plotlib-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/plotlib/0.3.0/Cargo.toml [INFO] started frobbing plotlib-0.3.0 [INFO] finished frobbing plotlib-0.3.0 [INFO] frobbed toml for plotlib-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plotlib/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting plotlib-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/plotlib/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5fe4d70677ca225defd61832b0511216f38ae322dfc4e0f83cf9134a748245f [INFO] running `"docker" "start" "-a" "f5fe4d70677ca225defd61832b0511216f38ae322dfc4e0f83cf9134a748245f"` [INFO] [stderr] Checking svg v0.5.12 [INFO] [stderr] Checking plotlib v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scatter.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | lower: lower, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | upper: upper, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_render.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scatter.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | lower: lower, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lower` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/axis.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | upper: upper, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `upper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text_render.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/view.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | view_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/view.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | let view_string = text_render::overlay( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 178 | | &view_string, [INFO] [stderr] 179 | | &x_axis_string, [INFO] [stderr] 180 | | left_gutter_width as i32, [INFO] [stderr] 181 | | face_height as i32, [INFO] [stderr] 182 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/view.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | view_string [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/view.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | let view_string = text_render::overlay( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 178 | | &view_string, [INFO] [stderr] 179 | | &x_axis_string, [INFO] [stderr] 180 | | left_gutter_width as i32, [INFO] [stderr] 181 | | face_height as i32, [INFO] [stderr] 182 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_axis` [INFO] [stderr] --> src/function.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | x_axis: &axis::Axis, [INFO] [stderr] | ^^^^^^ help: consider using `_x_axis` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_axis` [INFO] [stderr] --> src/function.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | y_axis: &axis::Axis, [INFO] [stderr] | ^^^^^^ help: consider using `_y_axis` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `face_width` [INFO] [stderr] --> src/function.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | face_width: u32, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_face_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `face_height` [INFO] [stderr] --> src/function.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | face_height: u32, [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_face_height` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_views` [INFO] [stderr] --> src/page.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | num_views: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/view.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn add(mut self, repr: &'a Representation) -> Self { [INFO] [stderr] 44 | | self.representations.push(repr); [INFO] [stderr] 45 | | self [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/page.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match path.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stderr] 67 | | Some("svg") => { [INFO] [stderr] 68 | | svg::save(path, &self.to_svg()).unwrap(); [INFO] [stderr] 69 | | } [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | if let Some("svg") = path.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stderr] 67 | svg::save(path, &self.to_svg()).unwrap(); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:111:52 [INFO] [stderr] | [INFO] [stderr] 111 | let density_per_bin = bins.iter().map(|&x| x as f64 / bin_width).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | (0., max as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scatter.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | self.size = Some(v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/function.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | self.width = Some(v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/function.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | .map(|x| lower + (x as f64 * sampling)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | .map(|&s| (s as f64 * base_step_scale)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | .map(|n| -1.0 * n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | .map(|n| n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:139:37 [INFO] [stderr] | [INFO] [stderr] 139 | .map(|n| -1.0 * n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:151:26 [INFO] [stderr] | [INFO] [stderr] 151 | .map(|n| n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text_render.rs:15:53 [INFO] [stderr] | [INFO] [stderr] 15 | let data_per_cell = (axis.max() - axis.min()) / face_cells as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(face_cells)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:152:35 [INFO] [stderr] | [INFO] [stderr] 152 | let y_label_strings: Vec<_> = (0..face_height + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let y_tick_strings: Vec<_> = (0..face_height + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:204:38 [INFO] [stderr] | [INFO] [stderr] 204 | let x_axis_tick_string: String = (0..face_width + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text_render.rs:295:43 [INFO] [stderr] | [INFO] [stderr] 295 | value_to_axis_cell_offset(h.bin_counts[b as usize] as f64, y_axis, face_height) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(h.bin_counts[b as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | for line in 1..face_height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=face_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:304:23 [INFO] [stderr] | [INFO] [stderr] 304 | for column in 1..face_width as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=face_width as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | for line in 1..face_height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=face_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:384:23 [INFO] [stderr] | [INFO] [stderr] 384 | for column in 1..face_width as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=face_width as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/svg_render.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | let radius = style.get_size().clone().unwrap_or(5.) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(style.get_size().clone().unwrap_or(5.))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/svg_render.rs:197:49 [INFO] [stderr] | [INFO] [stderr] 197 | let count_scaled = value_to_face_offset(count as f64, y_axis, face_height); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_axis` [INFO] [stderr] --> src/function.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | x_axis: &axis::Axis, [INFO] [stderr] | ^^^^^^ help: consider using `_x_axis` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_axis` [INFO] [stderr] --> src/function.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | y_axis: &axis::Axis, [INFO] [stderr] | ^^^^^^ help: consider using `_y_axis` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `face_width` [INFO] [stderr] --> src/function.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | face_width: u32, [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_face_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `face_height` [INFO] [stderr] --> src/function.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | face_height: u32, [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_face_height` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num_views` [INFO] [stderr] --> src/page.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | num_views: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name [INFO] [stderr] --> src/view.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn add(mut self, repr: &'a Representation) -> Self { [INFO] [stderr] 44 | | self.representations.push(repr); [INFO] [stderr] 45 | | self [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/page.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match path.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stderr] 67 | | Some("svg") => { [INFO] [stderr] 68 | | svg::save(path, &self.to_svg()).unwrap(); [INFO] [stderr] 69 | | } [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | if let Some("svg") = path.as_ref().extension().and_then(OsStr::to_str) { [INFO] [stderr] 67 | svg::save(path, &self.to_svg()).unwrap(); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:111:52 [INFO] [stderr] | [INFO] [stderr] 111 | let density_per_bin = bins.iter().map(|&x| x as f64 / bin_width).collect(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | (0., max as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scatter.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | self.size = Some(v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/function.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | self.width = Some(v.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/function.rs:88:31 [INFO] [stderr] | [INFO] [stderr] 88 | .map(|x| lower + (x as f64 * sampling)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:95:24 [INFO] [stderr] | [INFO] [stderr] 95 | .map(|&s| (s as f64 * base_step_scale)) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | .map(|n| -1.0 * n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | .map(|n| n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:139:37 [INFO] [stderr] | [INFO] [stderr] 139 | .map(|n| -1.0 * n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/axis.rs:151:26 [INFO] [stderr] | [INFO] [stderr] 151 | .map(|n| n as f64 * step_size) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | assert_eq!(calculate_tick_step_for_range(0.0, 3.0, 6), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | assert_eq!(calculate_tick_step_for_range(0.0, 3.0, 6), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(calculate_tick_step_for_range(0.0, 6.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(calculate_tick_step_for_range(0.0, 6.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(calculate_tick_step_for_range(0.0, 11.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | assert_eq!(calculate_tick_step_for_range(0.0, 11.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | assert_eq!(calculate_tick_step_for_range(0.0, 14.0, 6), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | assert_eq!(calculate_tick_step_for_range(0.0, 14.0, 6), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(calculate_tick_step_for_range(0.0, 15.0, 6), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(calculate_tick_step_for_range(0.0, 15.0, 6), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(calculate_tick_step_for_range(-1.0, 5.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(calculate_tick_step_for_range(-1.0, 5.0, 6), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | assert_eq!(calculate_tick_step_for_range(-7.93, 15.58, 6), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | assert_eq!(calculate_tick_step_for_range(-7.93, 15.58, 6), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/axis.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(calculate_tick_step_for_range(0.0, 0.06, 6), 0.02); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/axis.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(calculate_tick_step_for_range(0.0, 0.06, 6), 0.02); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/axis.rs:238:5 [INFO] [stderr] | [INFO] [stderr] 238 | / fn test_calculate_ticks() { [INFO] [stderr] 239 | | macro_rules! assert_approx_eq { [INFO] [stderr] 240 | | ($a:expr, $b:expr) => ({ [INFO] [stderr] 241 | | let (a, b) = (&$a, &$b); [INFO] [stderr] ... | [INFO] [stderr] 349 | | assert_eq!(calculate_ticks(-10.0, -3.0, 6), [-10.0, -8.0, -6.0, -4.0]); [INFO] [stderr] 350 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text_render.rs:15:53 [INFO] [stderr] | [INFO] [stderr] 15 | let data_per_cell = (axis.max() - axis.min()) / face_cells as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(face_cells)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:152:35 [INFO] [stderr] | [INFO] [stderr] 152 | let y_label_strings: Vec<_> = (0..face_height + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let y_tick_strings: Vec<_> = (0..face_height + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:204:38 [INFO] [stderr] | [INFO] [stderr] 204 | let x_axis_tick_string: String = (0..face_width + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=face_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/text_render.rs:295:43 [INFO] [stderr] | [INFO] [stderr] 295 | value_to_axis_cell_offset(h.bin_counts[b as usize] as f64, y_axis, face_height) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(h.bin_counts[b as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | for line in 1..face_height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=face_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:304:23 [INFO] [stderr] | [INFO] [stderr] 304 | for column in 1..face_width as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=face_width as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:382:17 [INFO] [stderr] | [INFO] [stderr] 382 | for line in 1..face_height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=face_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/text_render.rs:384:23 [INFO] [stderr] | [INFO] [stderr] 384 | for column in 1..face_width as usize + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=face_width as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:496:32 [INFO] [stderr] | [INFO] [stderr] 496 | run_bins_for_cells(&vec![-4, -1, 4, 7, 10]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-4, -1, 4, 7, 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:500:32 [INFO] [stderr] | [INFO] [stderr] 500 | run_bins_for_cells(&vec![0, 2, 4, 8, 10]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 2, 4, 8, 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:504:32 [INFO] [stderr] | [INFO] [stderr] 504 | run_bins_for_cells(&vec![3, 5, 7, 9, 10]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[3, 5, 7, 9, 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:508:32 [INFO] [stderr] | [INFO] [stderr] 508 | run_bins_for_cells(&vec![0, 2, 4, 6, 8]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 2, 4, 6, 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:512:32 [INFO] [stderr] | [INFO] [stderr] 512 | run_bins_for_cells(&vec![0, 3, 6, 9, 12]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 3, 6, 9, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:517:32 [INFO] [stderr] | [INFO] [stderr] 517 | run_bins_for_cells(&vec![-5, -4, -3, -1, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-5, -4, -3, -1, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:521:32 [INFO] [stderr] | [INFO] [stderr] 521 | run_bins_for_cells(&vec![10, 12, 14, 16, 18]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12, 14, 16, 18]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:526:32 [INFO] [stderr] | [INFO] [stderr] 526 | run_bins_for_cells(&vec![15, 16, 17, 18, 19]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[15, 16, 17, 18, 19]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/text_render.rs:530:32 [INFO] [stderr] | [INFO] [stderr] 530 | run_bins_for_cells(&vec![-19, -18, -17, -16, -1]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[-19, -18, -17, -16, -1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/svg_render.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | let radius = style.get_size().clone().unwrap_or(5.) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(style.get_size().clone().unwrap_or(5.))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/svg_render.rs:197:49 [INFO] [stderr] | [INFO] [stderr] 197 | let count_scaled = value_to_face_offset(count as f64, y_axis, face_height); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/svg_render.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | assert_eq!(value_to_face_offset(-2.0, &axis, 14.0), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/svg_render.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | assert_eq!(value_to_face_offset(-2.0, &axis, 14.0), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/svg_render.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | assert_eq!(value_to_face_offset(5.0, &axis, 14.0), 14.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/svg_render.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | assert_eq!(value_to_face_offset(5.0, &axis, 14.0), 14.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/svg_render.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | assert_eq!(value_to_face_offset(0.0, &axis, 14.0), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/svg_render.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | assert_eq!(value_to_face_offset(0.0, &axis, 14.0), 4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/svg_render.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(value_to_face_offset(-4.0, &axis, 14.0), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/svg_render.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(value_to_face_offset(-4.0, &axis, 14.0), -4.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/svg_render.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(value_to_face_offset(7.0, &axis, 14.0), 18.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/svg_render.rs:274:9 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(value_to_face_offset(7.0, &axis, 14.0), 18.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `plotlib`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f5fe4d70677ca225defd61832b0511216f38ae322dfc4e0f83cf9134a748245f"` [INFO] running `"docker" "rm" "-f" "f5fe4d70677ca225defd61832b0511216f38ae322dfc4e0f83cf9134a748245f"` [INFO] [stdout] f5fe4d70677ca225defd61832b0511216f38ae322dfc4e0f83cf9134a748245f