[INFO] crate piston-texture 0.6.0 is already in cache [INFO] extracting crate piston-texture 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/piston-texture/0.6.0 [INFO] extracting crate piston-texture 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-texture/0.6.0 [INFO] validating manifest of piston-texture-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston-texture-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston-texture-0.6.0 [INFO] finished frobbing piston-texture-0.6.0 [INFO] frobbed toml for piston-texture-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/piston-texture/0.6.0/Cargo.toml [INFO] started frobbing piston-texture-0.6.0 [INFO] finished frobbing piston-texture-0.6.0 [INFO] frobbed toml for piston-texture-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-texture/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston-texture-0.6.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-texture/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8ac4e0a34a10db50dd657a6976942f5c5528260aeabbf046301f6e0c722a9eb [INFO] running `"docker" "start" "-a" "b8ac4e0a34a10db50dd657a6976942f5c5528260aeabbf046301f6e0c722a9eb"` [INFO] [stderr] Checking piston-texture v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TextureSettings` [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> TextureSettings { [INFO] [stderr] 53 | | TextureSettings { [INFO] [stderr] 54 | | convert_gamma: false, [INFO] [stderr] 55 | | compress: false, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for TextureSettings { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_convert_gamma(&self) -> bool { self.convert_gamma } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_compress(&self) -> bool { self.compress } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_generate_mipmap(&self) -> bool { self.generate_mipmap } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn get_min(&self) -> Filter { self.min } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn get_mag(&self) -> Filter { self.mag } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:120:23 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn get_mipmap(&self) -> Filter { self.mipmap } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn get_filter(&self) -> (Filter, Filter) { (self.min, self.mag) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TextureSettings` [INFO] [stderr] --> src/lib.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn new() -> TextureSettings { [INFO] [stderr] 53 | | TextureSettings { [INFO] [stderr] 54 | | convert_gamma: false, [INFO] [stderr] 55 | | compress: false, [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for TextureSettings { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:64:30 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_convert_gamma(&self) -> bool { self.convert_gamma } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_compress(&self) -> bool { self.compress } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:32 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn get_generate_mipmap(&self) -> bool { self.generate_mipmap } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn get_min(&self) -> Filter { self.min } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:108:20 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn get_mag(&self) -> Filter { self.mag } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:120:23 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn get_mipmap(&self) -> Filter { self.mipmap } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn get_filter(&self) -> (Filter, Filter) { (self.min, self.mag) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | settings: &TextureSettings [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TextureSettings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "b8ac4e0a34a10db50dd657a6976942f5c5528260aeabbf046301f6e0c722a9eb"` [INFO] running `"docker" "rm" "-f" "b8ac4e0a34a10db50dd657a6976942f5c5528260aeabbf046301f6e0c722a9eb"` [INFO] [stdout] b8ac4e0a34a10db50dd657a6976942f5c5528260aeabbf046301f6e0c722a9eb