[INFO] crate piston-binpool 0.1.0 is already in cache [INFO] extracting crate piston-binpool 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/piston-binpool/0.1.0 [INFO] extracting crate piston-binpool 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-binpool/0.1.0 [INFO] validating manifest of piston-binpool-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piston-binpool-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piston-binpool-0.1.0 [INFO] finished frobbing piston-binpool-0.1.0 [INFO] frobbed toml for piston-binpool-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/piston-binpool/0.1.0/Cargo.toml [INFO] started frobbing piston-binpool-0.1.0 [INFO] finished frobbing piston-binpool-0.1.0 [INFO] frobbed toml for piston-binpool-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-binpool/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piston-binpool-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piston-binpool/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d0f49302181f74eec52727dedf5bb160e62101ee5422c8bb58a4929170b1773 [INFO] running `"docker" "start" "-a" "7d0f49302181f74eec52727dedf5bb160e62101ee5422c8bb58a4929170b1773"` [INFO] [stderr] Checking piston-binpool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:530:9 [INFO] [stderr] | [INFO] [stderr] 530 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:492:9 [INFO] [stderr] | [INFO] [stderr] 492 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/read_write.rs:530:9 [INFO] [stderr] | [INFO] [stderr] 530 | return Err(io::ErrorKind::InvalidData.into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::ErrorKind::InvalidData.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: trait `Array` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/read_write.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub trait Array { [INFO] [stderr] 9 | | /// The type of item. [INFO] [stderr] 10 | | type Item; [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 19 | | fn push(&mut self, val: Self::Item); [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: trait `Array` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/read_write.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub trait Array { [INFO] [stderr] 9 | | /// The type of item. [INFO] [stderr] 10 | | type Item; [INFO] [stderr] 11 | | [INFO] [stderr] ... | [INFO] [stderr] 19 | | fn push(&mut self, val: Self::Item); [INFO] [stderr] 20 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:558:30 [INFO] [stderr] | [INFO] [stderr] 558 | *self = u16::from_le(buf[0] as u16 | (buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:558:46 [INFO] [stderr] | [INFO] [stderr] 558 | *self = u16::from_le(buf[0] as u16 | (buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | buf[0] as u32 | (buf[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:574:29 [INFO] [stderr] | [INFO] [stderr] 574 | buf[0] as u32 | (buf[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:575:13 [INFO] [stderr] | [INFO] [stderr] 575 | (buf[2] as u32) << 16 | (buf[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:575:37 [INFO] [stderr] | [INFO] [stderr] 575 | (buf[2] as u32) << 16 | (buf[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | buf[0] as u64 | (buf[1] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | buf[0] as u64 | (buf[1] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:596:13 [INFO] [stderr] | [INFO] [stderr] 596 | (buf[2] as u64) << 16 | (buf[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:596:37 [INFO] [stderr] | [INFO] [stderr] 596 | (buf[2] as u64) << 16 | (buf[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:597:13 [INFO] [stderr] | [INFO] [stderr] 597 | (buf[4] as u64) << 32 | (buf[5] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:597:37 [INFO] [stderr] | [INFO] [stderr] 597 | (buf[4] as u64) << 32 | (buf[5] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | (buf[6] as u64) << 48 | (buf[7] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:598:37 [INFO] [stderr] | [INFO] [stderr] 598 | (buf[6] as u64) << 48 | (buf[7] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/read_write.rs:666:17 [INFO] [stderr] | [INFO] [stderr] 666 | unsafe {transmute::<&f32, &u32>(self)}.write(w) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const f32 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/read_write.rs:673:25 [INFO] [stderr] | [INFO] [stderr] 673 | *self = unsafe {transmute::(val)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/read_write.rs:684:17 [INFO] [stderr] | [INFO] [stderr] 684 | unsafe {transmute::<&f64, &u64>(self)}.write(w) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const f64 as *const u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/read_write.rs:691:25 [INFO] [stderr] | [INFO] [stderr] 691 | *self = unsafe {transmute::(val)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn type_id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn type_size(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn matrix(&self, rows: u8, cols: u8) -> Option<(u16, u64)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | if cols == 0 || rows == 0 || cols as u16 > SIZE || rows as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:176:60 [INFO] [stderr] | [INFO] [stderr] 176 | if cols == 0 || rows == 0 || cols as u16 > SIZE || rows as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | ((rows-1) as u16) * SIZE + ((cols-1) as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(rows-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:44 [INFO] [stderr] | [INFO] [stderr] 181 | ((rows-1) as u16) * SIZE + ((cols-1) as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cols-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | self.type_size() * cols as u64 * rows as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:182:50 [INFO] [stderr] | [INFO] [stderr] 182 | self.type_size() * cols as u64 * rows as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:188:19 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn scalar(&self) -> (u16, u64) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:196:19 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn vector(&self, dim: u8) -> Option<(u16, u64)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | if dim == 0 || dim as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:52 [INFO] [stderr] | [INFO] [stderr] 201 | 1 + self.type_id() * SIZE * SIZE + (dim - 1) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(dim - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:202:36 [INFO] [stderr] | [INFO] [stderr] 202 | self.type_size() * dim as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | (((1 as u32) << 16) - Type::offset_custom_format() as u32) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(Type::offset_custom_format())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `State` [INFO] [stderr] --> src/lib.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | / pub fn new() -> State { [INFO] [stderr] 261 | | State(PhantomData) [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | w.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston-binpool`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:558:30 [INFO] [stderr] | [INFO] [stderr] 558 | *self = u16::from_le(buf[0] as u16 | (buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:558:46 [INFO] [stderr] | [INFO] [stderr] 558 | *self = u16::from_le(buf[0] as u16 | (buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:574:13 [INFO] [stderr] | [INFO] [stderr] 574 | buf[0] as u32 | (buf[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:574:29 [INFO] [stderr] | [INFO] [stderr] 574 | buf[0] as u32 | (buf[1] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:575:13 [INFO] [stderr] | [INFO] [stderr] 575 | (buf[2] as u32) << 16 | (buf[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:575:37 [INFO] [stderr] | [INFO] [stderr] 575 | (buf[2] as u32) << 16 | (buf[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:595:13 [INFO] [stderr] | [INFO] [stderr] 595 | buf[0] as u64 | (buf[1] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | buf[0] as u64 | (buf[1] as u64) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:596:13 [INFO] [stderr] | [INFO] [stderr] 596 | (buf[2] as u64) << 16 | (buf[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:596:37 [INFO] [stderr] | [INFO] [stderr] 596 | (buf[2] as u64) << 16 | (buf[3] as u64) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:597:13 [INFO] [stderr] | [INFO] [stderr] 597 | (buf[4] as u64) << 32 | (buf[5] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:597:37 [INFO] [stderr] | [INFO] [stderr] 597 | (buf[4] as u64) << 32 | (buf[5] as u64) << 40 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | (buf[6] as u64) << 48 | (buf[7] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/read_write.rs:598:37 [INFO] [stderr] | [INFO] [stderr] 598 | (buf[6] as u64) << 48 | (buf[7] as u64) << 56 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/read_write.rs:666:17 [INFO] [stderr] | [INFO] [stderr] 666 | unsafe {transmute::<&f32, &u32>(self)}.write(w) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const f32 as *const u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/read_write.rs:673:25 [INFO] [stderr] | [INFO] [stderr] 673 | *self = unsafe {transmute::(val)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/read_write.rs:684:17 [INFO] [stderr] | [INFO] [stderr] 684 | unsafe {transmute::<&f64, &u64>(self)}.write(w) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const f64 as *const u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/read_write.rs:691:25 [INFO] [stderr] | [INFO] [stderr] 691 | *self = unsafe {transmute::(val)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn type_id(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn type_size(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn matrix(&self, rows: u8, cols: u8) -> Option<(u16, u64)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:176:38 [INFO] [stderr] | [INFO] [stderr] 176 | if cols == 0 || rows == 0 || cols as u16 > SIZE || rows as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:176:60 [INFO] [stderr] | [INFO] [stderr] 176 | if cols == 0 || rows == 0 || cols as u16 > SIZE || rows as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | ((rows-1) as u16) * SIZE + ((cols-1) as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(rows-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:44 [INFO] [stderr] | [INFO] [stderr] 181 | ((rows-1) as u16) * SIZE + ((cols-1) as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(cols-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | self.type_size() * cols as u64 * rows as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(cols)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:182:50 [INFO] [stderr] | [INFO] [stderr] 182 | self.type_size() * cols as u64 * rows as u64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(rows)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:188:19 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn scalar(&self) -> (u16, u64) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:196:19 [INFO] [stderr] | [INFO] [stderr] 196 | pub fn vector(&self, dim: u8) -> Option<(u16, u64)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:197:24 [INFO] [stderr] | [INFO] [stderr] 197 | if dim == 0 || dim as u16 > SIZE { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:201:52 [INFO] [stderr] | [INFO] [stderr] 201 | 1 + self.type_id() * SIZE * SIZE + (dim - 1) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(dim - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:202:36 [INFO] [stderr] | [INFO] [stderr] 202 | self.type_size() * dim as u64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:214:31 [INFO] [stderr] | [INFO] [stderr] 214 | (((1 as u32) << 16) - Type::offset_custom_format() as u32) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(Type::offset_custom_format())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `State` [INFO] [stderr] --> src/lib.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | / pub fn new() -> State { [INFO] [stderr] 261 | | State(PhantomData) [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 256 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | w.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston-binpool`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7d0f49302181f74eec52727dedf5bb160e62101ee5422c8bb58a4929170b1773"` [INFO] running `"docker" "rm" "-f" "7d0f49302181f74eec52727dedf5bb160e62101ee5422c8bb58a4929170b1773"` [INFO] [stdout] 7d0f49302181f74eec52727dedf5bb160e62101ee5422c8bb58a4929170b1773