[INFO] crate pirate 1.0.0 is already in cache [INFO] extracting crate pirate 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/pirate/1.0.0 [INFO] extracting crate pirate 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pirate/1.0.0 [INFO] validating manifest of pirate-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pirate-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pirate-1.0.0 [INFO] finished frobbing pirate-1.0.0 [INFO] frobbed toml for pirate-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/pirate/1.0.0/Cargo.toml [INFO] started frobbing pirate-1.0.0 [INFO] finished frobbing pirate-1.0.0 [INFO] frobbed toml for pirate-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pirate/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pirate-1.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pirate/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6292f2daf24ddf4d4623d54f62b22e50ba8f9f6ff5549553ca10ef09877d2131 [INFO] running `"docker" "start" "-a" "6292f2daf24ddf4d4623d54f62b22e50ba8f9f6ff5549553ca10ef09877d2131"` [INFO] [stderr] Checking pirate v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | short_name: short_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | long_name: long_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `long_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | is_arg: is_arg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | has_arg: has_arg, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `has_arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | is_group: is_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | short_name: short_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | long_name: long_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `long_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | is_arg: is_arg, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | has_arg: has_arg, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `has_arg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | is_group: is_group, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | description: description, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | opts: opts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `opts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vars.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/token.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | let is_group = if short_name.is_empty() && long_name.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 77 | | true [INFO] [stderr] 78 | | } else { [INFO] [stderr] 79 | | false [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `short_name.is_empty() && long_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:143:32 [INFO] [stderr] | [INFO] [stderr] 143 | let name = String::from(self.name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | let name = String::from(self.name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.name()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused import: `Match` [INFO] [stderr] --> src/matches.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | use super::{Match, matches}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/matches.rs:119:23 [INFO] [stderr] | [INFO] [stderr] 119 | let has_opt = match matches.get("opt") { [INFO] [stderr] | _______________________^ [INFO] [stderr] 120 | | Some(_) => true, [INFO] [stderr] 121 | | None => false [INFO] [stderr] 122 | | }; [INFO] [stderr] | |_________^ help: try this: `matches.get("opt").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/matches.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | let argument = matches.get("a").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches["a"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/token.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | let is_group = if short_name.is_empty() && long_name.is_empty() { [INFO] [stderr] | ____________________^ [INFO] [stderr] 77 | | true [INFO] [stderr] 78 | | } else { [INFO] [stderr] 79 | | false [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ help: you can reduce it to: `short_name.is_empty() && long_name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:143:32 [INFO] [stderr] | [INFO] [stderr] 143 | let name = String::from(self.name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/token.rs:150:28 [INFO] [stderr] | [INFO] [stderr] 150 | let name = String::from(self.name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.name()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/main.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let augend: i32 = matches.get("augend").unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matches["augend"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `"docker" "inspect" "6292f2daf24ddf4d4623d54f62b22e50ba8f9f6ff5549553ca10ef09877d2131"` [INFO] running `"docker" "rm" "-f" "6292f2daf24ddf4d4623d54f62b22e50ba8f9f6ff5549553ca10ef09877d2131"` [INFO] [stdout] 6292f2daf24ddf4d4623d54f62b22e50ba8f9f6ff5549553ca10ef09877d2131