[INFO] crate piece_table 0.1.0 is already in cache [INFO] extracting crate piece_table 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/piece_table/0.1.0 [INFO] extracting crate piece_table 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piece_table/0.1.0 [INFO] validating manifest of piece_table-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of piece_table-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing piece_table-0.1.0 [INFO] finished frobbing piece_table-0.1.0 [INFO] frobbed toml for piece_table-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/piece_table/0.1.0/Cargo.toml [INFO] started frobbing piece_table-0.1.0 [INFO] finished frobbing piece_table-0.1.0 [INFO] frobbed toml for piece_table-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piece_table/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting piece_table-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/piece_table/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93ab8eabbbadf8aaceb2292627ca535e11a9a5eb0ec4227f8ed8a8c49db83cf7 [INFO] running `"docker" "start" "-a" "93ab8eabbbadf8aaceb2292627ca535e11a9a5eb0ec4227f8ed8a8c49db83cf7"` [INFO] [stderr] Checking piece_table v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | return self.read_only_buffer.chars().nth(pos as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_only_buffer.chars().nth(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | return self.append_only_buffer.chars().nth(pos as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append_only_buffer.chars().nth(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | return '\0'; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `'\0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | return self.read_only_buffer.chars().nth(pos as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read_only_buffer.chars().nth(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | return self.append_only_buffer.chars().nth(pos as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.append_only_buffer.chars().nth(pos as usize).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | return '\0'; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `'\0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | return Some((elem.clone(), index, cum)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match relevant_entry { [INFO] [stderr] 106 | | Some((ref buffer_entry, index, cum)) => { [INFO] [stderr] 107 | | let real_entry_start = cum; [INFO] [stderr] 108 | | let real_entry_end = cum + buffer_entry.length; [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Some((ref buffer_entry, index, cum)) = relevant_entry { [INFO] [stderr] 106 | let real_entry_start = cum; [INFO] [stderr] 107 | let real_entry_end = cum + buffer_entry.length; [INFO] [stderr] 108 | // Split relevant entry into two [INFO] [stderr] 109 | let first_piece_length = position - real_entry_start; [INFO] [stderr] 110 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | return Some((elem.clone(), index, cum)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match relevant_entry { [INFO] [stderr] 106 | | Some((ref buffer_entry, index, cum)) => { [INFO] [stderr] 107 | | let real_entry_start = cum; [INFO] [stderr] 108 | | let real_entry_end = cum + buffer_entry.length; [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | if let Some((ref buffer_entry, index, cum)) = relevant_entry { [INFO] [stderr] 106 | let real_entry_start = cum; [INFO] [stderr] 107 | let real_entry_end = cum + buffer_entry.length; [INFO] [stderr] 108 | // Split relevant entry into two [INFO] [stderr] 109 | let first_piece_length = position - real_entry_start; [INFO] [stderr] 110 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "93ab8eabbbadf8aaceb2292627ca535e11a9a5eb0ec4227f8ed8a8c49db83cf7"` [INFO] running `"docker" "rm" "-f" "93ab8eabbbadf8aaceb2292627ca535e11a9a5eb0ec4227f8ed8a8c49db83cf7"` [INFO] [stdout] 93ab8eabbbadf8aaceb2292627ca535e11a9a5eb0ec4227f8ed8a8c49db83cf7