[INFO] crate pgs-files 0.0.7 is already in cache [INFO] extracting crate pgs-files 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/pgs-files/0.0.7 [INFO] extracting crate pgs-files 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgs-files/0.0.7 [INFO] validating manifest of pgs-files-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pgs-files-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pgs-files-0.0.7 [INFO] finished frobbing pgs-files-0.0.7 [INFO] frobbed toml for pgs-files-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/pgs-files/0.0.7/Cargo.toml [INFO] started frobbing pgs-files-0.0.7 [INFO] finished frobbing pgs-files-0.0.7 [INFO] frobbed toml for pgs-files-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgs-files/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pgs-files-0.0.7 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pgs-files/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd8cc6de30668975460b3d4971ec1301410e7ac5bc803b3ceffde22cde96d9c5 [INFO] running `"docker" "start" "-a" "fd8cc6de30668975460b3d4971ec1301410e7ac5bc803b3ceffde22cde96d9c5"` [INFO] [stderr] Checking pgs-files v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | members: members, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | members: members, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `members` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/entries.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/entries.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match T::from_line(&line) { [INFO] [stderr] 62 | | Ok(entry) => return Some(entry), [INFO] [stderr] 63 | | // Parse Error. Just ignore this entry. [INFO] [stderr] 64 | | _ => (), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(entry) = T::from_line(&line) { return Some(entry) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/passwd.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/entries.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | if line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/entries.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match T::from_line(&line) { [INFO] [stderr] 62 | | Ok(entry) => return Some(entry), [INFO] [stderr] 63 | | // Parse Error. Just ignore this entry. [INFO] [stderr] 64 | | _ => (), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(entry) = T::from_line(&line) { return Some(entry) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/passwd.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/group.rs:31:43 [INFO] [stderr] | [INFO] [stderr] 31 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/group.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/group.rs:31:43 [INFO] [stderr] | [INFO] [stderr] 31 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/group.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/shadow.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/shadow.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | let parts: Vec<&str> = line.split(":").map(|part| part.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "fd8cc6de30668975460b3d4971ec1301410e7ac5bc803b3ceffde22cde96d9c5"` [INFO] running `"docker" "rm" "-f" "fd8cc6de30668975460b3d4971ec1301410e7ac5bc803b3ceffde22cde96d9c5"` [INFO] [stdout] fd8cc6de30668975460b3d4971ec1301410e7ac5bc803b3ceffde22cde96d9c5