[INFO] crate petrovich 0.1.1 is already in cache [INFO] extracting crate petrovich 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/petrovich/0.1.1 [INFO] extracting crate petrovich 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/petrovich/0.1.1 [INFO] validating manifest of petrovich-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of petrovich-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing petrovich-0.1.1 [INFO] finished frobbing petrovich-0.1.1 [INFO] frobbed toml for petrovich-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/petrovich/0.1.1/Cargo.toml [INFO] started frobbing petrovich-0.1.1 [INFO] finished frobbing petrovich-0.1.1 [INFO] frobbed toml for petrovich-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/petrovich/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting petrovich-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/petrovich/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c60255864834564f3b202ec086539258067870e277a6d975fbd684fc689dcae4 [INFO] running `"docker" "start" "-a" "c60255864834564f3b202ec086539258067870e277a6d975fbd684fc689dcae4"` [INFO] [stderr] Checking petrovich v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return name.chars().take(remaining).collect::() + postfix; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.chars().take(remaining).collect::() + postfix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return Gender::Androgynous; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Gender::Androgynous` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return name.chars().take(remaining).collect::() + postfix; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `name.chars().take(remaining).collect::() + postfix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return Gender::Androgynous; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Gender::Androgynous` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Petrovich` [INFO] [stderr] --> src/lib.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn new() -> Petrovich { [INFO] [stderr] 156 | | use yaml_rust::yaml::Hash as YamlHash; [INFO] [stderr] 157 | | [INFO] [stderr] 158 | | // Open Rules File (Panics on error) [INFO] [stderr] ... | [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | impl Default for Petrovich { [INFO] [stderr] 153 | fn default() -> Self { [INFO] [stderr] 154 | Self::new() [INFO] [stderr] 155 | } [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:188:49 [INFO] [stderr] | [INFO] [stderr] 188 | inflection.rfind("-").map_or(0, |pos| pos + 1); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:202:10 [INFO] [stderr] | [INFO] [stderr] 202 | .or(find_suffix(&self.firstname["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.firstname["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:214:10 [INFO] [stderr] | [INFO] [stderr] 214 | .or(find_suffix(&self.middlename["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.middlename["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:226:10 [INFO] [stderr] | [INFO] [stderr] 226 | .or(find_suffix(&self.lastname["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.lastname["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `subject` [INFO] [stderr] --> src/lib.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | let subject = Petrovich::new(); [INFO] [stderr] | ^^^^^^^ help: consider using `_subject` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `subject` [INFO] [stderr] --> src/lib.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | let subject = Petrovich::new(); [INFO] [stderr] | ^^^^^^^ help: consider using `_subject` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Petrovich` [INFO] [stderr] --> src/lib.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn new() -> Petrovich { [INFO] [stderr] 156 | | use yaml_rust::yaml::Hash as YamlHash; [INFO] [stderr] 157 | | [INFO] [stderr] 158 | | // Open Rules File (Panics on error) [INFO] [stderr] ... | [INFO] [stderr] 175 | | } [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | impl Default for Petrovich { [INFO] [stderr] 153 | fn default() -> Self { [INFO] [stderr] 154 | Self::new() [INFO] [stderr] 155 | } [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:188:49 [INFO] [stderr] | [INFO] [stderr] 188 | inflection.rfind("-").map_or(0, |pos| pos + 1); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:202:10 [INFO] [stderr] | [INFO] [stderr] 202 | .or(find_suffix(&self.firstname["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.firstname["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:214:10 [INFO] [stderr] | [INFO] [stderr] 214 | .or(find_suffix(&self.middlename["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.middlename["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:226:10 [INFO] [stderr] | [INFO] [stderr] 226 | .or(find_suffix(&self.lastname["suffixes"], name, gender)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| find_suffix(&self.lastname["suffixes"], name, gender))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "c60255864834564f3b202ec086539258067870e277a6d975fbd684fc689dcae4"` [INFO] running `"docker" "rm" "-f" "c60255864834564f3b202ec086539258067870e277a6d975fbd684fc689dcae4"` [INFO] [stdout] c60255864834564f3b202ec086539258067870e277a6d975fbd684fc689dcae4