[INFO] crate pest_meta 2.0.3 is already in cache
[INFO] extracting crate pest_meta 2.0.3 into work/ex/clippy-test-run/sources/stable/reg/pest_meta/2.0.3
[INFO] extracting crate pest_meta 2.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest_meta/2.0.3
[INFO] validating manifest of pest_meta-2.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pest_meta-2.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pest_meta-2.0.3
[INFO] finished frobbing pest_meta-2.0.3
[INFO] frobbed toml for pest_meta-2.0.3 written to work/ex/clippy-test-run/sources/stable/reg/pest_meta/2.0.3/Cargo.toml
[INFO] started frobbing pest_meta-2.0.3
[INFO] finished frobbing pest_meta-2.0.3
[INFO] frobbed toml for pest_meta-2.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest_meta/2.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pest_meta-2.0.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest_meta/2.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 786cc3f35ba127520e8e75863e5f30c499fa4b0160034807ac05b949b5157907
[INFO] running `"docker" "start" "-a" "786cc3f35ba127520e8e75863e5f30c499fa4b0160034807ac05b949b5157907"`
[INFO] [stderr]     Checking pest_meta v2.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/parser.rs:23:1
[INFO] [stderr]    |
[INFO] [stderr] 23 | / pub fn parse<'i>(rule: Rule, data: &'i str) -> Result<Pairs<Rule>, Error<Rule>> {
[INFO] [stderr] 24 | |     PestParser::parse(rule, data)
[INFO] [stderr] 25 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:126:1
[INFO] [stderr]     |
[INFO] [stderr] 126 | / fn convert_rule<'i>(rule: ParserRule<'i>) -> AstRule {
[INFO] [stderr] 127 | |     match rule {
[INFO] [stderr] 128 | |         ParserRule { name, ty, node, .. } => {
[INFO] [stderr] 129 | |             let expr = convert_node(node);
[INFO] [stderr] ...   |
[INFO] [stderr] 133 | |     }
[INFO] [stderr] 134 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:136:1
[INFO] [stderr]     |
[INFO] [stderr] 136 | / fn convert_node<'i>(node: ParserNode<'i>) -> Expr {
[INFO] [stderr] 137 | |     match node.expr {
[INFO] [stderr] 138 | |         ParserExpr::Str(string) => Expr::Str(string),
[INFO] [stderr] 139 | |         ParserExpr::Insens(string) => Expr::Insens(string),
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |     }
[INFO] [stderr] 163 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:165:1
[INFO] [stderr]     |
[INFO] [stderr] 165 | / pub fn consume_rules<'i>(pairs: Pairs<'i, Rule>) -> Result<Vec<AstRule>, Vec<Error<Rule>>> {
[INFO] [stderr] 166 | |     let rules = consume_rules_with_spans(pairs)?;
[INFO] [stderr] 167 | |     let errors = validator::validate_ast(&rules);
[INFO] [stderr] 168 | |     if errors.len() == 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 172 | |     }
[INFO] [stderr] 173 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:168:8
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if errors.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/parser.rs:169:34
[INFO] [stderr]     |
[INFO] [stderr] 169 |         Ok(rules.into_iter().map(|rule| convert_rule(rule)).collect())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `convert_rule`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:575:30
[INFO] [stderr]     |
[INFO] [stderr] 575 |                     for _ in 0..string.len() + 1 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: use: `0..=string.len()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/optimizer/restorer.rs:71:19
[INFO] [stderr]    |
[INFO] [stderr] 71 |             match cache.get(name).map(|result| *result) {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cache.get(name).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 | /                     match expr.clone() {
[INFO] [stderr] 39 | |                         Expr::Rep(expr) => match *expr.clone() {
[INFO] [stderr] 40 | |                             Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |                         _ => ()
[INFO] [stderr] 53 | |                     };
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     if let Expr::Rep(expr) = expr.clone() { match *expr.clone() {
[INFO] [stderr] 39 |     Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 40 |         (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 41 |             if ident == "ANY" {
[INFO] [stderr] 42 |                 if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |                     return expr;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:39:44
[INFO] [stderr]    |
[INFO] [stderr] 39 |                           Expr::Rep(expr) => match *expr.clone() {
[INFO] [stderr]    |  ____________________________________________^
[INFO] [stderr] 40 | |                             Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 42 | |                                     if ident == "ANY" {
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |                             _ => ()
[INFO] [stderr] 51 | |                         },
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 |                         Expr::Rep(expr) => if let Expr::Seq(lhs, rhs) = *expr.clone() { match (*lhs, *rhs) {
[INFO] [stderr] 40 |     (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 41 |         if ident == "ANY" {
[INFO] [stderr] 42 |             if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |                 return expr;
[INFO] [stderr] 44 |             }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:40:52
[INFO] [stderr]    |
[INFO] [stderr] 40 |                               Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 42 | |                                     if ident == "ANY" {
[INFO] [stderr] 43 | |                                         if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |                                 _ => ()
[INFO] [stderr] 49 | |                             },
[INFO] [stderr]    | |_____________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 |                             Expr::Seq(lhs, rhs) => if let (Expr::NegPred(expr), Expr::Ident(ident)) = (*lhs, *rhs) {
[INFO] [stderr] 41 |     if ident == "ANY" {
[INFO] [stderr] 42 |         if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |             return expr;
[INFO] [stderr] 44 |         }
[INFO] [stderr] 45 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:19:46
[INFO] [stderr]    |
[INFO] [stderr] 19 |                 Expr::RepExact(expr, num) => (1..num + 1)
[INFO] [stderr]    |                                              ^^^^^^^^^^^^ help: use: `(1..=num)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:41:44
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 Expr::RepMax(expr, max) => (1..max + 1)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^ help: use: `(1..=max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:49:52
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 Expr::RepMinMax(expr, min, max) => (1..max + 1)
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^ help: use: `(1..=max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/optimizer/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn to_hash_map(rules: & Vec<OptimizedRule>) -> HashMap<String, OptimizedExpr> {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OptimizedRule]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/validator.rs:132:8
[INFO] [stderr]     |
[INFO] [stderr] 132 |     if errors.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/validator.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     Ok(defaults.into_iter().map(|string| *string).collect())
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `defaults.into_iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/validator.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     Ok(defaults.into_iter().map(|string| *string).collect())
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `defaults`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:145:18
[INFO] [stderr]     |
[INFO] [stderr] 145 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 |     rust_keywords: &HashSet<&str>
[INFO] [stderr]     |                     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 144 | pub fn validate_rust_keywords<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 145 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 146 |     rust_keywords: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:167:18
[INFO] [stderr]     |
[INFO] [stderr] 167 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:168:21
[INFO] [stderr]     |
[INFO] [stderr] 168 |     pest_keywords: &HashSet<&str>
[INFO] [stderr]     |                     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 166 | pub fn validate_pest_keywords<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 167 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 168 |     pest_keywords: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:188:50
[INFO] [stderr]     |
[INFO] [stderr] 188 | pub fn validate_already_defined<'i>(definitions: &Vec<Span<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:211:18
[INFO] [stderr]     |
[INFO] [stderr] 211 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:212:19
[INFO] [stderr]     |
[INFO] [stderr] 212 |     called_rules: &Vec<Span<'i>>,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:213:16
[INFO] [stderr]     |
[INFO] [stderr] 213 |     builtins: &HashSet<&str>
[INFO] [stderr]     |                ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 210 | pub fn validate_undefined<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 211 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 212 |     called_rules: &Vec<Span<'i>>,
[INFO] [stderr] 213 |     builtins: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:234:40
[INFO] [stderr]     |
[INFO] [stderr] 234 | pub fn validate_ast<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/validator.rs:243:38
[INFO] [stderr]     |
[INFO] [stderr] 243 |         InputLocation::Span(span) => span.clone(),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^ help: try dereferencing it: `*span`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:320:43
[INFO] [stderr]     |
[INFO] [stderr] 320 | fn validate_repetition<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:324:23
[INFO] [stderr]     |
[INFO] [stderr] 324 |     for rule in rules.into_iter() {
[INFO] [stderr]     |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:364:40
[INFO] [stderr]     |
[INFO] [stderr] 364 | fn validate_choices<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:368:23
[INFO] [stderr]     |
[INFO] [stderr] 368 |     for rule in rules.into_iter() {
[INFO] [stderr]     |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:401:51
[INFO] [stderr]     |
[INFO] [stderr] 401 | fn validate_whitespace_comment<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:405:10
[INFO] [stderr]     |
[INFO] [stderr] 405 |         .into_iter()
[INFO] [stderr]     |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:438:47
[INFO] [stderr]     |
[INFO] [stderr] 438 | fn validate_left_recursion<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:442:35
[INFO] [stderr]     |
[INFO] [stderr] 442 | fn to_hash_map<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> HashMap<String, &'a ParserNode<'i>> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/validator.rs:495:48
[INFO] [stderr]     |
[INFO] [stderr] 495 |                 check_expr(&lhs, rules, trace).or(check_expr(&rhs, rules, trace))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| check_expr(&rhs, rules, trace))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/parser.rs:23:1
[INFO] [stderr]    |
[INFO] [stderr] 23 | / pub fn parse<'i>(rule: Rule, data: &'i str) -> Result<Pairs<Rule>, Error<Rule>> {
[INFO] [stderr] 24 | |     PestParser::parse(rule, data)
[INFO] [stderr] 25 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:126:1
[INFO] [stderr]     |
[INFO] [stderr] 126 | / fn convert_rule<'i>(rule: ParserRule<'i>) -> AstRule {
[INFO] [stderr] 127 | |     match rule {
[INFO] [stderr] 128 | |         ParserRule { name, ty, node, .. } => {
[INFO] [stderr] 129 | |             let expr = convert_node(node);
[INFO] [stderr] ...   |
[INFO] [stderr] 133 | |     }
[INFO] [stderr] 134 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:136:1
[INFO] [stderr]     |
[INFO] [stderr] 136 | / fn convert_node<'i>(node: ParserNode<'i>) -> Expr {
[INFO] [stderr] 137 | |     match node.expr {
[INFO] [stderr] 138 | |         ParserExpr::Str(string) => Expr::Str(string),
[INFO] [stderr] 139 | |         ParserExpr::Insens(string) => Expr::Insens(string),
[INFO] [stderr] ...   |
[INFO] [stderr] 162 | |     }
[INFO] [stderr] 163 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:165:1
[INFO] [stderr]     |
[INFO] [stderr] 165 | / pub fn consume_rules<'i>(pairs: Pairs<'i, Rule>) -> Result<Vec<AstRule>, Vec<Error<Rule>>> {
[INFO] [stderr] 166 | |     let rules = consume_rules_with_spans(pairs)?;
[INFO] [stderr] 167 | |     let errors = validator::validate_ast(&rules);
[INFO] [stderr] 168 | |     if errors.len() == 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 172 | |     }
[INFO] [stderr] 173 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:168:8
[INFO] [stderr]     |
[INFO] [stderr] 168 |     if errors.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/parser.rs:169:34
[INFO] [stderr]     |
[INFO] [stderr] 169 |         Ok(rules.into_iter().map(|rule| convert_rule(rule)).collect())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `convert_rule`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:575:30
[INFO] [stderr]     |
[INFO] [stderr] 575 |                     for _ in 0..string.len() + 1 {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^ help: use: `0..=string.len()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 69
[INFO] [stderr]    --> src/parser.rs:597:5
[INFO] [stderr]     |
[INFO] [stderr] 597 | /     fn rules() {
[INFO] [stderr] 598 | |         parses_to! {
[INFO] [stderr] 599 | |             parser: PestParser,
[INFO] [stderr] 600 | |             input: "a = { b } c = { d }",
[INFO] [stderr] ...   |
[INFO] [stderr] 626 | |         };
[INFO] [stderr] 627 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 53
[INFO] [stderr]    --> src/parser.rs:630:5
[INFO] [stderr]     |
[INFO] [stderr] 630 | /     fn rule() {
[INFO] [stderr] 631 | |         parses_to! {
[INFO] [stderr] 632 | |             parser: PestParser,
[INFO] [stderr] 633 | |             input: "a = ! { b ~ c }",
[INFO] [stderr] ...   |
[INFO] [stderr] 653 | |         };
[INFO] [stderr] 654 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 145
[INFO] [stderr]    --> src/parser.rs:657:5
[INFO] [stderr]     |
[INFO] [stderr] 657 | /     fn expression() {
[INFO] [stderr] 658 | |         parses_to! {
[INFO] [stderr] 659 | |             parser: PestParser,
[INFO] [stderr] 660 | |             input: "_a | 'a'..'b' ~ !^\"abc\" ~ (d | e)*?",
[INFO] [stderr] ...   |
[INFO] [stderr] 712 | |         };
[INFO] [stderr] 713 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/parser.rs:766:5
[INFO] [stderr]     |
[INFO] [stderr] 766 | /     fn repeat_min_max() {
[INFO] [stderr] 767 | |         parses_to! {
[INFO] [stderr] 768 | |             parser: PestParser,
[INFO] [stderr] 769 | |             input: "{1, 2}",
[INFO] [stderr] ...   |
[INFO] [stderr] 780 | |         };
[INFO] [stderr] 781 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/parser.rs:784:5
[INFO] [stderr]     |
[INFO] [stderr] 784 | /     fn push() {
[INFO] [stderr] 785 | |         parses_to! {
[INFO] [stderr] 786 | |             parser: PestParser,
[INFO] [stderr] 787 | |             input: "PUSH ( a )",
[INFO] [stderr] ...   |
[INFO] [stderr] 800 | |         };
[INFO] [stderr] 801 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 45
[INFO] [stderr]    --> src/parser.rs:850:5
[INFO] [stderr]     |
[INFO] [stderr] 850 | /     fn range() {
[INFO] [stderr] 851 | |         parses_to! {
[INFO] [stderr] 852 | |             parser: PestParser,
[INFO] [stderr] 853 | |             input: "'\\n' .. '\\x1a'",
[INFO] [stderr] ...   |
[INFO] [stderr] 870 | |         };
[INFO] [stderr] 871 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/parser.rs:902:5
[INFO] [stderr]     |
[INFO] [stderr] 902 | /     fn comment() {
[INFO] [stderr] 903 | |         parses_to! {
[INFO] [stderr] 904 | |             parser: PestParser,
[INFO] [stderr] 905 | |             input: "a ~    // asda\n b",
[INFO] [stderr] ...   |
[INFO] [stderr] 918 | |         };
[INFO] [stderr] 919 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]     --> src/parser.rs:1144:47
[INFO] [stderr]      |
[INFO] [stderr] 1144 |         let ast: Vec<_> = ast.into_iter().map(|rule| convert_rule(rule)).collect();
[INFO] [stderr]      |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `convert_rule`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/optimizer/restorer.rs:71:19
[INFO] [stderr]    |
[INFO] [stderr] 71 |             match cache.get(name).map(|result| *result) {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cache.get(name).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 | /                     match expr.clone() {
[INFO] [stderr] 39 | |                         Expr::Rep(expr) => match *expr.clone() {
[INFO] [stderr] 40 | |                             Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |                         _ => ()
[INFO] [stderr] 53 | |                     };
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     if let Expr::Rep(expr) = expr.clone() { match *expr.clone() {
[INFO] [stderr] 39 |     Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 40 |         (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 41 |             if ident == "ANY" {
[INFO] [stderr] 42 |                 if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |                     return expr;
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:39:44
[INFO] [stderr]    |
[INFO] [stderr] 39 |                           Expr::Rep(expr) => match *expr.clone() {
[INFO] [stderr]    |  ____________________________________________^
[INFO] [stderr] 40 | |                             Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 42 | |                                     if ident == "ANY" {
[INFO] [stderr] ...  |
[INFO] [stderr] 50 | |                             _ => ()
[INFO] [stderr] 51 | |                         },
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 39 |                         Expr::Rep(expr) => if let Expr::Seq(lhs, rhs) = *expr.clone() { match (*lhs, *rhs) {
[INFO] [stderr] 40 |     (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 41 |         if ident == "ANY" {
[INFO] [stderr] 42 |             if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |                 return expr;
[INFO] [stderr] 44 |             }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/optimizer/skipper.rs:40:52
[INFO] [stderr]    |
[INFO] [stderr] 40 |                               Expr::Seq(lhs, rhs) => match (*lhs, *rhs) {
[INFO] [stderr]    |  ____________________________________________________^
[INFO] [stderr] 41 | |                                 (Expr::NegPred(expr), Expr::Ident(ident)) => {
[INFO] [stderr] 42 | |                                     if ident == "ANY" {
[INFO] [stderr] 43 | |                                         if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] ...  |
[INFO] [stderr] 48 | |                                 _ => ()
[INFO] [stderr] 49 | |                             },
[INFO] [stderr]    | |_____________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 40 |                             Expr::Seq(lhs, rhs) => if let (Expr::NegPred(expr), Expr::Ident(ident)) = (*lhs, *rhs) {
[INFO] [stderr] 41 |     if ident == "ANY" {
[INFO] [stderr] 42 |         if let Some(expr) = populate_choices(*expr, vec![]) {
[INFO] [stderr] 43 |             return expr;
[INFO] [stderr] 44 |         }
[INFO] [stderr] 45 |     }
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:19:46
[INFO] [stderr]    |
[INFO] [stderr] 19 |                 Expr::RepExact(expr, num) => (1..num + 1)
[INFO] [stderr]    |                                              ^^^^^^^^^^^^ help: use: `(1..=num)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:41:44
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 Expr::RepMax(expr, max) => (1..max + 1)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^ help: use: `(1..=max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/optimizer/unroller.rs:49:52
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 Expr::RepMinMax(expr, min, max) => (1..max + 1)
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^ help: use: `(1..=max)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/optimizer/mod.rs:68:23
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn to_hash_map(rules: & Vec<OptimizedRule>) -> HashMap<String, OptimizedExpr> {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[OptimizedRule]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/validator.rs:132:8
[INFO] [stderr]     |
[INFO] [stderr] 132 |     if errors.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/validator.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     Ok(defaults.into_iter().map(|string| *string).collect())
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `defaults.into_iter().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/validator.rs:141:8
[INFO] [stderr]     |
[INFO] [stderr] 141 |     Ok(defaults.into_iter().map(|string| *string).collect())
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `defaults`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:145:18
[INFO] [stderr]     |
[INFO] [stderr] 145 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:146:21
[INFO] [stderr]     |
[INFO] [stderr] 146 |     rust_keywords: &HashSet<&str>
[INFO] [stderr]     |                     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 144 | pub fn validate_rust_keywords<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 145 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 146 |     rust_keywords: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:167:18
[INFO] [stderr]     |
[INFO] [stderr] 167 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:168:21
[INFO] [stderr]     |
[INFO] [stderr] 168 |     pest_keywords: &HashSet<&str>
[INFO] [stderr]     |                     ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 166 | pub fn validate_pest_keywords<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 167 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 168 |     pest_keywords: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:188:50
[INFO] [stderr]     |
[INFO] [stderr] 188 | pub fn validate_already_defined<'i>(definitions: &Vec<Span<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:211:18
[INFO] [stderr]     |
[INFO] [stderr] 211 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:212:19
[INFO] [stderr]     |
[INFO] [stderr] 212 |     called_rules: &Vec<Span<'i>>,
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^ help: change this to: `&[Span<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/validator.rs:213:16
[INFO] [stderr]     |
[INFO] [stderr] 213 |     builtins: &HashSet<&str>
[INFO] [stderr]     |                ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 210 | pub fn validate_undefined<'i, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 211 |     definitions: &Vec<Span<'i>>,
[INFO] [stderr] 212 |     called_rules: &Vec<Span<'i>>,
[INFO] [stderr] 213 |     builtins: &HashSet<&str, S>
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:234:40
[INFO] [stderr]     |
[INFO] [stderr] 234 | pub fn validate_ast<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/validator.rs:243:38
[INFO] [stderr]     |
[INFO] [stderr] 243 |         InputLocation::Span(span) => span.clone(),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^ help: try dereferencing it: `*span`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:320:43
[INFO] [stderr]     |
[INFO] [stderr] 320 | fn validate_repetition<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:324:23
[INFO] [stderr]     |
[INFO] [stderr] 324 |     for rule in rules.into_iter() {
[INFO] [stderr]     |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:364:40
[INFO] [stderr]     |
[INFO] [stderr] 364 | fn validate_choices<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:368:23
[INFO] [stderr]     |
[INFO] [stderr] 368 |     for rule in rules.into_iter() {
[INFO] [stderr]     |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:401:51
[INFO] [stderr]     |
[INFO] [stderr] 401 | fn validate_whitespace_comment<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/validator.rs:405:10
[INFO] [stderr]     |
[INFO] [stderr] 405 |         .into_iter()
[INFO] [stderr]     |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:438:47
[INFO] [stderr]     |
[INFO] [stderr] 438 | fn validate_left_recursion<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> Vec<Error<Rule>> {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/validator.rs:442:35
[INFO] [stderr]     |
[INFO] [stderr] 442 | fn to_hash_map<'a, 'i: 'a>(rules: &'a Vec<ParserRule<'i>>) -> HashMap<String, &'a ParserNode<'i>> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ParserRule<'i>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/validator.rs:495:48
[INFO] [stderr]     |
[INFO] [stderr] 495 |                 check_expr(&lhs, rules, trace).or(check_expr(&rhs, rules, trace))
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| check_expr(&rhs, rules, trace))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.63s
[INFO] running `"docker" "inspect" "786cc3f35ba127520e8e75863e5f30c499fa4b0160034807ac05b949b5157907"`
[INFO] running `"docker" "rm" "-f" "786cc3f35ba127520e8e75863e5f30c499fa4b0160034807ac05b949b5157907"`
[INFO] [stdout] 786cc3f35ba127520e8e75863e5f30c499fa4b0160034807ac05b949b5157907