[INFO] crate pest 2.0.2 is already in cache [INFO] extracting crate pest 2.0.2 into work/ex/clippy-test-run/sources/stable/reg/pest/2.0.2 [INFO] extracting crate pest 2.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest/2.0.2 [INFO] validating manifest of pest-2.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pest-2.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pest-2.0.2 [INFO] finished frobbing pest-2.0.2 [INFO] frobbed toml for pest-2.0.2 written to work/ex/clippy-test-run/sources/stable/reg/pest/2.0.2/Cargo.toml [INFO] started frobbing pest-2.0.2 [INFO] finished frobbing pest-2.0.2 [INFO] frobbed toml for pest-2.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest/2.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pest-2.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pest/2.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8128c7827744af14f3303aef4a5c654db879bda3b7ec047cd8296f23025d9ce [INFO] running `"docker" "start" "-a" "e8128c7827744af14f3303aef4a5c654db879bda3b7ec047cd8296f23025d9ce"` [INFO] [stderr] Checking pest v2.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:137:48 [INFO] [stderr] | [INFO] [stderr] 137 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/unicode/mod.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:137:48 [INFO] [stderr] | [INFO] [stderr] 137 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/unicode/mod.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(clippy))] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/error.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/stack.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / fn stack_ops() { [INFO] [stderr] 140 | | let mut stack = Stack::new(); [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | // [] [INFO] [stderr] ... | [INFO] [stderr] 207 | | assert_eq!(stack.pop(), None); [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/parens.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | state.sequence(|s| s.repeat(|s| paren(s)).and_then(|s| s.end_of_input())) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `paren` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> examples/parens.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | .and_then(|s| s.repeat(|s| paren(s))) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `paren` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:48:47 [INFO] [stderr] | [INFO] [stderr] 48 | .and_then(|s| primary(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `primary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:47:46 [INFO] [stderr] | [INFO] [stderr] 47 | .or_else(|s| power(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:46:46 [INFO] [stderr] | [INFO] [stderr] 46 | .or_else(|s| modulus(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `modulus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:45:46 [INFO] [stderr] | [INFO] [stderr] 45 | .or_else(|s| divide(s)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `divide` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:44:46 [INFO] [stderr] | [INFO] [stderr] 44 | .or_else(|s| times(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `times` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:43:46 [INFO] [stderr] | [INFO] [stderr] 43 | .or_else(|s| minus(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `minus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | .or_else(|s| number(s)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/calculator.rs:60:35 [INFO] [stderr] | [INFO] [stderr] 60 | .and_then(|s| expression(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `expression` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> tests/calculator.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / fn expression() { [INFO] [stderr] 165 | | parses_to! { [INFO] [stderr] 166 | | parser: CalculatorParser, [INFO] [stderr] 167 | | input: "-12+3*(4-9)^7^2", [INFO] [stderr] ... | [INFO] [stderr] 186 | | }; [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:52:35 [INFO] [stderr] | [INFO] [stderr] 52 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | .and_then(|s| pair(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:59:51 [INFO] [stderr] | [INFO] [stderr] 59 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | .and_then(|s| pair(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:57:51 [INFO] [stderr] | [INFO] [stderr] 57 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | .and_then(|s| value(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:80:35 [INFO] [stderr] | [INFO] [stderr] 80 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:91:35 [INFO] [stderr] | [INFO] [stderr] 91 | .and_then(|s| value(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:90:35 [INFO] [stderr] | [INFO] [stderr] 90 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:98:51 [INFO] [stderr] | [INFO] [stderr] 98 | .and_then(|s| value(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:97:51 [INFO] [stderr] | [INFO] [stderr] 97 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:107:39 [INFO] [stderr] | [INFO] [stderr] 107 | .and_then(|s| skip(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `skip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:121:30 [INFO] [stderr] | [INFO] [stderr] 121 | .or_else(|s| null(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `null` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | .or_else(|s| bool(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | .or_else(|s| array(s)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `array` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:118:30 [INFO] [stderr] | [INFO] [stderr] 118 | .or_else(|s| object(s)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:117:30 [INFO] [stderr] | [INFO] [stderr] 117 | .or_else(|s| number(s)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:154:34 [INFO] [stderr] | [INFO] [stderr] 154 | .or_else(|s| unicode(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `unicode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:164:31 [INFO] [stderr] | [INFO] [stderr] 164 | .and_then(|s| hex(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `hex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:163:31 [INFO] [stderr] | [INFO] [stderr] 163 | .and_then(|s| hex(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `hex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:162:31 [INFO] [stderr] | [INFO] [stderr] 162 | .and_then(|s| hex(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `hex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:179:35 [INFO] [stderr] | [INFO] [stderr] 179 | .and_then(|s| int(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:187:50 [INFO] [stderr] | [INFO] [stderr] 187 | .or_else(|s| exp(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:186:66 [INFO] [stderr] | [INFO] [stderr] 186 | .and_then(|s| s.optional(|s| exp(s))) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `exp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/json.rs:211:31 [INFO] [stderr] | [INFO] [stderr] 211 | .and_then(|s| int(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> tests/json.rs:393:1 [INFO] [stderr] | [INFO] [stderr] 393 | / fn array() { [INFO] [stderr] 394 | | parses_to! { [INFO] [stderr] 395 | | parser: JsonParser, [INFO] [stderr] 396 | | input: "[0.0e1, false, null, \"a\", [0]]", [INFO] [stderr] ... | [INFO] [stderr] 411 | | }; [INFO] [stderr] 412 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> tests/json.rs:415:1 [INFO] [stderr] | [INFO] [stderr] 415 | / fn object() { [INFO] [stderr] 416 | | parses_to! { [INFO] [stderr] 417 | | parser: JsonParser, [INFO] [stderr] 418 | | input: "{\"a\" : 3, \"b\" : [{}, 3]}", [INFO] [stderr] ... | [INFO] [stderr] 437 | | }; [INFO] [stderr] 438 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/json.rs:451:5 [INFO] [stderr] | [INFO] [stderr] 451 | / match ast { [INFO] [stderr] 452 | | Json::Object(pairs) => { [INFO] [stderr] 453 | | let vals: Vec<&Json> = pairs.values().collect(); [INFO] [stderr] 454 | | [INFO] [stderr] ... | [INFO] [stderr] 460 | | _ => {} [INFO] [stderr] 461 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 451 | if let Json::Object(pairs) = ast { [INFO] [stderr] 452 | let vals: Vec<&Json> = pairs.values().collect(); [INFO] [stderr] 453 | [INFO] [stderr] 454 | assert_eq!( [INFO] [stderr] 455 | **vals.get(0).unwrap(), [INFO] [stderr] 456 | Json::Array(vec![Json::Null, Json::Bool(true), Json::Number(3.4)]) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/json.rs:456:19 [INFO] [stderr] | [INFO] [stderr] 456 | **vals.get(0).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.94s [INFO] running `"docker" "inspect" "e8128c7827744af14f3303aef4a5c654db879bda3b7ec047cd8296f23025d9ce"` [INFO] running `"docker" "rm" "-f" "e8128c7827744af14f3303aef4a5c654db879bda3b7ec047cd8296f23025d9ce"` [INFO] [stdout] e8128c7827744af14f3303aef4a5c654db879bda3b7ec047cd8296f23025d9ce