[INFO] crate permutation 0.2.5 is already in cache
[INFO] extracting crate permutation 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/permutation/0.2.5
[INFO] extracting crate permutation 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/permutation/0.2.5
[INFO] validating manifest of permutation-0.2.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of permutation-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing permutation-0.2.5
[INFO] finished frobbing permutation-0.2.5
[INFO] frobbed toml for permutation-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/permutation/0.2.5/Cargo.toml
[INFO] started frobbing permutation-0.2.5
[INFO] finished frobbing permutation-0.2.5
[INFO] frobbed toml for permutation-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/permutation/0.2.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting permutation-0.2.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/permutation/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 196a844851399c8375dd4cdd3310e55082660ef61b487b82ec614354a525c3c5
[INFO] running `"docker" "start" "-a" "196a844851399c8375dd4cdd3310e55082660ef61b487b82ec614354a525c3c5"`
[INFO] [stderr]     Checking permutation v0.2.5 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/permutation.rs:64:30
[INFO] [stderr]    |
[INFO] [stderr] 64 |             (false, true) => return self * &(rhs * &Permutation::one(self.len())),
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self * &(rhs * &Permutation::one(self.len()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/permutation.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         return self.indices.len();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.indices.len()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         return sorted.iter().enumerate().all(|(i, &j)| i == j);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted.iter().enumerate().all(|(i, &j)| i == j)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 |         return other;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `other`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:340:5
[INFO] [stderr]     |
[INFO] [stderr] 340 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:366:5
[INFO] [stderr]     |
[INFO] [stderr] 366 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:392:5
[INFO] [stderr]     |
[INFO] [stderr] 392 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/permutation.rs:64:30
[INFO] [stderr]    |
[INFO] [stderr] 64 |             (false, true) => return self * &(rhs * &Permutation::one(self.len())),
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self * &(rhs * &Permutation::one(self.len()))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/permutation.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |         return result;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         return self.indices.len();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.indices.len()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         return sorted.iter().enumerate().all(|(i, &j)| i == j);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted.iter().enumerate().all(|(i, &j)| i == j)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         return self;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:258:9
[INFO] [stderr]     |
[INFO] [stderr] 258 |         return other;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `other`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:340:5
[INFO] [stderr]     |
[INFO] [stderr] 340 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:366:5
[INFO] [stderr]     |
[INFO] [stderr] 366 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/permutation.rs:392:5
[INFO] [stderr]     |
[INFO] [stderr] 392 |     return permutation;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `permutation`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: item `permutation::Permutation` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/permutation.rs:75:1
[INFO] [stderr]     |
[INFO] [stderr] 75  | / impl Permutation {
[INFO] [stderr] 76  | |     /// Create a permutation from a vector of indices.
[INFO] [stderr] 77  | |     ///
[INFO] [stderr] 78  | |     /// from_vec(v) returns the permutation P such that P applied to [1,2,...,N] is v.
[INFO] [stderr] ...   |
[INFO] [stderr] 304 | |     }
[INFO] [stderr] 305 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:216:9
[INFO] [stderr]     |
[INFO] [stderr] 216 | /         match self.inv {
[INFO] [stderr] 217 | |             false => self.apply_idx_fwd(idx),
[INFO] [stderr] 218 | |             true => self.apply_idx_bkwd(idx),
[INFO] [stderr] 219 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_idx_bkwd(idx) } else { self.apply_idx_fwd(idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match self.inv {
[INFO] [stderr] 238 | |             true => self.apply_idx_fwd(idx),
[INFO] [stderr] 239 | |             false => self.apply_idx_bkwd(idx),
[INFO] [stderr] 240 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_idx_fwd(idx) } else { self.apply_idx_bkwd(idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:277:9
[INFO] [stderr]     |
[INFO] [stderr] 277 | /         match self.inv {
[INFO] [stderr] 278 | |             false => self.apply_slice_fwd(vec),
[INFO] [stderr] 279 | |             true => self.apply_slice_bkwd(vec),
[INFO] [stderr] 280 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_slice_bkwd(vec) } else { self.apply_slice_fwd(vec) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:300:9
[INFO] [stderr]     |
[INFO] [stderr] 300 | /         match self.inv {
[INFO] [stderr] 301 | |             false => self.apply_slice_bkwd(vec),
[INFO] [stderr] 302 | |             true => self.apply_slice_fwd(vec),
[INFO] [stderr] 303 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_slice_fwd(vec) } else { self.apply_slice_bkwd(vec) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: item `permutation::Permutation` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/permutation.rs:75:1
[INFO] [stderr]     |
[INFO] [stderr] 75  | / impl Permutation {
[INFO] [stderr] 76  | |     /// Create a permutation from a vector of indices.
[INFO] [stderr] 77  | |     ///
[INFO] [stderr] 78  | |     /// from_vec(v) returns the permutation P such that P applied to [1,2,...,N] is v.
[INFO] [stderr] ...   |
[INFO] [stderr] 304 | |     }
[INFO] [stderr] 305 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:216:9
[INFO] [stderr]     |
[INFO] [stderr] 216 | /         match self.inv {
[INFO] [stderr] 217 | |             false => self.apply_idx_fwd(idx),
[INFO] [stderr] 218 | |             true => self.apply_idx_bkwd(idx),
[INFO] [stderr] 219 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_idx_bkwd(idx) } else { self.apply_idx_fwd(idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:237:9
[INFO] [stderr]     |
[INFO] [stderr] 237 | /         match self.inv {
[INFO] [stderr] 238 | |             true => self.apply_idx_fwd(idx),
[INFO] [stderr] 239 | |             false => self.apply_idx_bkwd(idx),
[INFO] [stderr] 240 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_idx_fwd(idx) } else { self.apply_idx_bkwd(idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:277:9
[INFO] [stderr]     |
[INFO] [stderr] 277 | /         match self.inv {
[INFO] [stderr] 278 | |             false => self.apply_slice_fwd(vec),
[INFO] [stderr] 279 | |             true => self.apply_slice_bkwd(vec),
[INFO] [stderr] 280 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_slice_bkwd(vec) } else { self.apply_slice_fwd(vec) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/permutation.rs:300:9
[INFO] [stderr]     |
[INFO] [stderr] 300 | /         match self.inv {
[INFO] [stderr] 301 | |             false => self.apply_slice_bkwd(vec),
[INFO] [stderr] 302 | |             true => self.apply_slice_fwd(vec),
[INFO] [stderr] 303 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.inv { self.apply_slice_fwd(vec) } else { self.apply_slice_bkwd(vec) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.77s
[INFO] running `"docker" "inspect" "196a844851399c8375dd4cdd3310e55082660ef61b487b82ec614354a525c3c5"`
[INFO] running `"docker" "rm" "-f" "196a844851399c8375dd4cdd3310e55082660ef61b487b82ec614354a525c3c5"`
[INFO] [stdout] 196a844851399c8375dd4cdd3310e55082660ef61b487b82ec614354a525c3c5