[INFO] crate periodic 0.1.1 is already in cache
[INFO] extracting crate periodic 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/periodic/0.1.1
[INFO] extracting crate periodic 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/periodic/0.1.1
[INFO] validating manifest of periodic-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of periodic-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing periodic-0.1.1
[INFO] finished frobbing periodic-0.1.1
[INFO] frobbed toml for periodic-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/periodic/0.1.1/Cargo.toml
[INFO] started frobbing periodic-0.1.1
[INFO] finished frobbing periodic-0.1.1
[INFO] frobbed toml for periodic-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/periodic/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting periodic-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/periodic/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aff21b10a277ce5e434f906aadddaefc29d562f484d1b525c60f948516240198
[INFO] running `"docker" "start" "-a" "aff21b10a277ce5e434f906aadddaefc29d562f484d1b525c60f948516240198"`
[INFO] [stderr]     Checking periodic v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `planner::Planner`
[INFO] [stderr]   --> src/planner.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Planner {
[INFO] [stderr] 26 | |         Planner {
[INFO] [stderr] 27 | |             job_queue: Arc::new(Mutex::new(BinaryHeap::new())),
[INFO] [stderr] 28 | |             job_processor_tx: Arc::new(Mutex::new(None)),
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `planner::Planner`
[INFO] [stderr]   --> src/planner.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Planner {
[INFO] [stderr] 26 | |         Planner {
[INFO] [stderr] 27 | |             job_queue: Arc::new(Mutex::new(BinaryHeap::new())),
[INFO] [stderr] 28 | |             job_processor_tx: Arc::new(Mutex::new(None)),
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/planner.rs:99:46
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 Self::spawn("exec_callback", move || (*spawn_callback)());
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(*spawn_callback)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/planner.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                    job.to_next_time()
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 102 | ||                     .map(|new_job| job_queue_locked.push(new_job));
[INFO] [stderr]     | ||__________________________________________________________________^- help: try this: `if let Some(new_job) = job.to_next_time() { job_queue_locked.push(new_job) }`
[INFO] [stderr]     | |___________________________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/planner.rs:99:46
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 Self::spawn("exec_callback", move || (*spawn_callback)());
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(*spawn_callback)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/planner.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                    job.to_next_time()
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 102 | ||                     .map(|new_job| job_queue_locked.push(new_job));
[INFO] [stderr]     | ||__________________________________________________________________^- help: try this: `if let Some(new_job) = job.to_next_time() { job_queue_locked.push(new_job) }`
[INFO] [stderr]     | |___________________________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/planner.rs:144:19
[INFO] [stderr]     |
[INFO] [stderr] 144 |             .name(name.into())
[INFO] [stderr]     |                   ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/planner.rs:144:19
[INFO] [stderr]     |
[INFO] [stderr] 144 |             .name(name.into())
[INFO] [stderr]     |                   ^^^^^^^^^^^ help: consider removing `.into()`: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/planner.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |     fn to_next_time(mut self) -> Option<Job> {
[INFO] [stderr]     |                     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/planner.rs:178:21
[INFO] [stderr]     |
[INFO] [stderr] 178 |     fn to_next_time(mut self) -> Option<Job> {
[INFO] [stderr]     |                     ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.61s
[INFO] running `"docker" "inspect" "aff21b10a277ce5e434f906aadddaefc29d562f484d1b525c60f948516240198"`
[INFO] running `"docker" "rm" "-f" "aff21b10a277ce5e434f906aadddaefc29d562f484d1b525c60f948516240198"`
[INFO] [stdout] aff21b10a277ce5e434f906aadddaefc29d562f484d1b525c60f948516240198