[INFO] crate pe 0.1.1 is already in cache [INFO] extracting crate pe 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pe/0.1.1 [INFO] extracting crate pe 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pe/0.1.1 [INFO] validating manifest of pe-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pe-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pe-0.1.1 [INFO] finished frobbing pe-0.1.1 [INFO] frobbed toml for pe-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pe/0.1.1/Cargo.toml [INFO] started frobbing pe-0.1.1 [INFO] finished frobbing pe-0.1.1 [INFO] frobbed toml for pe-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pe/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pe-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pe/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20fb6880ecbdb94c3ad32b9d51ecda5d4d54bed8ab7ef3fd478851fef88e9cf7 [INFO] running `"docker" "start" "-a" "20fb6880ecbdb94c3ad32b9d51ecda5d4d54bed8ab7ef3fd478851fef88e9cf7"` [INFO] [stderr] Checking pe v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | Ok(Pe{data:data,h:pe_header,oh:pe_oh,directories:pe_dd,sections:pe_sec}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:216:22 [INFO] [stderr] | [INFO] [stderr] 216 | Ok(Exports{pe:self,ddir:ddir,edir:try!(self.ref_at(ddir.virtual_address))}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `ddir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | Ok(Pe{data:data,h:pe_header,oh:pe_oh,directories:pe_dd,sections:pe_sec}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:216:22 [INFO] [stderr] | [INFO] [stderr] 216 | Ok(Exports{pe:self,ddir:ddir,edir:try!(self.ref_at(ddir.virtual_address))}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `ddir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PE_SIGNATURE: u32 = 0x00004550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4550` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:137:54 [INFO] [stderr] | [INFO] [stderr] 137 | const RESERVED2 = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | const RESERVED3 = 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:139:54 [INFO] [stderr] | [INFO] [stderr] 139 | const RESERVED4 = 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:140:54 [INFO] [stderr] | [INFO] [stderr] 140 | const IMAGE_SCN_TYPE_NO_PAD = 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | const RESERVED5 = 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | const IMAGE_SCN_CNT_CODE = 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:143:54 [INFO] [stderr] | [INFO] [stderr] 143 | const IMAGE_SCN_CNT_INITIALIZED_DATA = 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:144:54 [INFO] [stderr] | [INFO] [stderr] 144 | const IMAGE_SCN_CNT_UNINITIALIZED_DATA = 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:145:54 [INFO] [stderr] | [INFO] [stderr] 145 | const IMAGE_SCN_LNK_OTHER = 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:146:54 [INFO] [stderr] | [INFO] [stderr] 146 | const IMAGE_SCN_LNK_INFO = 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:147:54 [INFO] [stderr] | [INFO] [stderr] 147 | const RESERVED6 = 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:148:54 [INFO] [stderr] | [INFO] [stderr] 148 | const IMAGE_SCN_LNK_REMOVE = 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:149:54 [INFO] [stderr] | [INFO] [stderr] 149 | const IMAGE_SCN_LNK_COMDAT = 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:150:54 [INFO] [stderr] | [INFO] [stderr] 150 | const RESERVED7 = 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:151:54 [INFO] [stderr] | [INFO] [stderr] 151 | const RESERVED8 = 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:152:54 [INFO] [stderr] | [INFO] [stderr] 152 | const IMAGE_SCN_GPREL = 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:153:54 [INFO] [stderr] | [INFO] [stderr] 153 | const RESERVED9 = 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:154:54 [INFO] [stderr] | [INFO] [stderr] 154 | const IMAGE_SCN_MEM_16BIT = 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | const IMAGE_SCN_MEM_LOCKED = 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:156:54 [INFO] [stderr] | [INFO] [stderr] 156 | const IMAGE_SCN_MEM_PRELOAD = 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:157:54 [INFO] [stderr] | [INFO] [stderr] 157 | const IMAGE_SCN_ALIGN_BIT0 = 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:158:54 [INFO] [stderr] | [INFO] [stderr] 158 | const IMAGE_SCN_ALIGN_BIT1 = 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:159:54 [INFO] [stderr] | [INFO] [stderr] 159 | const IMAGE_SCN_ALIGN_BIT2 = 0x00400000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:160:54 [INFO] [stderr] | [INFO] [stderr] 160 | const IMAGE_SCN_ALIGN_BIT3 = 0x00800000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:161:54 [INFO] [stderr] | [INFO] [stderr] 161 | const IMAGE_SCN_LNK_NRELOC_OVFL = 0x01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:162:54 [INFO] [stderr] | [INFO] [stderr] 162 | const IMAGE_SCN_MEM_DISCARDABLE = 0x02000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:163:54 [INFO] [stderr] | [INFO] [stderr] 163 | const IMAGE_SCN_MEM_NOT_CACHED = 0x04000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | const IMAGE_SCN_MEM_NOT_PAGED = 0x08000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:165:54 [INFO] [stderr] | [INFO] [stderr] 165 | const IMAGE_SCN_MEM_SHARED = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:166:54 [INFO] [stderr] | [INFO] [stderr] 166 | const IMAGE_SCN_MEM_EXECUTE = 0x20000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:167:54 [INFO] [stderr] | [INFO] [stderr] 167 | const IMAGE_SCN_MEM_READ = 0x40000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:168:54 [INFO] [stderr] | [INFO] [stderr] 168 | const IMAGE_SCN_MEM_WRITE = 0x80000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PE_SIGNATURE: u32 = 0x00004550; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4550` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:137:54 [INFO] [stderr] | [INFO] [stderr] 137 | const RESERVED2 = 0x00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | const RESERVED3 = 0x00000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:139:54 [INFO] [stderr] | [INFO] [stderr] 139 | const RESERVED4 = 0x00000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:140:54 [INFO] [stderr] | [INFO] [stderr] 140 | const IMAGE_SCN_TYPE_NO_PAD = 0x00000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | const RESERVED5 = 0x00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:142:54 [INFO] [stderr] | [INFO] [stderr] 142 | const IMAGE_SCN_CNT_CODE = 0x00000020, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:143:54 [INFO] [stderr] | [INFO] [stderr] 143 | const IMAGE_SCN_CNT_INITIALIZED_DATA = 0x00000040, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:144:54 [INFO] [stderr] | [INFO] [stderr] 144 | const IMAGE_SCN_CNT_UNINITIALIZED_DATA = 0x00000080, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:145:54 [INFO] [stderr] | [INFO] [stderr] 145 | const IMAGE_SCN_LNK_OTHER = 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:146:54 [INFO] [stderr] | [INFO] [stderr] 146 | const IMAGE_SCN_LNK_INFO = 0x00000200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:147:54 [INFO] [stderr] | [INFO] [stderr] 147 | const RESERVED6 = 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:148:54 [INFO] [stderr] | [INFO] [stderr] 148 | const IMAGE_SCN_LNK_REMOVE = 0x00000800, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:149:54 [INFO] [stderr] | [INFO] [stderr] 149 | const IMAGE_SCN_LNK_COMDAT = 0x00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:150:54 [INFO] [stderr] | [INFO] [stderr] 150 | const RESERVED7 = 0x00002000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:151:54 [INFO] [stderr] | [INFO] [stderr] 151 | const RESERVED8 = 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:152:54 [INFO] [stderr] | [INFO] [stderr] 152 | const IMAGE_SCN_GPREL = 0x00008000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:153:54 [INFO] [stderr] | [INFO] [stderr] 153 | const RESERVED9 = 0x00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:154:54 [INFO] [stderr] | [INFO] [stderr] 154 | const IMAGE_SCN_MEM_16BIT = 0x00020000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | const IMAGE_SCN_MEM_LOCKED = 0x00040000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:156:54 [INFO] [stderr] | [INFO] [stderr] 156 | const IMAGE_SCN_MEM_PRELOAD = 0x00080000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:157:54 [INFO] [stderr] | [INFO] [stderr] 157 | const IMAGE_SCN_ALIGN_BIT0 = 0x00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:158:54 [INFO] [stderr] | [INFO] [stderr] 158 | const IMAGE_SCN_ALIGN_BIT1 = 0x00200000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:159:54 [INFO] [stderr] | [INFO] [stderr] 159 | const IMAGE_SCN_ALIGN_BIT2 = 0x00400000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:160:54 [INFO] [stderr] | [INFO] [stderr] 160 | const IMAGE_SCN_ALIGN_BIT3 = 0x00800000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:161:54 [INFO] [stderr] | [INFO] [stderr] 161 | const IMAGE_SCN_LNK_NRELOC_OVFL = 0x01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:162:54 [INFO] [stderr] | [INFO] [stderr] 162 | const IMAGE_SCN_MEM_DISCARDABLE = 0x02000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:163:54 [INFO] [stderr] | [INFO] [stderr] 163 | const IMAGE_SCN_MEM_NOT_CACHED = 0x04000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | const IMAGE_SCN_MEM_NOT_PAGED = 0x08000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:165:54 [INFO] [stderr] | [INFO] [stderr] 165 | const IMAGE_SCN_MEM_SHARED = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:166:54 [INFO] [stderr] | [INFO] [stderr] 166 | const IMAGE_SCN_MEM_EXECUTE = 0x20000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:167:54 [INFO] [stderr] | [INFO] [stderr] 167 | const IMAGE_SCN_MEM_READ = 0x40000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:168:54 [INFO] [stderr] | [INFO] [stderr] 168 | const IMAGE_SCN_MEM_WRITE = 0x80000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:177:44 [INFO] [stderr] | [INFO] [stderr] 177 | 0x155a, 0x1636, 0x13d4, 0x155f, 0x1500, 0x10fe3c, 0x1456, 0x1587, 0x12ee, 0x1578, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_fe3c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:179:80 [INFO] [stderr] | [INFO] [stderr] 179 | 0x1537, 0x140b, 0x1618, 0x1087, 0x11b8, 0x127b, 0x147e, 0x137a, 0x1159, 0x10e1a8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_e1a8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | 0x1280, 0x10a5, 0x10a0, 0x1078, 0x1168, 0x15b9, 0x10fe38, 0x148d, 0x10eb, 0x13f7, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_fe38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:203:45 [INFO] [stderr] | [INFO] [stderr] 203 | 0x14a6, 0x105f, 0x11ae, 0x13ca, 0x12ee, 0x1654c0, 0x1460, 0x1235, 0x1555, 0x12ad, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0016_54c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:205:81 [INFO] [stderr] | [INFO] [stderr] 205 | 0x109b, 0x10c8, 0x1465, 0x13a7, 0x13f2, 0x11e5, 0x10f5, 0x10cd, 0x105a, 0x161468, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0016_1468` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:214:55 [INFO] [stderr] | [INFO] [stderr] 214 | 0x152d, 0x1406, 0x144c, 0x1415, 0x13b1, 0x1014, 0x1654b8, 0x12bc, 0x127b, 0x11f9, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0016_54b8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:217:27 [INFO] [stderr] | [INFO] [stderr] 217 | 0x157d, 0x1578, 0x1348, 0x1228ac, 0x10e1, 0x1550, 0x1564, 0x1131, 0x1280, 0x14b0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0012_28ac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | &PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | &PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | &PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | &PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | &PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | &PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | builder.field(&self.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | builder.field(&self.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utility.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | unsafe{transmute::<&[CChar],&str>(cstr).as_ref()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(cstr as *const [utility::CChar] as *const str)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utility.rs:233:19 [INFO] [stderr] | [INFO] [stderr] 233 | let cstr=unsafe{transmute::<&[u8],&[CChar]>(data)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(data as *const [u8] as *const [utility::CChar])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utility.rs:236:27 [INFO] [stderr] | [INFO] [stderr] 236 | Some(strz) => Ok(&cstr[..strz.len()+1]), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=strz.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 47 | | &PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 48 | | &PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 48 | PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 54 | | &PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] 55 | | &PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] 55 | PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | &PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] 62 | | &PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] 62 | PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:104:32 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(try!(self.resolve_rva_raw(rva+0u32,length,None)).offset(0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(try!(self.resolve_rva_raw(rva+0u32,length,None)).offset(0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | } else if sig as u32==PE_SIGNATURE { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(sig)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | pe_dd_fp=pe_oh_fp.offset(s as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pe_dd_fp=pe_oh_fp.offset(s as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:157:47 [INFO] [stderr] | [INFO] [stderr] 157 | let pe_sec=try!(data.ref_slice_at(pe_sec_fp,pe_header.number_of_sections as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pe_header.number_of_sections)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:174:36 [INFO] [stderr] | [INFO] [stderr] 174 | let fp=try!(self.resolve_rva_raw(rva+0u32,0,Some(&mut max_len))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | Ok(unsafe{transmute::<&DataDirectory<_>,&DataDirectory<_>>(&self.directories[entry as usize])}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.directories[entry as usize] as *const types::DataDirectory as *const types::DataDirectory>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | Ok(unsafe{transmute::<&DataDirectory<_>,&DataDirectory<_>>(&self.directories[entry as usize])}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.directories[entry as usize] as *const types::DataDirectory as *const types::DataDirectory>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:232:36 [INFO] [stderr] | [INFO] [stderr] 232 | ExportAddress::Forwarder(unsafe{transmute(addr)}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(addr as *const types::RawExportAddress as *const utility::RVA<[utility::CChar]>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | ExportAddress::Export(unsafe{transmute(addr)}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(addr as *const types::RawExportAddress as *const utility::RVA<(dyn std::ops::Fn() + 'static)>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | &PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:48:38 [INFO] [stderr] | [INFO] [stderr] 48 | &PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | &PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | &PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | &PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/lib.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | &PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | self.0.eq(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | self.0.partial_cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | self.0.cmp(&other.0) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | builder.field(&self.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 123 | define_urp!{pub struct FP;} [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/utility.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | builder.field(&self.0); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 124 | define_urp!{pub struct RVA;} [INFO] [stderr] | ------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utility.rs:146:10 [INFO] [stderr] | [INFO] [stderr] 146 | unsafe{transmute::<&[CChar],&str>(cstr).as_ref()} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(cstr as *const [utility::CChar] as *const str)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utility.rs:233:19 [INFO] [stderr] | [INFO] [stderr] 233 | let cstr=unsafe{transmute::<&[u8],&[CChar]>(data)}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(data as *const [u8] as *const [utility::CChar])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utility.rs:236:27 [INFO] [stderr] | [INFO] [stderr] 236 | Some(strz) => Ok(&cstr[..strz.len()+1]), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=strz.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 47 | | &PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 48 | | &PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | PeOptionalHeader::Pe32(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] 48 | PeOptionalHeader::Pe32Plus(h) => &h.number_of_rva_and_sizes, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 54 | | &PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] 55 | | &PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *self { [INFO] [stderr] 54 | PeOptionalHeader::Pe32(h) => &h.size_of_headers, [INFO] [stderr] 55 | PeOptionalHeader::Pe32Plus(h) => &h.size_of_headers, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | &PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] 62 | | &PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 60 | match *self { [INFO] [stderr] 61 | PeOptionalHeader::Pe32(h) => &h.check_sum, [INFO] [stderr] 62 | PeOptionalHeader::Pe32Plus(h) => &h.check_sum, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:104:32 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(try!(self.resolve_rva_raw(rva+0u32,length,None)).offset(0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:109:32 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(try!(self.resolve_rva_raw(rva+0u32,length,None)).offset(0)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | } else if sig as u32==PE_SIGNATURE { [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(sig)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | pe_dd_fp=pe_oh_fp.offset(s as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:30 [INFO] [stderr] | [INFO] [stderr] 144 | pe_dd_fp=pe_oh_fp.offset(s as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:157:47 [INFO] [stderr] | [INFO] [stderr] 157 | let pe_sec=try!(data.ref_slice_at(pe_sec_fp,pe_header.number_of_sections as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pe_header.number_of_sections)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `rva` [INFO] [stderr] --> src/lib.rs:174:36 [INFO] [stderr] | [INFO] [stderr] 174 | let fp=try!(self.resolve_rva_raw(rva+0u32,0,Some(&mut max_len))); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | Ok(unsafe{transmute::<&DataDirectory<_>,&DataDirectory<_>>(&self.directories[entry as usize])}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.directories[entry as usize] as *const types::DataDirectory as *const types::DataDirectory>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | Ok(unsafe{transmute::<&DataDirectory<_>,&DataDirectory<_>>(&self.directories[entry as usize])}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.directories[entry as usize] as *const types::DataDirectory as *const types::DataDirectory>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:232:36 [INFO] [stderr] | [INFO] [stderr] 232 | ExportAddress::Forwarder(unsafe{transmute(addr)}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(addr as *const types::RawExportAddress as *const utility::RVA<[utility::CChar]>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | ExportAddress::Export(unsafe{transmute(addr)}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(addr as *const types::RawExportAddress as *const utility::RVA<(dyn std::ops::Fn() + 'static)>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/set-characteristics.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | const USAGE: &'static str = "Usage: set-characteristics \n"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/tests.rs:194:4 [INFO] [stderr] | [INFO] [stderr] 194 | ].into_iter().map(|&i|ExportAddressTestValue::Export(i)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/tests.rs:220:4 [INFO] [stderr] | [INFO] [stderr] 220 | ].into_iter().map(|&i|ExportAddressTestValue::Export(i)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/set-characteristics.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | 16).expect(&format!("{}\nMust supply valid hexadecimal {} (no prefix)!",USAGE,"new-characteristics")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{}\nMust supply valid hexadecimal {} (no prefix)!", USAGE))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/set-characteristics.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | .into_string().expect(&format!("{}\nMust supply valid numeric {}!",USAGE,"new-characteristics")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{}\nMust supply valid numeric {}!", USAGE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/set-characteristics.rs:22:8 [INFO] [stderr] | [INFO] [stderr] 22 | &opt.expect(&format!("{}\nMust supply {} on command line!",USAGE,"new-characteristics")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{}\nMust supply {} on command line!", USAGE))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/set-characteristics.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | file.write(&unsafe{::std::mem::transmute::<_,[u8;2]>(new_characteristics)}).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `pe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "20fb6880ecbdb94c3ad32b9d51ecda5d4d54bed8ab7ef3fd478851fef88e9cf7"` [INFO] running `"docker" "rm" "-f" "20fb6880ecbdb94c3ad32b9d51ecda5d4d54bed8ab7ef3fd478851fef88e9cf7"` [INFO] [stdout] 20fb6880ecbdb94c3ad32b9d51ecda5d4d54bed8ab7ef3fd478851fef88e9cf7