[INFO] crate pdqsort 1.0.3 is already in cache [INFO] extracting crate pdqsort 1.0.3 into work/ex/clippy-test-run/sources/stable/reg/pdqsort/1.0.3 [INFO] extracting crate pdqsort 1.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdqsort/1.0.3 [INFO] validating manifest of pdqsort-1.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pdqsort-1.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pdqsort-1.0.3 [INFO] finished frobbing pdqsort-1.0.3 [INFO] frobbed toml for pdqsort-1.0.3 written to work/ex/clippy-test-run/sources/stable/reg/pdqsort/1.0.3/Cargo.toml [INFO] started frobbing pdqsort-1.0.3 [INFO] finished frobbing pdqsort-1.0.3 [INFO] frobbed toml for pdqsort-1.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdqsort/1.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pdqsort-1.0.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pdqsort/1.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b0a2237cbf2da96df86cc1d4faa2bca3192c4b95844323a71e5fa6a3c4348fa [INFO] running `"docker" "start" "-a" "4b0a2237cbf2da96df86cc1d4faa2bca3192c4b95844323a71e5fa6a3c4348fa"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking pdqsort v1.0.3 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:198:27 [INFO] [stderr] | [INFO] [stderr] 198 | shift_tail(&mut v[..i+1], is_less); [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lib.rs:253:1 [INFO] [stderr] | [INFO] [stderr] 253 | / fn partition_in_blocks(v: &mut [T], pivot: &T, is_less: &mut F) -> usize [INFO] [stderr] 254 | | where F: FnMut(&T, &T) -> bool [INFO] [stderr] 255 | | { [INFO] [stderr] 256 | | // Number of elements in a typical block. [INFO] [stderr] ... | [INFO] [stderr] 424 | | } [INFO] [stderr] 425 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | let mut r = unsafe { l.offset(v.len() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.add(v.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:380:26 [INFO] [stderr] | [INFO] [stderr] 380 | l = unsafe { l.offset(block_l as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `l.add(block_l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:551:19 [INFO] [stderr] | [INFO] [stderr] 551 | (((gen_u32() as u64) << 32) | (gen_u32() as u64)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(gen_u32())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:551:47 [INFO] [stderr] | [INFO] [stderr] 551 | (((gen_u32() as u64) << 32) | (gen_u32() as u64)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(gen_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `len / 4` [INFO] [stderr] --> src/lib.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | let mut a = len / 4 * 1; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4b0a2237cbf2da96df86cc1d4faa2bca3192c4b95844323a71e5fa6a3c4348fa"` [INFO] running `"docker" "rm" "-f" "4b0a2237cbf2da96df86cc1d4faa2bca3192c4b95844323a71e5fa6a3c4348fa"` [INFO] [stdout] 4b0a2237cbf2da96df86cc1d4faa2bca3192c4b95844323a71e5fa6a3c4348fa