[INFO] crate pcast 0.3.0 is already in cache [INFO] extracting crate pcast 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/pcast/0.3.0 [INFO] extracting crate pcast 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcast/0.3.0 [INFO] validating manifest of pcast-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pcast-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pcast-0.3.0 [INFO] finished frobbing pcast-0.3.0 [INFO] frobbed toml for pcast-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/pcast/0.3.0/Cargo.toml [INFO] started frobbing pcast-0.3.0 [INFO] finished frobbing pcast-0.3.0 [INFO] frobbed toml for pcast-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcast/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pcast-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pcast/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 102f71ab06399644a3bbf5a8e10759dc94c042ec4236d2d7a0c6943f8193b6d0 [INFO] running `"docker" "start" "-a" "102f71ab06399644a3bbf5a8e10759dc94c042ec4236d2d7a0c6943f8193b6d0"` [INFO] [stderr] Checking pcast v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | packet_type: packet_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | packet_type: packet_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | let mut status_mut_ref: &mut StatusPacket = (&mut owned).try_into().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | let mut status_mut_view: &mut StatusPacket = pref.try_into().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | let mut status_mut_view: &mut StatusPacket = (&mut owned).try_into().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { ::std::mem::transmute::<&$sub, &$base>(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const test::PingPacket as *const test::Packet)` [INFO] [stderr] ... [INFO] [stderr] 175 | / subtype_of!(Packet => PingPacket | ConversionError { [INFO] [stderr] 176 | | Ok(()) [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(unsafe { ::std::mem::transmute::<&$base, &$sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(base_ref as *const test::Packet as *const test::PingPacket)` [INFO] [stderr] ... [INFO] [stderr] 175 | / subtype_of!(Packet => PingPacket | ConversionError { [INFO] [stderr] 176 | | Ok(()) [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(unsafe { ::std::mem::transmute::<&mut $base, &mut $sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(base_ref as *mut test::Packet as *mut test::PingPacket)` [INFO] [stderr] ... [INFO] [stderr] 175 | / subtype_of!(Packet => PingPacket | ConversionError { [INFO] [stderr] 176 | | Ok(()) [INFO] [stderr] 177 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { ::std::mem::transmute::<&$sub, &$base>(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const test::PongPacket as *const test::Packet)` [INFO] [stderr] ... [INFO] [stderr] 178 | / subtype_of!(Packet => PongPacket | PongConvError { [INFO] [stderr] 179 | | Err(PongConvError {}) [INFO] [stderr] 180 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(unsafe { ::std::mem::transmute::<&$base, &$sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(base_ref as *const test::Packet as *const test::PongPacket)` [INFO] [stderr] ... [INFO] [stderr] 178 | / subtype_of!(Packet => PongPacket | PongConvError { [INFO] [stderr] 179 | | Err(PongConvError {}) [INFO] [stderr] 180 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(unsafe { ::std::mem::transmute::<&mut $base, &mut $sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(base_ref as *mut test::Packet as *mut test::PongPacket)` [INFO] [stderr] ... [INFO] [stderr] 178 | / subtype_of!(Packet => PongPacket | PongConvError { [INFO] [stderr] 179 | | Err(PongConvError {}) [INFO] [stderr] 180 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | unsafe { ::std::mem::transmute::<&$sub, &$base>(self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const test::StatusPacket as *const test::Packet)` [INFO] [stderr] ... [INFO] [stderr] 181 | / subtype_of!(Packet => StatusPacket | () { [INFO] [stderr] 182 | | Ok(()) [INFO] [stderr] 183 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(unsafe { ::std::mem::transmute::<&$base, &$sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(base_ref as *const test::Packet as *const test::StatusPacket)` [INFO] [stderr] ... [INFO] [stderr] 181 | / subtype_of!(Packet => StatusPacket | () { [INFO] [stderr] 182 | | Ok(()) [INFO] [stderr] 183 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(unsafe { ::std::mem::transmute::<&mut $base, &mut $sub>(base_ref) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(base_ref as *mut test::Packet as *mut test::StatusPacket)` [INFO] [stderr] ... [INFO] [stderr] 181 | / subtype_of!(Packet => StatusPacket | () { [INFO] [stderr] 182 | | Ok(()) [INFO] [stderr] 183 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `"docker" "inspect" "102f71ab06399644a3bbf5a8e10759dc94c042ec4236d2d7a0c6943f8193b6d0"` [INFO] running `"docker" "rm" "-f" "102f71ab06399644a3bbf5a8e10759dc94c042ec4236d2d7a0c6943f8193b6d0"` [INFO] [stdout] 102f71ab06399644a3bbf5a8e10759dc94c042ec4236d2d7a0c6943f8193b6d0