[INFO] crate parse_tree 0.0.7 is already in cache [INFO] extracting crate parse_tree 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/parse_tree/0.0.7 [INFO] extracting crate parse_tree 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parse_tree/0.0.7 [INFO] validating manifest of parse_tree-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parse_tree-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parse_tree-0.0.7 [INFO] finished frobbing parse_tree-0.0.7 [INFO] frobbed toml for parse_tree-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/parse_tree/0.0.7/Cargo.toml [INFO] started frobbing parse_tree-0.0.7 [INFO] finished frobbing parse_tree-0.0.7 [INFO] frobbed toml for parse_tree-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parse_tree/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parse_tree-0.0.7 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parse_tree/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf003af86de872378716d4a0981ecf1b1e7a1d582fefdf18c2798759389760e6 [INFO] running `"docker" "start" "-a" "cf003af86de872378716d4a0981ecf1b1e7a1d582fefdf18c2798759389760e6"` [INFO] [stderr] Checking text_unit v0.1.6 [INFO] [stderr] Checking parse_tree v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algo/search.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return if let Some(right) = right { [INFO] [stderr] 53 | | match (go(tree, left, offset), go(tree, right, offset)) { [INFO] [stderr] 54 | | (LeafAtOffset::Single(left), LeafAtOffset::Single(right)) => [INFO] [stderr] 55 | | LeafAtOffset::Between(left, right), [INFO] [stderr] ... | [INFO] [stderr] 59 | | go(tree, left, offset) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | if let Some(right) = right { [INFO] [stderr] 53 | match (go(tree, left, offset), go(tree, right, offset)) { [INFO] [stderr] 54 | (LeafAtOffset::Single(left), LeafAtOffset::Single(right)) => [INFO] [stderr] 55 | LeafAtOffset::Between(left, right), [INFO] [stderr] 56 | _ => unreachable!() [INFO] [stderr] 57 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algo/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return dumper.buff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dumper.buff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algo/search.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / return if let Some(right) = right { [INFO] [stderr] 53 | | match (go(tree, left, offset), go(tree, right, offset)) { [INFO] [stderr] 54 | | (LeafAtOffset::Single(left), LeafAtOffset::Single(right)) => [INFO] [stderr] 55 | | LeafAtOffset::Between(left, right), [INFO] [stderr] ... | [INFO] [stderr] 59 | | go(tree, left, offset) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | if let Some(right) = right { [INFO] [stderr] 53 | match (go(tree, left, offset), go(tree, right, offset)) { [INFO] [stderr] 54 | (LeafAtOffset::Single(left), LeafAtOffset::Single(right)) => [INFO] [stderr] 55 | LeafAtOffset::Between(left, right), [INFO] [stderr] 56 | _ => unreachable!() [INFO] [stderr] 57 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algo/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return dumper.buff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dumper.buff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/algo/mod.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn debug_dump<'t>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/algo/mod.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn debug_dump<'t>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.33s [INFO] running `"docker" "inspect" "cf003af86de872378716d4a0981ecf1b1e7a1d582fefdf18c2798759389760e6"` [INFO] running `"docker" "rm" "-f" "cf003af86de872378716d4a0981ecf1b1e7a1d582fefdf18c2798759389760e6"` [INFO] [stdout] cf003af86de872378716d4a0981ecf1b1e7a1d582fefdf18c2798759389760e6