[INFO] crate parity-bytes 0.1.0 is already in cache [INFO] extracting crate parity-bytes 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/parity-bytes/0.1.0 [INFO] extracting crate parity-bytes 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parity-bytes/0.1.0 [INFO] validating manifest of parity-bytes-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of parity-bytes-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing parity-bytes-0.1.0 [INFO] finished frobbing parity-bytes-0.1.0 [INFO] frobbed toml for parity-bytes-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/parity-bytes/0.1.0/Cargo.toml [INFO] started frobbing parity-bytes-0.1.0 [INFO] finished frobbing parity-bytes-0.1.0 [INFO] frobbed toml for parity-bytes-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parity-bytes/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting parity-bytes-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/parity-bytes/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cbc17e4a90dca45ba29190709720b08b0995a84bb4ec30155929e62c9c27279 [INFO] running `"docker" "start" "-a" "2cbc17e4a90dca45ba29190709720b08b0995a84bb4ec30155929e62c9c27279"` [INFO] [stderr] Checking parity-bytes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | match i > 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] 33 | | true => { write!(f, "·{:02x}", self.0[i])?; }, [INFO] [stderr] 34 | | false => { write!(f, "{:02x}", self.0[i])?; }, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if i > 0 { write!(f, "·{:02x}", self.0[i])?; } else { write!(f, "{:02x}", self.0[i])?; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..max { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `data[offset..(max + offset)].clone_from_slice(&input[..max])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:32:4 [INFO] [stderr] | [INFO] [stderr] 32 | match i > 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] 33 | | true => { write!(f, "·{:02x}", self.0[i])?; }, [INFO] [stderr] 34 | | false => { write!(f, "{:02x}", self.0[i])?; }, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if i > 0 { write!(f, "·{:02x}", self.0[i])?; } else { write!(f, "{:02x}", self.0[i])?; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..max { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `data[offset..(max + offset)].clone_from_slice(&input[..max])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "2cbc17e4a90dca45ba29190709720b08b0995a84bb4ec30155929e62c9c27279"` [INFO] running `"docker" "rm" "-f" "2cbc17e4a90dca45ba29190709720b08b0995a84bb4ec30155929e62c9c27279"` [INFO] [stdout] 2cbc17e4a90dca45ba29190709720b08b0995a84bb4ec30155929e62c9c27279