[INFO] crate paragraph-breaker 0.4.2 is already in cache [INFO] extracting crate paragraph-breaker 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/paragraph-breaker/0.4.2 [INFO] extracting crate paragraph-breaker 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paragraph-breaker/0.4.2 [INFO] validating manifest of paragraph-breaker-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of paragraph-breaker-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing paragraph-breaker-0.4.2 [INFO] finished frobbing paragraph-breaker-0.4.2 [INFO] frobbed toml for paragraph-breaker-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/paragraph-breaker/0.4.2/Cargo.toml [INFO] started frobbing paragraph-breaker-0.4.2 [INFO] finished frobbing paragraph-breaker-0.4.2 [INFO] frobbed toml for paragraph-breaker-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paragraph-breaker/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting paragraph-breaker-0.4.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/paragraph-breaker/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23d92192f66428418dec46cb316f69b6bbf2a2643f0a5d5a64a0c88e6b084d73 [INFO] running `"docker" "start" "-a" "23d92192f66428418dec46cb316f69b6bbf2a2643f0a5d5a64a0c88e6b084d73"` [INFO] [stderr] Checking paragraph-breaker v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:612:13 [INFO] [stderr] | [INFO] [stderr] 612 | / if "- ­".find(c).is_some() { [INFO] [stderr] 613 | | if !buf.is_empty() { [INFO] [stderr] 614 | | result.push(Item::Box { width, data: () }); [INFO] [stderr] 615 | | buf.clear(); [INFO] [stderr] 616 | | width = 0; [INFO] [stderr] 617 | | } [INFO] [stderr] 618 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 612 | if "- ­".find(c).is_some() && !buf.is_empty() { [INFO] [stderr] 613 | result.push(Item::Box { width, data: () }); [INFO] [stderr] 614 | buf.clear(); [INFO] [stderr] 615 | width = 0; [INFO] [stderr] 616 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `items` [INFO] [stderr] --> src/lib.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for i in index..items.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (i, ) in items.iter().enumerate().skip(index) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:211:1 [INFO] [stderr] | [INFO] [stderr] 211 | / fn explore(nodes: &mut Vec, head: &mut usize, items: &[Item], lengths: &[i32], sums: &Sums, threshold: f32, boundary: usize, index: usize) { [INFO] [stderr] 212 | | let mut current = *head; [INFO] [stderr] 213 | | let mut previous = NULL; [INFO] [stderr] 214 | | [INFO] [stderr] ... | [INFO] [stderr] 295 | | } [INFO] [stderr] 296 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `items` [INFO] [stderr] --> src/lib.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for i in index..items.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (i, ) in items.iter().enumerate().skip(index) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:211:1 [INFO] [stderr] | [INFO] [stderr] 211 | / fn explore(nodes: &mut Vec, head: &mut usize, items: &[Item], lengths: &[i32], sums: &Sums, threshold: f32, boundary: usize, index: usize) { [INFO] [stderr] 212 | | let mut current = *head; [INFO] [stderr] 213 | | let mut previous = NULL; [INFO] [stderr] 214 | | [INFO] [stderr] ... | [INFO] [stderr] 295 | | } [INFO] [stderr] 296 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "23d92192f66428418dec46cb316f69b6bbf2a2643f0a5d5a64a0c88e6b084d73"` [INFO] running `"docker" "rm" "-f" "23d92192f66428418dec46cb316f69b6bbf2a2643f0a5d5a64a0c88e6b084d73"` [INFO] [stdout] 23d92192f66428418dec46cb316f69b6bbf2a2643f0a5d5a64a0c88e6b084d73