[INFO] crate osu_format 0.1.1 is already in cache [INFO] extracting crate osu_format 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/osu_format/0.1.1 [INFO] extracting crate osu_format 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osu_format/0.1.1 [INFO] validating manifest of osu_format-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of osu_format-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing osu_format-0.1.1 [INFO] finished frobbing osu_format-0.1.1 [INFO] frobbed toml for osu_format-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/osu_format/0.1.1/Cargo.toml [INFO] started frobbing osu_format-0.1.1 [INFO] finished frobbing osu_format-0.1.1 [INFO] frobbed toml for osu_format-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osu_format/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting osu_format-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/osu_format/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2425cd4c234cfca4858c1165e55be1bf50a8eaedd8b3c697616366b6e1e8965b [INFO] running `"docker" "start" "-a" "2425cd4c234cfca4858c1165e55be1bf50a8eaedd8b3c697616366b6e1e8965b"` [INFO] [stderr] Checking osu_format v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:10 [INFO] [stderr] | [INFO] [stderr] 185 | Parser{lines: lines, section: None, done: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:378:23 [INFO] [stderr] | [INFO] [stderr] 378 | HitObject::Circle{base: base} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:381:6 [INFO] [stderr] | [INFO] [stderr] 381 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:6 [INFO] [stderr] | [INFO] [stderr] 389 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:395:6 [INFO] [stderr] | [INFO] [stderr] 395 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:10 [INFO] [stderr] | [INFO] [stderr] 185 | Parser{lines: lines, section: None, done: false} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:378:23 [INFO] [stderr] | [INFO] [stderr] 378 | HitObject::Circle{base: base} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:381:6 [INFO] [stderr] | [INFO] [stderr] 381 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:6 [INFO] [stderr] | [INFO] [stderr] 389 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:395:6 [INFO] [stderr] | [INFO] [stderr] 395 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:3 [INFO] [stderr] | [INFO] [stderr] 106 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 151 | | &HitObject::Circle{ref base, ..} | [INFO] [stderr] 152 | | &HitObject::Slider{ref base, ..} | [INFO] [stderr] 153 | | &HitObject::Spinner{ref base, ..} | [INFO] [stderr] 154 | | &HitObject::LongNote{ref base, ..} | [INFO] [stderr] 155 | | &HitObject::Other(ref base) => base, [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 150 | match *self { [INFO] [stderr] 151 | HitObject::Circle{ref base, ..} | [INFO] [stderr] 152 | HitObject::Slider{ref base, ..} | [INFO] [stderr] 153 | HitObject::Spinner{ref base, ..} | [INFO] [stderr] 154 | HitObject::LongNote{ref base, ..} | [INFO] [stderr] 155 | HitObject::Other(ref base) => base, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | if s.len() == 0 || s.starts_with("//") { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:211:23 [INFO] [stderr] | [INFO] [stderr] 211 | if s.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 151 | | &HitObject::Circle{ref base, ..} | [INFO] [stderr] 152 | | &HitObject::Slider{ref base, ..} | [INFO] [stderr] 153 | | &HitObject::Spinner{ref base, ..} | [INFO] [stderr] 154 | | &HitObject::LongNote{ref base, ..} | [INFO] [stderr] 155 | | &HitObject::Other(ref base) => base, [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 150 | match *self { [INFO] [stderr] 151 | HitObject::Circle{ref base, ..} | [INFO] [stderr] 152 | HitObject::Slider{ref base, ..} | [INFO] [stderr] 153 | HitObject::Spinner{ref base, ..} | [INFO] [stderr] 154 | HitObject::LongNote{ref base, ..} | [INFO] [stderr] 155 | HitObject::Other(ref base) => base, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | if s.len() == 0 || s.starts_with("//") { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:211:23 [INFO] [stderr] | [INFO] [stderr] 211 | if s.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "2425cd4c234cfca4858c1165e55be1bf50a8eaedd8b3c697616366b6e1e8965b"` [INFO] running `"docker" "rm" "-f" "2425cd4c234cfca4858c1165e55be1bf50a8eaedd8b3c697616366b6e1e8965b"` [INFO] [stdout] 2425cd4c234cfca4858c1165e55be1bf50a8eaedd8b3c697616366b6e1e8965b