[INFO] crate ordermap 0.4.2 is already in cache [INFO] extracting crate ordermap 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/ordermap/0.4.2 [INFO] extracting crate ordermap 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ordermap/0.4.2 [INFO] validating manifest of ordermap-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ordermap-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ordermap-0.4.2 [INFO] finished frobbing ordermap-0.4.2 [INFO] frobbed toml for ordermap-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/ordermap/0.4.2/Cargo.toml [INFO] started frobbing ordermap-0.4.2 [INFO] finished frobbing ordermap-0.4.2 [INFO] frobbed toml for ordermap-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ordermap/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ordermap-0.4.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ordermap/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26fb766a275c8aca912a93d367d6d7c226fc74c436821e3c64aec6afac0cc7ae [INFO] running `"docker" "start" "-a" "26fb766a275c8aca912a93d367d6d7c226fc74c436821e3c64aec6afac0cc7ae"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking ordermap v0.4.2 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/set.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | hash_builder: hash_builder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:633:72 [INFO] [stderr] | [INFO] [stderr] 633 | self.map.entries.push(Bucket { hash: self.hash, key: self.key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:36 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:48 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map.rs:1199:58 [INFO] [stderr] | [INFO] [stderr] 1199 | self.entries.push(Bucket { hash: hash, key: key, value: value }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `serde`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/map.rs:170:16 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 171 | | if !self.is_none() { [INFO] [stderr] 172 | | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 173 | | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if !self.is_none() { [INFO] [stderr] 171 | let (i, hash) = split_lo_hi(self.index); [INFO] [stderr] 172 | Some((i as usize, ShortHashProxy::new(hash as usize))) [INFO] [stderr] 173 | } else { [INFO] [stderr] 174 | None [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/set.rs:517:20 [INFO] [stderr] | [INFO] [stderr] 517 | let iter = iterable.into_iter().map(|&x| x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iterable.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | fn is_none(&self) -> bool { self.index == !0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | fn pos(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | fn resolve(&self) -> Option<(usize, ShortHashProxy)> [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/map.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | fn resolve_existing_index(&self) -> usize [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/map.rs:835:12 [INFO] [stderr] | [INFO] [stderr] 835 | if self.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/map.rs:1094:24 [INFO] [stderr] | [INFO] [stderr] 1094 | if let Some(_) = self.indices[probe].resolve::() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 1095 | | /* nothing */ [INFO] [stderr] 1096 | | } else { [INFO] [stderr] 1097 | | // empty bucket, insert here [INFO] [stderr] 1098 | | self.indices[probe] = Pos::with_hash::(i, entry_hash); [INFO] [stderr] 1099 | | return; [INFO] [stderr] 1100 | | } [INFO] [stderr] | |_________________- help: try this: `if self.indices[probe].resolve::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "26fb766a275c8aca912a93d367d6d7c226fc74c436821e3c64aec6afac0cc7ae"` [INFO] running `"docker" "rm" "-f" "26fb766a275c8aca912a93d367d6d7c226fc74c436821e3c64aec6afac0cc7ae"` [INFO] [stdout] 26fb766a275c8aca912a93d367d6d7c226fc74c436821e3c64aec6afac0cc7ae