[INFO] crate orc 0.0.1 is already in cache [INFO] extracting crate orc 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/orc/0.0.1 [INFO] extracting crate orc 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/orc/0.0.1 [INFO] validating manifest of orc-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of orc-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing orc-0.0.1 [INFO] finished frobbing orc-0.0.1 [INFO] frobbed toml for orc-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/orc/0.0.1/Cargo.toml [INFO] started frobbing orc-0.0.1 [INFO] finished frobbing orc-0.0.1 [INFO] frobbed toml for orc-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/orc/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting orc-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/orc/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15ac1edcc7c2bf33543d373e75301f7c48b1a028ae01ebf2f02690cc08fc1f5a [INFO] running `"docker" "start" "-a" "15ac1edcc7c2bf33543d373e75301f7c48b1a028ae01ebf2f02690cc08fc1f5a"` [INFO] [stderr] Checking orc v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | OrcHeap:: { heap: heap } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | pointer_data: pointer_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pointer_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | OrcHeap:: { heap: heap } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | pointer_data: pointer_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pointer_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: value assigned to `position` is never read [INFO] [stderr] --> src/lib.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | position = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OrcHeap` [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn new() -> OrcHeap { [INFO] [stderr] 99 | | const DEFAULT_HEAP_SIZE: usize = 16; [INFO] [stderr] 100 | | OrcHeap::::with_capacity(DEFAULT_HEAP_SIZE) [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | let (_, weight) = deconstruct_pointer(heap.iter().nth(capacity - 1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let ref data: Option = slot.data; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let data: &Option = &slot.data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let ref data: Option = slot.data; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let data: &Option = &slot.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `position` is never read [INFO] [stderr] --> src/lib.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | position = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `OrcHeap` [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn new() -> OrcHeap { [INFO] [stderr] 99 | | const DEFAULT_HEAP_SIZE: usize = 16; [INFO] [stderr] 100 | | OrcHeap::::with_capacity(DEFAULT_HEAP_SIZE) [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:119:47 [INFO] [stderr] | [INFO] [stderr] 119 | let (_, weight) = deconstruct_pointer(heap.iter().nth(capacity - 1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let ref data: Option = slot.data; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let data: &Option = &slot.data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:166:25 [INFO] [stderr] | [INFO] [stderr] 166 | let ref data: Option = slot.data; [INFO] [stderr] | ----^^^^^^^^------------------------ help: try: `let data: &Option = &slot.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `"docker" "inspect" "15ac1edcc7c2bf33543d373e75301f7c48b1a028ae01ebf2f02690cc08fc1f5a"` [INFO] running `"docker" "rm" "-f" "15ac1edcc7c2bf33543d373e75301f7c48b1a028ae01ebf2f02690cc08fc1f5a"` [INFO] [stdout] 15ac1edcc7c2bf33543d373e75301f7c48b1a028ae01ebf2f02690cc08fc1f5a