[INFO] crate opter 0.2.0 is already in cache
[INFO] extracting crate opter 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/opter/0.2.0
[INFO] extracting crate opter 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opter/0.2.0
[INFO] validating manifest of opter-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of opter-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing opter-0.2.0
[INFO] finished frobbing opter-0.2.0
[INFO] frobbed toml for opter-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/opter/0.2.0/Cargo.toml
[INFO] started frobbing opter-0.2.0
[INFO] finished frobbing opter-0.2.0
[INFO] frobbed toml for opter-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opter/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting opter-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/opter/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a73c156b51add096610bc8b5fc85cccf169ee2e72292ff585f531ee850d77543
[INFO] running `"docker" "start" "-a" "a73c156b51add096610bc8b5fc85cccf169ee2e72292ff585f531ee850d77543"`
[INFO] [stderr]     Checking opter v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 |         return Some(Opt::Ordinal(value));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Opt::Ordinal(value))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return self.next_opt();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_opt()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 | /     return Opts {
[INFO] [stderr] 178 | |         iter  : values.into_iter(),
[INFO] [stderr] 179 | |         flags : Vec::new(),
[INFO] [stderr] 180 | |         name  : String::new(),
[INFO] [stderr] 181 | |         drain : false,
[INFO] [stderr] 182 | |         done  : false,
[INFO] [stderr] 183 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 177 |     Opts {
[INFO] [stderr] 178 |         iter  : values.into_iter(),
[INFO] [stderr] 179 |         flags : Vec::new(),
[INFO] [stderr] 180 |         name  : String::new(),
[INFO] [stderr] 181 |         drain : false,
[INFO] [stderr] 182 |         done  : false,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:187:5
[INFO] [stderr]     |
[INFO] [stderr] 187 |     return parse(env::args().skip(1));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse(env::args().skip(1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:154:9
[INFO] [stderr]     |
[INFO] [stderr] 154 |         return Some(Opt::Ordinal(value));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Opt::Ordinal(value))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:162:9
[INFO] [stderr]     |
[INFO] [stderr] 162 |         return self.next_opt();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_opt()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 | /     return Opts {
[INFO] [stderr] 178 | |         iter  : values.into_iter(),
[INFO] [stderr] 179 | |         flags : Vec::new(),
[INFO] [stderr] 180 | |         name  : String::new(),
[INFO] [stderr] 181 | |         drain : false,
[INFO] [stderr] 182 | |         done  : false,
[INFO] [stderr] 183 | |     };
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 177 |     Opts {
[INFO] [stderr] 178 |         iter  : values.into_iter(),
[INFO] [stderr] 179 |         flags : Vec::new(),
[INFO] [stderr] 180 |         name  : String::new(),
[INFO] [stderr] 181 |         drain : false,
[INFO] [stderr] 182 |         done  : false,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:187:5
[INFO] [stderr]     |
[INFO] [stderr] 187 |     return parse(env::args().skip(1));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse(env::args().skip(1))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:203:9
[INFO] [stderr]     |
[INFO] [stderr] 203 |         return s.split(" ").map(|s| s.to_string()).collect();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.split(" ").map(|s| s.to_string()).collect()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:207:9
[INFO] [stderr]     |
[INFO] [stderr] 207 |         return super::parse(args_from_str(s)).collect();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `super::parse(args_from_str(s)).collect()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:211:9
[INFO] [stderr]     |
[INFO] [stderr] 211 |         return Opt::Flag(name.to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opt::Flag(name.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 |         return Opt::Named(name.to_string(), value.to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opt::Named(name.to_string(), value.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:219:9
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return Opt::Ordinal(value.to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opt::Ordinal(value.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 |         return Opt::Raw(value.to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opt::Raw(value.to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |         else if value.starts_with("-") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:106:35
[INFO] [stderr]     |
[INFO] [stderr] 106 |         else if value.starts_with("-") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:203:24
[INFO] [stderr]     |
[INFO] [stderr] 203 |         return s.split(" ").map(|s| s.to_string()).collect();
[INFO] [stderr]     |                        ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.64s
[INFO] running `"docker" "inspect" "a73c156b51add096610bc8b5fc85cccf169ee2e72292ff585f531ee850d77543"`
[INFO] running `"docker" "rm" "-f" "a73c156b51add096610bc8b5fc85cccf169ee2e72292ff585f531ee850d77543"`
[INFO] [stdout] a73c156b51add096610bc8b5fc85cccf169ee2e72292ff585f531ee850d77543