[INFO] crate operational 0.0.5 is already in cache [INFO] extracting crate operational 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/operational/0.0.5 [INFO] extracting crate operational 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/operational/0.0.5 [INFO] validating manifest of operational-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of operational-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing operational-0.0.5 [INFO] finished frobbing operational-0.0.5 [INFO] frobbed toml for operational-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/operational/0.0.5/Cargo.toml [INFO] started frobbing operational-0.0.5 [INFO] finished frobbing operational-0.0.5 [INFO] frobbed toml for operational-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/operational/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting operational-0.0.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/operational/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8cf64756eef80c1ef836448664ca6f13c78137c47d27951df464d61fe4baf56 [INFO] running `"docker" "start" "-a" "e8cf64756eef80c1ef836448664ca6f13c78137c47d27951df464d61fe4baf56"` [INFO] [stderr] Checking operational v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/kleisli.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | deque: VecDeque) -> Program<'a, I, ()> + 'a>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `kleisli::Kleisli<'a, I, A, A>` [INFO] [stderr] --> src/kleisli.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Kleisli<'a, I, A, A> { [INFO] [stderr] 32 | | Kleisli { phan: PhantomData, deque: VecDeque::new() } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kleisli.rs:70:53 [INFO] [stderr] | [INFO] [stderr] 70 | Some(f) => r = r.and_then_boxed(move |a| (*f)(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `(*f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match self { [INFO] [stderr] 83 | | &Program::Pure(ref a) => write!(f, "Pure({:?})", a), [INFO] [stderr] 84 | | &Program::Then(_, _) => write!(f, "Then(..)") [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *self { [INFO] [stderr] 83 | Program::Pure(ref a) => write!(f, "Pure({:?})", a), [INFO] [stderr] 84 | Program::Then(_, _) => write!(f, "Then(..)") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/kleisli.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | deque: VecDeque) -> Program<'a, I, ()> + 'a>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `kleisli::Kleisli<'a, I, A, A>` [INFO] [stderr] --> src/kleisli.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Kleisli<'a, I, A, A> { [INFO] [stderr] 32 | | Kleisli { phan: PhantomData, deque: VecDeque::new() } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/kleisli.rs:70:53 [INFO] [stderr] | [INFO] [stderr] 70 | Some(f) => r = r.and_then_boxed(move |a| (*f)(a)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `(*f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match self { [INFO] [stderr] 83 | | &Program::Pure(ref a) => write!(f, "Pure({:?})", a), [INFO] [stderr] 84 | | &Program::Then(_, _) => write!(f, "Then(..)") [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *self { [INFO] [stderr] 83 | Program::Pure(ref a) => write!(f, "Pure({:?})", a), [INFO] [stderr] 84 | Program::Then(_, _) => write!(f, "Then(..)") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "e8cf64756eef80c1ef836448664ca6f13c78137c47d27951df464d61fe4baf56"` [INFO] running `"docker" "rm" "-f" "e8cf64756eef80c1ef836448664ca6f13c78137c47d27951df464d61fe4baf56"` [INFO] [stdout] e8cf64756eef80c1ef836448664ca6f13c78137c47d27951df464d61fe4baf56