[INFO] crate openaip 0.1.0 is already in cache [INFO] extracting crate openaip 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/openaip/0.1.0 [INFO] extracting crate openaip 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openaip/0.1.0 [INFO] validating manifest of openaip-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of openaip-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing openaip-0.1.0 [INFO] finished frobbing openaip-0.1.0 [INFO] frobbed toml for openaip-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/openaip/0.1.0/Cargo.toml [INFO] started frobbing openaip-0.1.0 [INFO] finished frobbing openaip-0.1.0 [INFO] frobbed toml for openaip-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openaip/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting openaip-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/openaip/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06115bbeee74800e86085ec7ec7cab2fa029c24a7aff6661c98fe1289f161614 [INFO] running `"docker" "start" "-a" "06115bbeee74800e86085ec7ec7cab2fa029c24a7aff6661c98fe1289f161614"` [INFO] [stderr] Checking xml-rs v0.4.1 [INFO] [stderr] Checking xmltree v0.4.0 [INFO] [stderr] Checking openaip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/geometry.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/geometry.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/xml.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | self.attributes.get(k).ok_or(Error::MissingAttribute(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingAttribute(k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/xml.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | self.get_child(k).ok_or(Error::MissingElement(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingElement(k))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/xml.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | self.attributes.get(k).ok_or(Error::MissingAttribute(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingAttribute(k))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/xml.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | self.get_child(k).ok_or(Error::MissingElement(k)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingElement(k))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:66:56 [INFO] [stderr] | [INFO] [stderr] 66 | assert_relative_eq!(first_point.longitude, 9.1911111111111); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `9.191_111_111_111_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:67:55 [INFO] [stderr] | [INFO] [stderr] 67 | assert_relative_eq!(first_point.latitude, 48.491111111111); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `48.491_111_111_111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:70:57 [INFO] [stderr] | [INFO] [stderr] 70 | assert_relative_eq!(second_point.longitude, 9.3727777777778); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `9.372_777_777_777_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:71:56 [INFO] [stderr] | [INFO] [stderr] 71 | assert_relative_eq!(second_point.latitude, 48.565555555556); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `48.565_555_555_556` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/integration_test.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref airspaces = file.airspaces.as_ref().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------------------ help: try: `let airspaces = &file.airspaces.as_ref().unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.28s [INFO] running `"docker" "inspect" "06115bbeee74800e86085ec7ec7cab2fa029c24a7aff6661c98fe1289f161614"` [INFO] running `"docker" "rm" "-f" "06115bbeee74800e86085ec7ec7cab2fa029c24a7aff6661c98fe1289f161614"` [INFO] [stdout] 06115bbeee74800e86085ec7ec7cab2fa029c24a7aff6661c98fe1289f161614