[INFO] crate ole 0.1.15 is already in cache [INFO] extracting crate ole 0.1.15 into work/ex/clippy-test-run/sources/stable/reg/ole/0.1.15 [INFO] extracting crate ole 0.1.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ole/0.1.15 [INFO] validating manifest of ole-0.1.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ole-0.1.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ole-0.1.15 [INFO] finished frobbing ole-0.1.15 [INFO] frobbed toml for ole-0.1.15 written to work/ex/clippy-test-run/sources/stable/reg/ole/0.1.15/Cargo.toml [INFO] started frobbing ole-0.1.15 [INFO] finished frobbing ole-0.1.15 [INFO] frobbed toml for ole-0.1.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ole/0.1.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ole-0.1.15 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ole/0.1.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afb3327f62bdb8c235f9bff94d16676bbb07342fc610edcc59ac72255e54810b [INFO] running `"docker" "start" "-a" "afb3327f62bdb8c235f9bff94d16676bbb07342fc610edcc59ac72255e54810b"` [INFO] [stderr] Checking ole v0.1.15 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iterator.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | ole: ole, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ole` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:303:7 [INFO] [stderr] | [INFO] [stderr] 303 | max_chunk_size: max_chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_chunk_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iterator.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | ole: ole, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ole` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:303:7 [INFO] [stderr] | [INFO] [stderr] 303 | max_chunk_size: max_chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_chunk_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:28:48 [INFO] [stderr] | [INFO] [stderr] 28 | pub(crate) const END_OF_CHAIN_SECID_U32: u32 = 0xFFFFFFFEu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFEu32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:29:40 [INFO] [stderr] | [INFO] [stderr] 29 | pub(crate) const FREE_SECID_U32: u32 = 0xFFFFFFFFu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:28:48 [INFO] [stderr] | [INFO] [stderr] 28 | pub(crate) const END_OF_CHAIN_SECID_U32: u32 = 0xFFFFFFFEu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFEu32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:29:40 [INFO] [stderr] | [INFO] [stderr] 29 | pub(crate) const FREE_SECID_U32: u32 = 0xFFFFFFFFu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if &super::constants::IDENTIFIER != &header[0..8] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 34 | if super::constants::IDENTIFIER != header[0..8] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | if &header[28..30] == &super::constants::BIG_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 48 | if header[28..30] == super::constants::BIG_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | &header[28..30] != &super::constants::LITTLE_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | header[28..30] != super::constants::LITTLE_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | if &header[68..72] != &super::constants::END_OF_CHAIN_SECID { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 114 | if header[68..72] != super::constants::END_OF_CHAIN_SECID { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/header.rs:174:8 [INFO] [stderr] | [INFO] [stderr] 174 | if !self.body.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.body.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:190:30 [INFO] [stderr] | [INFO] [stderr] 190 | while i < max_sec_ids && &buffer[offset .. offset + 4] [INFO] [stderr] | ______________________________^ [INFO] [stderr] 191 | | != &super::constants::FREE_SECID { [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 190 | while i < max_sec_ids && buffer[offset .. offset + 4] [INFO] [stderr] 191 | != super::constants::FREE_SECID { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | result += (buf[i] as u32) * 256u32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | result += (buf[i] as i32) * 256i32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | result += (buf[i] as u64) * 256u64.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sat.rs:27:8 [INFO] [stderr] | [INFO] [stderr] 27 | if self.msat.as_ref().unwrap().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.msat.as_ref().unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `entry::Entry` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/entry.rs:159:1 [INFO] [stderr] | [INFO] [stderr] 159 | / impl Entry { [INFO] [stderr] 160 | | [INFO] [stderr] 161 | | fn from_slice(sector: &[u8], dir_id: u32) [INFO] [stderr] 162 | | -> Result { [INFO] [stderr] ... | [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/entry.rs:193:7 [INFO] [stderr] | [INFO] [stderr] 193 | i = i + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: item `entry::EntrySlice<'s>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/entry.rs:300:1 [INFO] [stderr] | [INFO] [stderr] 300 | / impl<'s> EntrySlice<'s> { [INFO] [stderr] 301 | | fn new(max_chunk_size: usize, size: usize) -> EntrySlice<'s> { [INFO] [stderr] 302 | | EntrySlice { [INFO] [stderr] 303 | | max_chunk_size: max_chunk_size, [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/entry.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / let result: Result; [INFO] [stderr] 332 | | if to_read == 0 { [INFO] [stderr] 333 | | result = Ok(0usize); [INFO] [stderr] 334 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 354 | | result = Ok(read); [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if to_read == 0 { Ok(0usize) } else { ..; Ok(read) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/entry.rs:376:10 [INFO] [stderr] | [INFO] [stderr] 376 | if &size < self.minimum_standard_stream_size.as_ref().unwrap() { [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/entry.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `entries` [INFO] [stderr] --> src/entry.rs:405:14 [INFO] [stderr] | [INFO] [stderr] 405 | for i in 0 .. entries.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 405 | for (i, ) in entries.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/entry.rs:429:44 [INFO] [stderr] | [INFO] [stderr] 429 | fn get_short_stream_slices(&self, chain: &std::vec::Vec, size: usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/entry.rs:450:38 [INFO] [stderr] | [INFO] [stderr] 450 | fn get_stream_slices(&self, chain: &std::vec::Vec, size: usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/sector.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / let body_size: usize; [INFO] [stderr] 27 | | if self.body.is_some() { [INFO] [stderr] 28 | | body_size = self.body.as_ref().unwrap().len(); [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | body_size = 0; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let body_size = if self.body.is_some() { self.body.as_ref().unwrap().len() } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/ole.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(&[0x0u8; 16] == &ole.uid[..], true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!([0x0u8; 16] == ole.uid[..], true); [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | if &super::constants::IDENTIFIER != &header[0..8] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 34 | if super::constants::IDENTIFIER != header[0..8] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | if &header[28..30] == &super::constants::BIG_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 48 | if header[28..30] == super::constants::BIG_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:51:11 [INFO] [stderr] | [INFO] [stderr] 51 | &header[28..30] != &super::constants::LITTLE_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | header[28..30] != super::constants::LITTLE_ENDIAN_IDENTIFIER { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | if &header[68..72] != &super::constants::END_OF_CHAIN_SECID { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 114 | if header[68..72] != super::constants::END_OF_CHAIN_SECID { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/header.rs:174:8 [INFO] [stderr] | [INFO] [stderr] 174 | if !self.body.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.body.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/header.rs:190:30 [INFO] [stderr] | [INFO] [stderr] 190 | while i < max_sec_ids && &buffer[offset .. offset + 4] [INFO] [stderr] | ______________________________^ [INFO] [stderr] 191 | | != &super::constants::FREE_SECID { [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 190 | while i < max_sec_ids && buffer[offset .. offset + 4] [INFO] [stderr] 191 | != super::constants::FREE_SECID { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 38 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | result += (buf[i] as u32) * 256u32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 50 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | result += (buf[i] as i32) * 256i32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | result += (buf[i] as u64) * 256u64.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sat.rs:27:8 [INFO] [stderr] | [INFO] [stderr] 27 | if self.msat.as_ref().unwrap().len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.msat.as_ref().unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `entry::Entry` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/entry.rs:159:1 [INFO] [stderr] | [INFO] [stderr] 159 | / impl Entry { [INFO] [stderr] 160 | | [INFO] [stderr] 161 | | fn from_slice(sector: &[u8], dir_id: u32) [INFO] [stderr] 162 | | -> Result { [INFO] [stderr] ... | [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/entry.rs:193:7 [INFO] [stderr] | [INFO] [stderr] 193 | i = i + 2; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: item `entry::EntrySlice<'s>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/entry.rs:300:1 [INFO] [stderr] | [INFO] [stderr] 300 | / impl<'s> EntrySlice<'s> { [INFO] [stderr] 301 | | fn new(max_chunk_size: usize, size: usize) -> EntrySlice<'s> { [INFO] [stderr] 302 | | EntrySlice { [INFO] [stderr] 303 | | max_chunk_size: max_chunk_size, [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/entry.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | / let result: Result; [INFO] [stderr] 332 | | if to_read == 0 { [INFO] [stderr] 333 | | result = Ok(0usize); [INFO] [stderr] 334 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 354 | | result = Ok(read); [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let result = if to_read == 0 { Ok(0usize) } else { ..; Ok(read) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/entry.rs:376:10 [INFO] [stderr] | [INFO] [stderr] 376 | if &size < self.minimum_standard_stream_size.as_ref().unwrap() { [INFO] [stderr] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/entry.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `entries` [INFO] [stderr] --> src/entry.rs:405:14 [INFO] [stderr] | [INFO] [stderr] 405 | for i in 0 .. entries.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 405 | for (i, ) in entries.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/entry.rs:429:44 [INFO] [stderr] | [INFO] [stderr] 429 | fn get_short_stream_slices(&self, chain: &std::vec::Vec, size: usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/entry.rs:450:38 [INFO] [stderr] | [INFO] [stderr] 450 | fn get_stream_slices(&self, chain: &std::vec::Vec, size: usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/sector.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / let body_size: usize; [INFO] [stderr] 27 | | if self.body.is_some() { [INFO] [stderr] 28 | | body_size = self.body.as_ref().unwrap().len(); [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | body_size = 0; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let body_size = if self.body.is_some() { self.body.as_ref().unwrap().len() } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "afb3327f62bdb8c235f9bff94d16676bbb07342fc610edcc59ac72255e54810b"` [INFO] running `"docker" "rm" "-f" "afb3327f62bdb8c235f9bff94d16676bbb07342fc610edcc59ac72255e54810b"` [INFO] [stdout] afb3327f62bdb8c235f9bff94d16676bbb07342fc610edcc59ac72255e54810b