[INFO] crate obj 0.9.0 is already in cache [INFO] extracting crate obj 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/obj/0.9.0 [INFO] extracting crate obj 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/obj/0.9.0 [INFO] validating manifest of obj-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of obj-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing obj-0.9.0 [INFO] finished frobbing obj-0.9.0 [INFO] frobbed toml for obj-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/obj/0.9.0/Cargo.toml [INFO] started frobbing obj-0.9.0 [INFO] finished frobbing obj-0.9.0 [INFO] frobbed toml for obj-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/obj/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting obj-0.9.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/obj/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac79e2ca4cf9233310ef6570b13969285dc7914519774f1f765650c1b34f2dd6 [INFO] running `"docker" "start" "-a" "ac79e2ca4cf9233310ef6570b13969285dc7914519774f1f765650c1b34f2dd6"` [INFO] [stderr] Checking obj v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Object { name: name, groups: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mtl.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | Object { name: name, groups: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mtl.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/obj.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | / match materials.get(&mat.name) { [INFO] [stderr] 170 | | Some(newmat) => *mat = newmat.clone(), [INFO] [stderr] 171 | | None => {} [INFO] [stderr] 172 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(newmat) = materials.get(&mat.name) { *mat = newmat.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/obj.rs:361:43 [INFO] [stderr] | [INFO] [stderr] 361 | if !other.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/obj.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | / match group { [INFO] [stderr] 369 | | Some(g) => object.groups.push(g), [INFO] [stderr] 370 | | None => (), [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(g) = group { object.groups.push(g) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mtl.rs:239:43 [INFO] [stderr] | [INFO] [stderr] 239 | if !other.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/obj.rs:169:21 [INFO] [stderr] | [INFO] [stderr] 169 | / match materials.get(&mat.name) { [INFO] [stderr] 170 | | Some(newmat) => *mat = newmat.clone(), [INFO] [stderr] 171 | | None => {} [INFO] [stderr] 172 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Some(newmat) = materials.get(&mat.name) { *mat = newmat.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/obj.rs:361:43 [INFO] [stderr] | [INFO] [stderr] 361 | if !other.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/obj.rs:368:9 [INFO] [stderr] | [INFO] [stderr] 368 | / match group { [INFO] [stderr] 369 | | Some(g) => object.groups.push(g), [INFO] [stderr] 370 | | None => (), [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(g) = group { object.groups.push(g) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/mtl.rs:239:43 [INFO] [stderr] | [INFO] [stderr] 239 | if !other.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.68s [INFO] running `"docker" "inspect" "ac79e2ca4cf9233310ef6570b13969285dc7914519774f1f765650c1b34f2dd6"` [INFO] running `"docker" "rm" "-f" "ac79e2ca4cf9233310ef6570b13969285dc7914519774f1f765650c1b34f2dd6"` [INFO] [stdout] ac79e2ca4cf9233310ef6570b13969285dc7914519774f1f765650c1b34f2dd6