[INFO] crate nzsc_single_player 0.5.1 is already in cache
[INFO] extracting crate nzsc_single_player 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/nzsc_single_player/0.5.1
[INFO] extracting crate nzsc_single_player 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc_single_player/0.5.1
[INFO] validating manifest of nzsc_single_player-0.5.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nzsc_single_player-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nzsc_single_player-0.5.1
[INFO] finished frobbing nzsc_single_player-0.5.1
[INFO] frobbed toml for nzsc_single_player-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/nzsc_single_player/0.5.1/Cargo.toml
[INFO] started frobbing nzsc_single_player-0.5.1
[INFO] finished frobbing nzsc_single_player-0.5.1
[INFO] frobbed toml for nzsc_single_player-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc_single_player/0.5.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nzsc_single_player-0.5.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nzsc_single_player/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] accf28214d00e081c3d334f49cf2584df52f93a425e6c538ead190d7bc8c0388
[INFO] running `"docker" "start" "-a" "accf28214d00e081c3d334f49cf2584df52f93a425e6c538ead190d7bc8c0388"`
[INFO] [stderr]     Checking nzsc_single_player v0.5.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             return 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             return 0;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/single_player_game.rs:61:54
[INFO] [stderr]    |
[INFO] [stderr] 61 |         if let Phase::CharacterChoosing { ref human, computer: _ }  = self.phase {
[INFO] [stderr]    |                                                      ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `CharacterChoosing { ref human, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/single_player_game.rs:465:32
[INFO] [stderr]     |
[INFO] [stderr] 465 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 466 | |                             if human.destroyed_moves.contains(&selected_human_move) {
[INFO] [stderr] 467 | |                                 if SINGLE_USE_MOVES.contains(&selected_human_move) {
[INFO] [stderr] 468 | |                                     penalize_human(4, io::Notification::MoveSingleUsePenalty {
[INFO] [stderr] ...   |
[INFO] [stderr] 495 | |                             }
[INFO] [stderr] 496 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 465 |                         } else if human.destroyed_moves.contains(&selected_human_move) {
[INFO] [stderr] 466 |     if SINGLE_USE_MOVES.contains(&selected_human_move) {
[INFO] [stderr] 467 |         penalize_human(4, io::Notification::MoveSingleUsePenalty {
[INFO] [stderr] 468 |             attempted_move: selected_human_move,
[INFO] [stderr] 469 |         }, human, computer, self)
[INFO] [stderr] 470 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:84:13
[INFO] [stderr]    |
[INFO] [stderr] 84 |             return 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/players.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             return 0;
[INFO] [stderr]    |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |             return 1;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/players.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             return 0;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/single_player_game.rs:61:54
[INFO] [stderr]    |
[INFO] [stderr] 61 |         if let Phase::CharacterChoosing { ref human, computer: _ }  = self.phase {
[INFO] [stderr]    |                                                      ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `CharacterChoosing { ref human, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/single_player_game.rs:465:32
[INFO] [stderr]     |
[INFO] [stderr] 465 |                           } else {
[INFO] [stderr]     |  ________________________________^
[INFO] [stderr] 466 | |                             if human.destroyed_moves.contains(&selected_human_move) {
[INFO] [stderr] 467 | |                                 if SINGLE_USE_MOVES.contains(&selected_human_move) {
[INFO] [stderr] 468 | |                                     penalize_human(4, io::Notification::MoveSingleUsePenalty {
[INFO] [stderr] ...   |
[INFO] [stderr] 495 | |                             }
[INFO] [stderr] 496 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 465 |                         } else if human.destroyed_moves.contains(&selected_human_move) {
[INFO] [stderr] 466 |     if SINGLE_USE_MOVES.contains(&selected_human_move) {
[INFO] [stderr] 467 |         penalize_human(4, io::Notification::MoveSingleUsePenalty {
[INFO] [stderr] 468 |             attempted_move: selected_human_move,
[INFO] [stderr] 469 |         }, human, computer, self)
[INFO] [stderr] 470 |     } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/moves.rs:83:22
[INFO] [stderr]     |
[INFO] [stderr] 83  |           let string = match self {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 84  | |             &Move::Kick => "Kick",
[INFO] [stderr] 85  | |             &Move::NinjaSword => "Ninja Sword",
[INFO] [stderr] 86  | |             &Move::Nunchucks => "Nunchucks",
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |             &Move::BigHairyDeal => "Big Hairy Deal"
[INFO] [stderr] 112 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 83  |         let string = match *self {
[INFO] [stderr] 84  |             Move::Kick => "Kick",
[INFO] [stderr] 85  |             Move::NinjaSword => "Ninja Sword",
[INFO] [stderr] 86  |             Move::Nunchucks => "Nunchucks",
[INFO] [stderr] 87  |             Move::ShadowFireball => "Shadow Fireball",
[INFO] [stderr] 88  |             Move::ShadowSlip => "Shadow Slip",
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/characters.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |           let string = match self {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 88 | |             &Character::Ninja => "Ninja",
[INFO] [stderr] 89 | |             &Character::Zombie => "Zombie",
[INFO] [stderr] 90 | |             &Character::Samurai => "Samurai",
[INFO] [stderr] 91 | |             &Character::Clown => "Clown"
[INFO] [stderr] 92 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let string = match *self {
[INFO] [stderr] 88 |             Character::Ninja => "Ninja",
[INFO] [stderr] 89 |             Character::Zombie => "Zombie",
[INFO] [stderr] 90 |             Character::Samurai => "Samurai",
[INFO] [stderr] 91 |             Character::Clown => "Clown"
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/boosters.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |           let string = match self {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 81 | |             &Booster::Shadow => "Shadow",
[INFO] [stderr] 82 | |             &Booster::Speedy => "Speedy",
[INFO] [stderr] 83 | |             &Booster::Regenerative => "Regenerative",
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |             &Booster::None => "No Booster"
[INFO] [stderr] 90 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |         let string = match *self {
[INFO] [stderr] 81 |             Booster::Shadow => "Shadow",
[INFO] [stderr] 82 |             Booster::Speedy => "Speedy",
[INFO] [stderr] 83 |             Booster::Regenerative => "Regenerative",
[INFO] [stderr] 84 |             Booster::ZombieCorps => "Zombie Corps",
[INFO] [stderr] 85 |             Booster::Atlas => "Atlas",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/outcomes.rs:49:21
[INFO] [stderr]    |
[INFO] [stderr] 49 |             let a = a.to_u8() as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u16::from(a.to_u8())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/outcomes.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |             let b = b.to_u8() as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u16::from(b.to_u8())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `streaks::MoveStreak`
[INFO] [stderr]   --> src/streaks.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> Self {
[INFO] [stderr] 24 | |         Self {
[INFO] [stderr] 25 | |             repeated_move: None,
[INFO] [stderr] 26 | |             times: 0
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `streaks::CharacterStreak`
[INFO] [stderr]   --> src/streaks.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     pub fn new() -> Self {
[INFO] [stderr] 48 | |         Self {
[INFO] [stderr] 49 | |             repeated_character: None,
[INFO] [stderr] 50 | |             times: 0
[INFO] [stderr] 51 | |         }
[INFO] [stderr] 52 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `players::CharacterlessPlayer`
[INFO] [stderr]   --> src/players.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 | /     pub fn new() -> CharacterlessPlayer {
[INFO] [stderr] 35 | |         CharacterlessPlayer {
[INFO] [stderr] 36 | |             points: 0,
[INFO] [stderr] 37 | |             waits: 4,
[INFO] [stderr] 38 | |             character_streak: CharacterStreak::new(),
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 33 | impl Default for players::CharacterlessPlayer {
[INFO] [stderr] 34 |     fn default() -> Self {
[INFO] [stderr] 35 |         Self::new()
[INFO] [stderr] 36 |     }
[INFO] [stderr] 37 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/prfg.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn next(&mut self) -> f64 {
[INFO] [stderr] 16 | |         // Calculate random u32.
[INFO] [stderr] 17 | |         // https://en.wikipedia.org/wiki/Xorshift
[INFO] [stderr] 18 | |         let mut x = self.state;
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         (x >> 16) as f64 / 65536.0
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/prfg.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (x >> 16) as f64 / 65536.0
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: try: `f64::from(x >> 16)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/moves.rs:83:22
[INFO] [stderr]     |
[INFO] [stderr] 83  |           let string = match self {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 84  | |             &Move::Kick => "Kick",
[INFO] [stderr] 85  | |             &Move::NinjaSword => "Ninja Sword",
[INFO] [stderr] 86  | |             &Move::Nunchucks => "Nunchucks",
[INFO] [stderr] ...   |
[INFO] [stderr] 111 | |             &Move::BigHairyDeal => "Big Hairy Deal"
[INFO] [stderr] 112 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 83  |         let string = match *self {
[INFO] [stderr] 84  |             Move::Kick => "Kick",
[INFO] [stderr] 85  |             Move::NinjaSword => "Ninja Sword",
[INFO] [stderr] 86  |             Move::Nunchucks => "Nunchucks",
[INFO] [stderr] 87  |             Move::ShadowFireball => "Shadow Fireball",
[INFO] [stderr] 88  |             Move::ShadowSlip => "Shadow Slip",
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/characters.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |           let string = match self {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 88 | |             &Character::Ninja => "Ninja",
[INFO] [stderr] 89 | |             &Character::Zombie => "Zombie",
[INFO] [stderr] 90 | |             &Character::Samurai => "Samurai",
[INFO] [stderr] 91 | |             &Character::Clown => "Clown"
[INFO] [stderr] 92 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let string = match *self {
[INFO] [stderr] 88 |             Character::Ninja => "Ninja",
[INFO] [stderr] 89 |             Character::Zombie => "Zombie",
[INFO] [stderr] 90 |             Character::Samurai => "Samurai",
[INFO] [stderr] 91 |             Character::Clown => "Clown"
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/boosters.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 |           let string = match self {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 81 | |             &Booster::Shadow => "Shadow",
[INFO] [stderr] 82 | |             &Booster::Speedy => "Speedy",
[INFO] [stderr] 83 | |             &Booster::Regenerative => "Regenerative",
[INFO] [stderr] ...  |
[INFO] [stderr] 89 | |             &Booster::None => "No Booster"
[INFO] [stderr] 90 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 80 |         let string = match *self {
[INFO] [stderr] 81 |             Booster::Shadow => "Shadow",
[INFO] [stderr] 82 |             Booster::Speedy => "Speedy",
[INFO] [stderr] 83 |             Booster::Regenerative => "Regenerative",
[INFO] [stderr] 84 |             Booster::ZombieCorps => "Zombie Corps",
[INFO] [stderr] 85 |             Booster::Atlas => "Atlas",
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/outcomes.rs:49:21
[INFO] [stderr]    |
[INFO] [stderr] 49 |             let a = a.to_u8() as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u16::from(a.to_u8())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/outcomes.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |             let b = b.to_u8() as u16;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try: `u16::from(b.to_u8())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `streaks::MoveStreak`
[INFO] [stderr]   --> src/streaks.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> Self {
[INFO] [stderr] 24 | |         Self {
[INFO] [stderr] 25 | |             repeated_move: None,
[INFO] [stderr] 26 | |             times: 0
[INFO] [stderr] 27 | |         }
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `streaks::CharacterStreak`
[INFO] [stderr]   --> src/streaks.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     pub fn new() -> Self {
[INFO] [stderr] 48 | |         Self {
[INFO] [stderr] 49 | |             repeated_character: None,
[INFO] [stderr] 50 | |             times: 0
[INFO] [stderr] 51 | |         }
[INFO] [stderr] 52 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `players::CharacterlessPlayer`
[INFO] [stderr]   --> src/players.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 | /     pub fn new() -> CharacterlessPlayer {
[INFO] [stderr] 35 | |         CharacterlessPlayer {
[INFO] [stderr] 36 | |             points: 0,
[INFO] [stderr] 37 | |             waits: 4,
[INFO] [stderr] 38 | |             character_streak: CharacterStreak::new(),
[INFO] [stderr] 39 | |         }
[INFO] [stderr] 40 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 33 | impl Default for players::CharacterlessPlayer {
[INFO] [stderr] 34 |     fn default() -> Self {
[INFO] [stderr] 35 |         Self::new()
[INFO] [stderr] 36 |     }
[INFO] [stderr] 37 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/prfg.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn next(&mut self) -> f64 {
[INFO] [stderr] 16 | |         // Calculate random u32.
[INFO] [stderr] 17 | |         // https://en.wikipedia.org/wiki/Xorshift
[INFO] [stderr] 18 | |         let mut x = self.state;
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |         (x >> 16) as f64 / 65536.0
[INFO] [stderr] 28 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/prfg.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |         (x >> 16) as f64 / 65536.0
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: try: `f64::from(x >> 16)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.62s
[INFO] running `"docker" "inspect" "accf28214d00e081c3d334f49cf2584df52f93a425e6c538ead190d7bc8c0388"`
[INFO] running `"docker" "rm" "-f" "accf28214d00e081c3d334f49cf2584df52f93a425e6c538ead190d7bc8c0388"`
[INFO] [stdout] accf28214d00e081c3d334f49cf2584df52f93a425e6c538ead190d7bc8c0388