[INFO] crate nss-certdata-parser 0.6.2 is already in cache [INFO] extracting crate nss-certdata-parser 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/nss-certdata-parser/0.6.2 [INFO] extracting crate nss-certdata-parser 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nss-certdata-parser/0.6.2 [INFO] validating manifest of nss-certdata-parser-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nss-certdata-parser-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nss-certdata-parser-0.6.2 [INFO] finished frobbing nss-certdata-parser-0.6.2 [INFO] frobbed toml for nss-certdata-parser-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/nss-certdata-parser/0.6.2/Cargo.toml [INFO] started frobbing nss-certdata-parser-0.6.2 [INFO] finished frobbing nss-certdata-parser-0.6.2 [INFO] frobbed toml for nss-certdata-parser-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nss-certdata-parser/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nss-certdata-parser-0.6.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nss-certdata-parser/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32ea94b8472523521c9bcf978ca3e47d05a2659a73cd6a183d0a45a81fbde281 [INFO] running `"docker" "start" "-a" "32ea94b8472523521c9bcf978ca3e47d05a2659a73cd6a183d0a45a81fbde281"` [INFO] [stderr] Checking nss-certdata-parser v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collect.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | certs: certs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `certs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collect.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | trusts: trusts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `trusts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:245:22 [INFO] [stderr] | [INFO] [stderr] 245 | ObjectIter { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collect.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | certs: certs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `certs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collect.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | trusts: trusts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `trusts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | src: src, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:245:22 [INFO] [stderr] | [INFO] [stderr] 245 | ObjectIter { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/structured.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/collect.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn from_iter(iter: I) -> Result [INFO] [stderr] 29 | | where I: IntoIterator> [INFO] [stderr] 30 | | { [INFO] [stderr] 31 | | let mut certbuf = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reader.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | Err(Error::ParseError(ParseError{ [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 112 | | byte_offset: off + (seen as Offset), [INFO] [stderr] 113 | | buf_left: rest.len(), [INFO] [stderr] 114 | | what: what, [INFO] [stderr] 115 | | }.into())) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 111 | Err(Error::ParseError(ParseError{ [INFO] [stderr] 112 | byte_offset: off + (seen as Offset), [INFO] [stderr] 113 | buf_left: rest.len(), [INFO] [stderr] 114 | what: what, [INFO] [stderr] 115 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/structured.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 69 | | match s { [INFO] [stderr] 70 | | "CKT_NSS_NOT_TRUSTED" => Some(TrustLevel::Distrust), [INFO] [stderr] 71 | | "CKT_NSS_MUST_VERIFY_TRUST" => Some(TrustLevel::MustVerify), [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/attr_cat.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/attr_cat.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/collect.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn from_iter(iter: I) -> Result [INFO] [stderr] 29 | | where I: IntoIterator> [INFO] [stderr] 30 | | { [INFO] [stderr] 31 | | let mut certbuf = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 46 | | }) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reader.rs:111:43 [INFO] [stderr] | [INFO] [stderr] 111 | Err(Error::ParseError(ParseError{ [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 112 | | byte_offset: off + (seen as Offset), [INFO] [stderr] 113 | | buf_left: rest.len(), [INFO] [stderr] 114 | | what: what, [INFO] [stderr] 115 | | }.into())) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 111 | Err(Error::ParseError(ParseError{ [INFO] [stderr] 112 | byte_offset: off + (seen as Offset), [INFO] [stderr] 113 | buf_left: rest.len(), [INFO] [stderr] 114 | what: what, [INFO] [stderr] 115 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/structured.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 69 | | match s { [INFO] [stderr] 70 | | "CKT_NSS_NOT_TRUSTED" => Some(TrustLevel::Distrust), [INFO] [stderr] 71 | | "CKT_NSS_MUST_VERIFY_TRUST" => Some(TrustLevel::MustVerify), [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.10s [INFO] running `"docker" "inspect" "32ea94b8472523521c9bcf978ca3e47d05a2659a73cd6a183d0a45a81fbde281"` [INFO] running `"docker" "rm" "-f" "32ea94b8472523521c9bcf978ca3e47d05a2659a73cd6a183d0a45a81fbde281"` [INFO] [stdout] 32ea94b8472523521c9bcf978ca3e47d05a2659a73cd6a183d0a45a81fbde281