[INFO] crate nps 0.1.0 is already in cache [INFO] extracting crate nps 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nps/0.1.0 [INFO] extracting crate nps 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nps/0.1.0 [INFO] validating manifest of nps-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nps-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nps-0.1.0 [INFO] finished frobbing nps-0.1.0 [INFO] frobbed toml for nps-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nps/0.1.0/Cargo.toml [INFO] started frobbing nps-0.1.0 [INFO] finished frobbing nps-0.1.0 [INFO] frobbed toml for nps-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nps/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nps-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nps/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 063a3a94bd9bd7bdf22a4e041b68f8cd5d96b7cf4f401dd89e929d08837fc90e [INFO] running `"docker" "start" "-a" "063a3a94bd9bd7bdf22a4e041b68f8cd5d96b7cf4f401dd89e929d08837fc90e"` [INFO] [stderr] Checking nps v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rating.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Rating {value: value, comment: None} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rating.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | Rating {value: value, comment: Some(c)} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | promoters: promoters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `promoters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | detractors: detractors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `detractors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | passive: passive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `passive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | histogram: histogram [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rating.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | Rating {value: value, comment: None} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rating.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | Rating {value: value, comment: Some(c)} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | promoters: promoters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `promoters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | detractors: detractors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `detractors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | passive: passive, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `passive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/summary.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | histogram: histogram [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/summary.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | delta as f64 / number_of_ratings as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/summary.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | delta as f64 / number_of_ratings as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(number_of_ratings)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/rating.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let b = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/summary.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | delta as f64 / number_of_ratings as f64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(delta)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/summary.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | delta as f64 / number_of_ratings as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(number_of_ratings)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/summary.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | assert!(s.score() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(s.score() - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/summary.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | assert!(s.score() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/summary.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | assert!(s.score() == -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(s.score() - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/summary.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | assert!(s.score() == -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nps`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "063a3a94bd9bd7bdf22a4e041b68f8cd5d96b7cf4f401dd89e929d08837fc90e"` [INFO] running `"docker" "rm" "-f" "063a3a94bd9bd7bdf22a4e041b68f8cd5d96b7cf4f401dd89e929d08837fc90e"` [INFO] [stdout] 063a3a94bd9bd7bdf22a4e041b68f8cd5d96b7cf4f401dd89e929d08837fc90e