[INFO] crate novaxml 0.1.0 is already in cache [INFO] extracting crate novaxml 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/novaxml/0.1.0 [INFO] extracting crate novaxml 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/novaxml/0.1.0 [INFO] validating manifest of novaxml-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of novaxml-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing novaxml-0.1.0 [INFO] finished frobbing novaxml-0.1.0 [INFO] frobbed toml for novaxml-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/novaxml/0.1.0/Cargo.toml [INFO] started frobbing novaxml-0.1.0 [INFO] finished frobbing novaxml-0.1.0 [INFO] frobbed toml for novaxml-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/novaxml/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting novaxml-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/novaxml/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7f9416064e445175ba3d6ae621322345b097646fc6990e806e46cc76830bc8a [INFO] running `"docker" "start" "-a" "a7f9416064e445175ba3d6ae621322345b097646fc6990e806e46cc76830bc8a"` [INFO] [stderr] Checking novaxml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/parser.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | (Attribute::new(&n, &v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | (Attribute::new(&n, &v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / if last.len() == 2 { [INFO] [stderr] 67 | | if last[0] == '-' && last[1] == '-' && c == '>' { [INFO] [stderr] 68 | | reading_comment = false; [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if last.len() == 2 && last[0] == '-' && last[1] == '-' && c == '>' { [INFO] [stderr] 67 | reading_comment = false; [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | / if last.len() == 2 { [INFO] [stderr] 216 | | if last[0] == '<' && last[1] == '!' { [INFO] [stderr] 217 | | tokens.push(Token::MDLeft); [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | if last.len() == 2 && last[0] == '<' && last[1] == '!' { [INFO] [stderr] 216 | tokens.push(Token::MDLeft); [INFO] [stderr] 217 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / if !last.is_empty() { [INFO] [stderr] 222 | | if last[0] == '<' { [INFO] [stderr] 223 | | tokens.push(Token::Left); [INFO] [stderr] 224 | | last.clear(); [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | if !last.is_empty() && last[0] == '<' { [INFO] [stderr] 222 | tokens.push(Token::Left); [INFO] [stderr] 223 | last.clear(); [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokenizer.rs:240:22 [INFO] [stderr] | [INFO] [stderr] 240 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 241 | | if !acc.is_empty() { [INFO] [stderr] 242 | | tokens.push(Token::Text(acc.clone())); [INFO] [stderr] 243 | | acc.clear(); [INFO] [stderr] 244 | | } [INFO] [stderr] 245 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 240 | else if !acc.is_empty() { [INFO] [stderr] 241 | tokens.push(Token::Text(acc.clone())); [INFO] [stderr] 242 | acc.clear(); [INFO] [stderr] 243 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/nodes.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/nodes.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | if self.empty == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:219:29 [INFO] [stderr] | [INFO] [stderr] 219 | p: &ParseState) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ParseState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn invalid_token(last: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | s: &char) -> Result, String> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tokenizer.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn tokenize(s: &str) -> Result, String> { [INFO] [stderr] 34 | | let s = strip(s); [INFO] [stderr] 35 | | let mut acc = String::new(); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 249 | | Ok(tokens) [INFO] [stderr] 250 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Document` [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Document { [INFO] [stderr] 17 | | Document { [INFO] [stderr] 18 | | root: Element::new("root"), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for Document { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/parser.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | (Attribute::new(&n, &v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/parser.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | (Attribute::new(&n, &v))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | / if last.len() == 2 { [INFO] [stderr] 67 | | if last[0] == '-' && last[1] == '-' && c == '>' { [INFO] [stderr] 68 | | reading_comment = false; [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if last.len() == 2 && last[0] == '-' && last[1] == '-' && c == '>' { [INFO] [stderr] 67 | reading_comment = false; [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | / if last.len() == 2 { [INFO] [stderr] 216 | | if last[0] == '<' && last[1] == '!' { [INFO] [stderr] 217 | | tokens.push(Token::MDLeft); [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 215 | if last.len() == 2 && last[0] == '<' && last[1] == '!' { [INFO] [stderr] 216 | tokens.push(Token::MDLeft); [INFO] [stderr] 217 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | / if !last.is_empty() { [INFO] [stderr] 222 | | if last[0] == '<' { [INFO] [stderr] 223 | | tokens.push(Token::Left); [INFO] [stderr] 224 | | last.clear(); [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | if !last.is_empty() && last[0] == '<' { [INFO] [stderr] 222 | tokens.push(Token::Left); [INFO] [stderr] 223 | last.clear(); [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tokenizer.rs:240:22 [INFO] [stderr] | [INFO] [stderr] 240 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 241 | | if !acc.is_empty() { [INFO] [stderr] 242 | | tokens.push(Token::Text(acc.clone())); [INFO] [stderr] 243 | | acc.clear(); [INFO] [stderr] 244 | | } [INFO] [stderr] 245 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 240 | else if !acc.is_empty() { [INFO] [stderr] 241 | tokens.push(Token::Text(acc.clone())); [INFO] [stderr] 242 | acc.clear(); [INFO] [stderr] 243 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/nodes.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn is_empty(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/nodes.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | if self.empty == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.empty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser.rs:207:34 [INFO] [stderr] | [INFO] [stderr] 207 | state_stack.push(current_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:219:29 [INFO] [stderr] | [INFO] [stderr] 219 | p: &ParseState) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ParseState` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn invalid_token(last: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tokenizer.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | s: &char) -> Result, String> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tokenizer.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn tokenize(s: &str) -> Result, String> { [INFO] [stderr] 34 | | let s = strip(s); [INFO] [stderr] 35 | | let mut acc = String::new(); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 249 | | Ok(tokens) [INFO] [stderr] 250 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Document` [INFO] [stderr] --> src/lib.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Document { [INFO] [stderr] 17 | | Document { [INFO] [stderr] 18 | | root: Element::new("root"), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for Document { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "a7f9416064e445175ba3d6ae621322345b097646fc6990e806e46cc76830bc8a"` [INFO] running `"docker" "rm" "-f" "a7f9416064e445175ba3d6ae621322345b097646fc6990e806e46cc76830bc8a"` [INFO] [stdout] a7f9416064e445175ba3d6ae621322345b097646fc6990e806e46cc76830bc8a