[INFO] crate non-dominated-sort 0.2.0 is already in cache [INFO] extracting crate non-dominated-sort 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/non-dominated-sort/0.2.0 [INFO] extracting crate non-dominated-sort 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/non-dominated-sort/0.2.0 [INFO] validating manifest of non-dominated-sort-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of non-dominated-sort-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing non-dominated-sort-0.2.0 [INFO] finished frobbing non-dominated-sort-0.2.0 [INFO] frobbed toml for non-dominated-sort-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/non-dominated-sort/0.2.0/Cargo.toml [INFO] started frobbing non-dominated-sort-0.2.0 [INFO] finished frobbing non-dominated-sort-0.2.0 [INFO] frobbed toml for non-dominated-sort-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/non-dominated-sort/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting non-dominated-sort-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/non-dominated-sort/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5285b8840ec8993a9061b5374224262e566b07baa089bb20942ab376f32eea30 [INFO] running `"docker" "start" "-a" "5285b8840ec8993a9061b5374224262e566b07baa089bb20942ab376f32eea30"` [INFO] [stderr] Checking non-dominated-sort v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/non_dominated_sort.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return fronts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `fronts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/non_dominated_sort.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | for mid in 1..entries.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=entries.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/non_dominated_sort.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | debug_assert!(front_slice.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!front_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/non_dominated_sort.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | self.into_iter().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/non_dominated_sort.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | return fronts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `fronts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/non_dominated_sort.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | for mid in 1..entries.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=entries.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/non_dominated_sort.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | debug_assert!(front_slice.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!front_slice.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/non_dominated_sort.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | self.into_iter().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/test_helper_domination.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | } else if a.0 <= b.0 && a.1 < b.1 { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 20 | | Ordering::Less [INFO] [stderr] 21 | | } else if a.0 > b.0 && a.1 >= b.1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/test_helper_domination.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | if a.0 < b.0 && a.1 <= b.1 { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 18 | | Ordering::Less [INFO] [stderr] 19 | | } else if a.0 <= b.0 && a.1 < b.1 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `non-dominated-sort`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5285b8840ec8993a9061b5374224262e566b07baa089bb20942ab376f32eea30"` [INFO] running `"docker" "rm" "-f" "5285b8840ec8993a9061b5374224262e566b07baa089bb20942ab376f32eea30"` [INFO] [stdout] 5285b8840ec8993a9061b5374224262e566b07baa089bb20942ab376f32eea30