[INFO] crate ng-log 0.1.1 is already in cache [INFO] extracting crate ng-log 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/ng-log/0.1.1 [INFO] extracting crate ng-log 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ng-log/0.1.1 [INFO] validating manifest of ng-log-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ng-log-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ng-log-0.1.1 [INFO] finished frobbing ng-log-0.1.1 [INFO] frobbed toml for ng-log-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/ng-log/0.1.1/Cargo.toml [INFO] started frobbing ng-log-0.1.1 [INFO] finished frobbing ng-log-0.1.1 [INFO] frobbed toml for ng-log-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ng-log/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ng-log-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ng-log/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6f25eeb1ecd40a04316ba8085d3c9a6bcb66cfbe6f84ee0b3fbf3ddd7cdec45 [INFO] running `"docker" "start" "-a" "a6f25eeb1ecd40a04316ba8085d3c9a6bcb66cfbe6f84ee0b3fbf3ddd7cdec45"` [INFO] [stderr] Checking ng-log v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:4 [INFO] [stderr] | [INFO] [stderr] 164 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:164:4 [INFO] [stderr] | [INFO] [stderr] 164 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:180:4 [INFO] [stderr] | [INFO] [stderr] 180 | return Err(IoError::new(IoErrorKind::InvalidData, "Bad event string")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IoError::new(IoErrorKind::InvalidData, "Bad event string"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:180:4 [INFO] [stderr] | [INFO] [stderr] 180 | return Err(IoError::new(IoErrorKind::InvalidData, "Bad event string")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IoError::new(IoErrorKind::InvalidData, "Bad event string"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:140:24 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn from_string(s: &String) -> IoResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | s = s + &v.to_string() + &"\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:177:24 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn from_string(s: &String) -> IoResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:178:52 [INFO] [stderr] | [INFO] [stderr] 178 | let mut columns: Vec = s.split('\t').map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | s = s + &"\t" + &v; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | s = s + &"\t" + &self.event_id; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:208:8 [INFO] [stderr] | [INFO] [stderr] 208 | s = s + &"\t" + &v; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:140:24 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn from_string(s: &String) -> IoResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | s = s + &v.to_string() + &"\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:177:24 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn from_string(s: &String) -> IoResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:178:52 [INFO] [stderr] | [INFO] [stderr] 178 | let mut columns: Vec = s.split('\t').map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | s = s + &"\t" + &v; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:206:7 [INFO] [stderr] | [INFO] [stderr] 206 | s = s + &"\t" + &self.event_id; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:208:8 [INFO] [stderr] | [INFO] [stderr] 208 | s = s + &"\t" + &v; [INFO] [stderr] | ^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\t"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "a6f25eeb1ecd40a04316ba8085d3c9a6bcb66cfbe6f84ee0b3fbf3ddd7cdec45"` [INFO] running `"docker" "rm" "-f" "a6f25eeb1ecd40a04316ba8085d3c9a6bcb66cfbe6f84ee0b3fbf3ddd7cdec45"` [INFO] [stdout] a6f25eeb1ecd40a04316ba8085d3c9a6bcb66cfbe6f84ee0b3fbf3ddd7cdec45