[INFO] crate napi 0.1.1 is already in cache [INFO] extracting crate napi 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/napi/0.1.1 [INFO] extracting crate napi 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/napi/0.1.1 [INFO] validating manifest of napi-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of napi-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing napi-0.1.1 [INFO] finished frobbing napi-0.1.1 [INFO] frobbed toml for napi-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/napi/0.1.1/Cargo.toml [INFO] started frobbing napi-0.1.1 [INFO] finished frobbing napi-0.1.1 [INFO] frobbed toml for napi-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/napi/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting napi-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/napi/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74e1cb1451d70d9cb1d41febb066ee82649b8116ed45055fdf2fd0923ce34392 [INFO] running `"docker" "start" "-a" "74e1cb1451d70d9cb1d41febb066ee82649b8116ed45055fdf2fd0923ce34392"` [INFO] [stderr] Checking napi-sys v0.1.1 [INFO] [stderr] Checking napi v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/args.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | env: &'env NapiEnv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn as_sys_env(&self) -> sys::napi_env { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn handle_status(&self, status: sys::napi_status) -> NapiResult<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/result.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 101 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/result.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 108 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/any.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn with_len(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array_buffer.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | fn new(env: &'env NapiEnv, value: bool) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn truth(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn lie(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/buffer.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/null.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/args.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | env: &'env NapiEnv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_i32(env: &'env NapiEnv, value: i32) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_i64(env: &'env NapiEnv, value: i64) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn from_f64(env: &'env NapiEnv, value: f64) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn as_sys_env(&self) -> sys::napi_env { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn handle_status(&self, status: sys::napi_status) -> NapiResult<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/env.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/object.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/result.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 101 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/result.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(result) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 108 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/any.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_str(env: &'env NapiEnv, value: &str) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn from_latin1(env: &'env NapiEnv, value: &[u8]) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn from_utf16(env: &'env NapiEnv, value: &[u16]) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/undefined.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | env: &'env NapiEnv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn with_len(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/mod.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | fn construct(env: &'env NapiEnv, value: sys::napi_value) -> Self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/array_buffer.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | fn new(env: &'env NapiEnv, value: bool) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn truth(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/boolean.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn lie(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/buffer.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(env: &'env NapiEnv, len: usize) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/null.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_i32(env: &'env NapiEnv, value: i32) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_i64(env: &'env NapiEnv, value: i64) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/number.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn from_f64(env: &'env NapiEnv, value: f64) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/object.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn from_str(env: &'env NapiEnv, value: &str) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn from_latin1(env: &'env NapiEnv, value: &[u8]) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/string.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn from_utf16(env: &'env NapiEnv, value: &[u16]) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/undefined.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(env: &'env NapiEnv) -> NapiResult { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/mod.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | env: &'env NapiEnv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/value/mod.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | fn construct(env: &'env NapiEnv, value: sys::napi_value) -> Self; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `NapiEnv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.44s [INFO] running `"docker" "inspect" "74e1cb1451d70d9cb1d41febb066ee82649b8116ed45055fdf2fd0923ce34392"` [INFO] running `"docker" "rm" "-f" "74e1cb1451d70d9cb1d41febb066ee82649b8116ed45055fdf2fd0923ce34392"` [INFO] [stdout] 74e1cb1451d70d9cb1d41febb066ee82649b8116ed45055fdf2fd0923ce34392