[INFO] crate mut_static 5.0.0 is already in cache [INFO] extracting crate mut_static 5.0.0 into work/ex/clippy-test-run/sources/stable/reg/mut_static/5.0.0 [INFO] extracting crate mut_static 5.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mut_static/5.0.0 [INFO] validating manifest of mut_static-5.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mut_static-5.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mut_static-5.0.0 [INFO] finished frobbing mut_static-5.0.0 [INFO] frobbed toml for mut_static-5.0.0 written to work/ex/clippy-test-run/sources/stable/reg/mut_static/5.0.0/Cargo.toml [INFO] started frobbing mut_static-5.0.0 [INFO] finished frobbing mut_static-5.0.0 [INFO] frobbed toml for mut_static-5.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mut_static/5.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mut_static-5.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mut_static/5.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f3d618a70000bb172670f7bc25eb8a3de1c3817779de027cb0b55c114346954 [INFO] running `"docker" "start" "-a" "0f3d618a70000bb172670f7bc25eb8a3de1c3817779de027cb0b55c114346954"` [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking mut_static v5.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/mod.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | TestStruct{ value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.data.deref_mut() { [INFO] [stderr] 42 | | &mut Some(ref mut some) => some, [INFO] [stderr] 43 | | &mut None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self.data.deref_mut() { [INFO] [stderr] 42 | Some(ref mut some) => some, [INFO] [stderr] 43 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mut_static::MutStatic` [INFO] [stderr] --> src/mut_static.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | MutStatic { [INFO] [stderr] 21 | | data: RwLock::new(None) [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if let &Some(_) = ok.deref() { [INFO] [stderr] 29 | | Ok(true) [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | Ok(false) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(_) = *ok.deref() { [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / if let &None = ok.deref() { [INFO] [stderr] 42 | | return Err(ErrorKind::StaticWasNeverSet.into()) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | if let None = *ok.deref() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/mut_static.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(_) = mem::replace(data_ref, Some(value)) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 60 | | Err(ErrorKind::StaticIsAlreadySet.into()) [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | Ok(()) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &None = ok.deref() { [INFO] [stderr] 70 | | return Err(ErrorKind::StaticWasNeverSet.into()) [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let None = *ok.deref() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_read_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.data.deref() { [INFO] [stderr] 22 | | &Some(ref some) => some, [INFO] [stderr] 23 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self.data.deref() { [INFO] [stderr] 22 | Some(ref some) => some, [INFO] [stderr] 23 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self.data.deref() { [INFO] [stderr] 33 | | &Some(ref some) => some, [INFO] [stderr] 34 | | &None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self.data.deref() { [INFO] [stderr] 33 | Some(ref some) => some, [INFO] [stderr] 34 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/force_some_rw_lock_write_guard.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self.data.deref_mut() { [INFO] [stderr] 42 | | &mut Some(ref mut some) => some, [INFO] [stderr] 43 | | &mut None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self.data.deref_mut() { [INFO] [stderr] 42 | Some(ref mut some) => some, [INFO] [stderr] 43 | None => panic!("Fatal error getting static. The static was never set. This should be impossible."), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mut_static::MutStatic` [INFO] [stderr] --> src/mut_static.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | MutStatic { [INFO] [stderr] 21 | | data: RwLock::new(None) [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if let &Some(_) = ok.deref() { [INFO] [stderr] 29 | | Ok(true) [INFO] [stderr] 30 | | } else { [INFO] [stderr] 31 | | Ok(false) [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | if let Some(_) = *ok.deref() { [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | / if let &None = ok.deref() { [INFO] [stderr] 42 | | return Err(ErrorKind::StaticWasNeverSet.into()) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | if let None = *ok.deref() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/mut_static.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(_) = mem::replace(data_ref, Some(value)) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 60 | | Err(ErrorKind::StaticIsAlreadySet.into()) [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | Ok(()) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mut_static.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if let &None = ok.deref() { [INFO] [stderr] 70 | | return Err(ErrorKind::StaticWasNeverSet.into()) [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | if let None = *ok.deref() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/test/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | assert!(test_obj.is_set().unwrap() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!test_obj.is_set().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/test/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | assert!(test_obj.is_set().unwrap() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `test_obj.is_set().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "0f3d618a70000bb172670f7bc25eb8a3de1c3817779de027cb0b55c114346954"` [INFO] running `"docker" "rm" "-f" "0f3d618a70000bb172670f7bc25eb8a3de1c3817779de027cb0b55c114346954"` [INFO] [stdout] 0f3d618a70000bb172670f7bc25eb8a3de1c3817779de027cb0b55c114346954