[INFO] crate multiboot2 0.7.1 is already in cache [INFO] extracting crate multiboot2 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/multiboot2/0.7.1 [INFO] extracting crate multiboot2 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multiboot2/0.7.1 [INFO] validating manifest of multiboot2-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of multiboot2-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing multiboot2-0.7.1 [INFO] finished frobbing multiboot2-0.7.1 [INFO] frobbed toml for multiboot2-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/multiboot2/0.7.1/Cargo.toml [INFO] started frobbing multiboot2-0.7.1 [INFO] finished frobbing multiboot2-0.7.1 [INFO] frobbed toml for multiboot2-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multiboot2/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting multiboot2-0.7.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multiboot2/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9695ef58dfcd052c071e60e331487e322fe8f0f2289a6cd3648730ecaee43738 [INFO] running `"docker" "start" "-a" "9695ef58dfcd052c071e60e331487e322fe8f0f2289a6cd3648730ecaee43738"` [INFO] [stderr] Checking multiboot2 v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/module.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | ModuleIter { iter: iter } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/module.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | ModuleIter { iter: iter } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:319:22 [INFO] [stderr] | [INFO] [stderr] 319 | address: 4244635648, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_244_635_648` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `FramebufferField`, `FramebufferTag` [INFO] [stderr] --> src/lib.rs:364:27 [INFO] [stderr] | [INFO] [stderr] 364 | use framebuffer::{FramebufferTag, FramebufferField, FramebufferType}; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:367:33 [INFO] [stderr] | [INFO] [stderr] 367 | assert_eq!(fbi.address, 4244635648); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_244_635_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:707:20 [INFO] [stderr] | [INFO] [stderr] 707 | assert_eq!(0x00000000, mm1.start_address()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:722:20 [INFO] [stderr] | [INFO] [stderr] 722 | assert_eq!(0x7FE18DC, rsdp_old.rsdt_address()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x07FE_18DC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:730:33 [INFO] [stderr] | [INFO] [stderr] 730 | assert_eq!(fbi.address, 753664); [INFO] [stderr] | ^^^^^^ help: consider: `753_664` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/header.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/boot_loader_name.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/elf_sections.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(9, tag.typ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:103:10 [INFO] [stderr] | [INFO] [stderr] 103 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/module.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/command_line.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/rsdp.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/rsdp.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:17:43 [INFO] [stderr] | [INFO] [stderr] 17 | last_area: (self_ptr as u64 + (self.size - self.entry_size) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size - self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory_map.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_area += (self.entry_size as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:60:53 [INFO] [stderr] | [INFO] [stderr] 60 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn signature<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 25 | | str::from_utf8(&self.signature).ok() [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn oem_id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 33 | | str::from_utf8(&self.oem_id).ok() [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn signature<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 64 | | str::from_utf8(&self.signature).ok() [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn oem_id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 72 | | str::from_utf8(&self.oem_id).ok() [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/framebuffer.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn framebuffer_tag<'a>(tag: &'a Tag) -> FramebufferTag<'a> { [INFO] [stderr] 43 | | let mut reader = Reader::new(tag as *const Tag); [INFO] [stderr] 44 | | reader.skip(8); [INFO] [stderr] 45 | | let address = reader.read_u64(); [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const header::Tag` to a more-strictly-aligned pointer (`*const memory_map::MemoryMapTag`) [INFO] [stderr] --> src/lib.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | self.get_tag(6).map(|tag| unsafe { &*(tag as *const Tag as *const MemoryMapTag) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | core::ptr::read(self.ptr.offset((self.off - 1) as isize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add((self.off - 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | self.read_u8() as u16 | (self.read_u8() as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:33 [INFO] [stderr] | [INFO] [stderr] 181 | self.read_u8() as u16 | (self.read_u8() as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | self.read_u16() as u32 | (self.read_u16() as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | self.read_u16() as u32 | (self.read_u16() as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | self.read_u32() as u64 | (self.read_u32() as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:189:34 [INFO] [stderr] | [INFO] [stderr] 189 | self.read_u32() as u64 | (self.read_u32() as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `multiboot2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/header.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/boot_loader_name.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/elf_sections.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | assert_eq!(9, tag.typ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/elf_sections.rs:103:10 [INFO] [stderr] | [INFO] [stderr] 103 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/module.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/command_line.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/rsdp.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: #[derive] can't be used on a #[repr(packed)] struct that does not derive Copy (error E0133) [INFO] [stderr] --> src/rsdp.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:17:43 [INFO] [stderr] | [INFO] [stderr] 17 | last_area: (self_ptr as u64 + (self.size - self.entry_size) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size - self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory_map.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_area += (self.entry_size as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:60:53 [INFO] [stderr] | [INFO] [stderr] 60 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn signature<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 25 | | str::from_utf8(&self.signature).ok() [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn oem_id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 33 | | str::from_utf8(&self.oem_id).ok() [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn signature<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 64 | | str::from_utf8(&self.signature).ok() [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rsdp.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn oem_id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 72 | | str::from_utf8(&self.oem_id).ok() [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/framebuffer.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn framebuffer_tag<'a>(tag: &'a Tag) -> FramebufferTag<'a> { [INFO] [stderr] 43 | | let mut reader = Reader::new(tag as *const Tag); [INFO] [stderr] 44 | | reader.skip(8); [INFO] [stderr] 45 | | let address = reader.read_u64(); [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting from `*const header::Tag` to a more-strictly-aligned pointer (`*const memory_map::MemoryMapTag`) [INFO] [stderr] --> src/lib.rs:66:46 [INFO] [stderr] | [INFO] [stderr] 66 | self.get_tag(6).map(|tag| unsafe { &*(tag as *const Tag as *const MemoryMapTag) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | core::ptr::read(self.ptr.offset((self.off - 1) as isize)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.ptr.add((self.off - 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | self.read_u8() as u16 | (self.read_u8() as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:33 [INFO] [stderr] | [INFO] [stderr] 181 | self.read_u8() as u16 | (self.read_u8() as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | self.read_u16() as u32 | (self.read_u16() as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:34 [INFO] [stderr] | [INFO] [stderr] 185 | self.read_u16() as u32 | (self.read_u16() as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | self.read_u32() as u64 | (self.read_u32() as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:189:34 [INFO] [stderr] | [INFO] [stderr] 189 | self.read_u32() as u64 | (self.read_u32() as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.read_u32())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 69 [INFO] [stderr] --> src/lib.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | / fn grub2() { [INFO] [stderr] 383 | | let mut bytes: [u8; 960] = [ [INFO] [stderr] 384 | | 192, 3, 0, 0, // total_size [INFO] [stderr] 385 | | 0, 0, 0, 0, // reserved [INFO] [stderr] ... | [INFO] [stderr] 735 | | assert_eq!(fbi.buffer_type, FramebufferType::Text); [INFO] [stderr] 736 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `multiboot2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9695ef58dfcd052c071e60e331487e322fe8f0f2289a6cd3648730ecaee43738"` [INFO] running `"docker" "rm" "-f" "9695ef58dfcd052c071e60e331487e322fe8f0f2289a6cd3648730ecaee43738"` [INFO] [stdout] 9695ef58dfcd052c071e60e331487e322fe8f0f2289a6cd3648730ecaee43738