[INFO] crate mouscache_derive 0.4.0 is already in cache [INFO] extracting crate mouscache_derive 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/mouscache_derive/0.4.0 [INFO] extracting crate mouscache_derive 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mouscache_derive/0.4.0 [INFO] validating manifest of mouscache_derive-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mouscache_derive-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mouscache_derive-0.4.0 [INFO] finished frobbing mouscache_derive-0.4.0 [INFO] frobbed toml for mouscache_derive-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/mouscache_derive/0.4.0/Cargo.toml [INFO] started frobbing mouscache_derive-0.4.0 [INFO] finished frobbing mouscache_derive-0.4.0 [INFO] frobbed toml for mouscache_derive-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mouscache_derive/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mouscache_derive-0.4.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mouscache_derive/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d56ce3236f8e70aa23a3791f87f611159b5bd30403d78422d6c11111cf902cc [INFO] running `"docker" "start" "-a" "3d56ce3236f8e70aa23a3791f87f611159b5bd30403d78422d6c11111cf902cc"` [INFO] [stderr] Checking quote v0.5.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking mouscache_derive v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/attr.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / if let &syn::Lit::Str(ref lit) = lit { [INFO] [stderr] 21 | | let value = T::from_str(&lit.value()).map_err(move |_| { format!("Unable to parse attribute value for {}", attr_name) }); [INFO] [stderr] 22 | | return value; [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | Err("Unable to parse attribute value".to_string()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | if let syn::Lit::Str(ref lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attr.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn validate_data_attributes(attrs: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/derive.rs:58:32 [INFO] [stderr] | [INFO] [stderr] 58 | fn expand_base_function(ident: &Ident, data_attrs: DataAttribute) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/derive.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | ident.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/attr.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / if let &syn::Lit::Str(ref lit) = lit { [INFO] [stderr] 21 | | let value = T::from_str(&lit.value()).map_err(move |_| { format!("Unable to parse attribute value for {}", attr_name) }); [INFO] [stderr] 22 | | return value; [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | Err("Unable to parse attribute value".to_string()) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | if let syn::Lit::Str(ref lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/attr.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn validate_data_attributes(attrs: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/derive.rs:58:32 [INFO] [stderr] | [INFO] [stderr] 58 | fn expand_base_function(ident: &Ident, data_attrs: DataAttribute) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/derive.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | ident.clone() [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.46s [INFO] running `"docker" "inspect" "3d56ce3236f8e70aa23a3791f87f611159b5bd30403d78422d6c11111cf902cc"` [INFO] running `"docker" "rm" "-f" "3d56ce3236f8e70aa23a3791f87f611159b5bd30403d78422d6c11111cf902cc"` [INFO] [stdout] 3d56ce3236f8e70aa23a3791f87f611159b5bd30403d78422d6c11111cf902cc