[INFO] crate more-asserts 0.2.1 is already in cache [INFO] extracting crate more-asserts 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/more-asserts/0.2.1 [INFO] extracting crate more-asserts 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/more-asserts/0.2.1 [INFO] validating manifest of more-asserts-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of more-asserts-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing more-asserts-0.2.1 [INFO] finished frobbing more-asserts-0.2.1 [INFO] frobbed toml for more-asserts-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/more-asserts/0.2.1/Cargo.toml [INFO] started frobbing more-asserts-0.2.1 [INFO] finished frobbing more-asserts-0.2.1 [INFO] frobbed toml for more-asserts-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/more-asserts/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting more-asserts-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/more-asserts/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a05a56c25149b00462b470e31542bbd2b1d822d840cac97f368725122daf1724 [INFO] running `"docker" "start" "-a" "a05a56c25149b00462b470e31542bbd2b1d822d840cac97f368725122daf1724"` [INFO] [stderr] Checking more-asserts v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if !(left < right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 380 | assert_lt!(4.0, 4.5); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if !(left < right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 382 | / assert_lt!(DummyType::Foo, DummyType::Bar, [INFO] [stderr] 383 | | "Message with {}", "cool formatting"); [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if !(left < right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 387 | assert_lt!(a, b); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 74 | | if !(left < right) { [INFO] [stderr] 75 | | panic!("assertion failed: `(left < right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 76 | | left, right); [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 389 | assert!(catch_unwind(|| assert_lt!(5, 3)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 74 | | if !(left < right) { [INFO] [stderr] 75 | | panic!("assertion failed: `(left < right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 76 | | left, right); [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 390 | assert!(catch_unwind(|| assert_lt!(5, 5)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 73 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 74 | | if !(left < right) { [INFO] [stderr] 75 | | panic!("assertion failed: `(left < right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 76 | | left, right); [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 391 | assert!(catch_unwind(|| assert_lt!(DummyType::Bar, DummyType::Foo)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:74:12 [INFO] [stderr] | [INFO] [stderr] 74 | if !(left < right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 391 | assert!(catch_unwind(|| assert_lt!(DummyType::Bar, DummyType::Foo)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if !(left > right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 397 | assert_gt!(4.5, 4.0); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | if !(left > right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 399 | / assert_gt!(DummyType::Bar, DummyType::Foo, [INFO] [stderr] 400 | | "Message with {}", "cool formatting"); [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if !(left > right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 404 | assert_gt!(b, a); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 115 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 116 | | if !(left > right) { [INFO] [stderr] 117 | | panic!("assertion failed: `(left > right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 118 | | left, right); [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 406 | assert!(catch_unwind(|| assert_gt!(3, 5)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 115 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 116 | | if !(left > right) { [INFO] [stderr] 117 | | panic!("assertion failed: `(left > right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 118 | | left, right); [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 407 | assert!(catch_unwind(|| assert_gt!(5, 5)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:114:35 [INFO] [stderr] | [INFO] [stderr] 114 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 115 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 116 | | if !(left > right) { [INFO] [stderr] 117 | | panic!("assertion failed: `(left > right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 118 | | left, right); [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 408 | assert!(catch_unwind(|| assert_gt!(DummyType::Foo, DummyType::Bar)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if !(left > right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 408 | assert!(catch_unwind(|| assert_gt!(DummyType::Foo, DummyType::Bar)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 415 | assert_le!(4.0, 4.5); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 418 | assert_le!(DummyType::Foo, DummyType::Bar, "Message"); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:169:12 [INFO] [stderr] | [INFO] [stderr] 169 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 419 | / assert_le!(DummyType::Foo, DummyType::Foo, [INFO] [stderr] 420 | | "Message with {}", "cool formatting"); [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 424 | assert_le!(a, a); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 425 | assert_le!(a, b); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 158 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 159 | | if !(left <= right) { [INFO] [stderr] 160 | | panic!("assertion failed: `(left <= right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 161 | | left, right); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 427 | assert!(catch_unwind(|| assert_le!(5, 3)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 158 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 159 | | if !(left <= right) { [INFO] [stderr] 160 | | panic!("assertion failed: `(left <= right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 161 | | left, right); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 428 | assert!(catch_unwind(|| assert_le!(DummyType::Bar, DummyType::Foo)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | if !(left <= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 428 | assert!(catch_unwind(|| assert_le!(DummyType::Bar, DummyType::Foo)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 435 | assert_ge!(4.5, 4.0); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 436 | assert_ge!(5.0, 5.0); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 439 | assert_ge!(DummyType::Bar, DummyType::Bar, "Example"); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:212:12 [INFO] [stderr] | [INFO] [stderr] 212 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 440 | / assert_ge!(DummyType::Bar, DummyType::Foo, [INFO] [stderr] 441 | | "Message with {}", "cool formatting"); [INFO] [stderr] | |_________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 445 | assert_ge!(a, a); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 446 | assert_ge!(b, a); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:200:35 [INFO] [stderr] | [INFO] [stderr] 200 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 201 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 202 | | if !(left >= right) { [INFO] [stderr] 203 | | panic!("assertion failed: `(left >= right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 204 | | left, right); [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 448 | assert!(catch_unwind(|| assert_ge!(3, 5)).is_err()); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:200:35 [INFO] [stderr] | [INFO] [stderr] 200 | ($left:expr, $right:expr) => ({ [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 201 | | let (left, right) = (&($left), &($right)); [INFO] [stderr] 202 | | if !(left >= right) { [INFO] [stderr] 203 | | panic!("assertion failed: `(left >= right)`\n left: `{:?}`,\n right: `{:?}`", [INFO] [stderr] 204 | | left, right); [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 449 | assert!(catch_unwind(|| assert_ge!(DummyType::Foo, DummyType::Bar)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/lib.rs:202:12 [INFO] [stderr] | [INFO] [stderr] 202 | if !(left >= right) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 449 | assert!(catch_unwind(|| assert_ge!(DummyType::Foo, DummyType::Bar)).is_err()); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.07s [INFO] running `"docker" "inspect" "a05a56c25149b00462b470e31542bbd2b1d822d840cac97f368725122daf1724"` [INFO] running `"docker" "rm" "-f" "a05a56c25149b00462b470e31542bbd2b1d822d840cac97f368725122daf1724"` [INFO] [stdout] a05a56c25149b00462b470e31542bbd2b1d822d840cac97f368725122daf1724