[INFO] crate mitochondria 1.1.2 is already in cache [INFO] extracting crate mitochondria 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/mitochondria/1.1.2 [INFO] extracting crate mitochondria 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mitochondria/1.1.2 [INFO] validating manifest of mitochondria-1.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mitochondria-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mitochondria-1.1.2 [INFO] finished frobbing mitochondria-1.1.2 [INFO] frobbed toml for mitochondria-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/mitochondria/1.1.2/Cargo.toml [INFO] started frobbing mitochondria-1.1.2 [INFO] finished frobbing mitochondria-1.1.2 [INFO] frobbed toml for mitochondria-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mitochondria/1.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mitochondria-1.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mitochondria/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b47630f10e20dfcee5008a76c9844ce2207860dcbfa1cb42e2691175d60c911 [INFO] running `"docker" "start" "-a" "1b47630f10e20dfcee5008a76c9844ce2207860dcbfa1cb42e2691175d60c911"` [INFO] [stderr] Checking mitochondria v1.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/move.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { self.value.into_inner() } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_mut` on this type; consider implementing the `std::convert::AsMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/move.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn as_mut(&mut self) -> &mut T { [INFO] [stderr] 95 | | unsafe { &mut *self.value.get() } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/once.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / self.as_ref() [INFO] [stderr] 243 | | .cloned() [INFO] [stderr] 244 | | .map(OnceCell::new_with_value) [INFO] [stderr] 245 | | .unwrap_or(OnceCell::new()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | self.as_ref() [INFO] [stderr] 243 | .cloned() [INFO] [stderr] 244 | .map(OnceCell::new_with_value).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/move.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | unsafe { self.value.into_inner() } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_mut` on this type; consider implementing the `std::convert::AsMut` trait or choosing a less ambiguous name [INFO] [stderr] --> src/move.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn as_mut(&mut self) -> &mut T { [INFO] [stderr] 95 | | unsafe { &mut *self.value.get() } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/once.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / self.as_ref() [INFO] [stderr] 243 | | .cloned() [INFO] [stderr] 244 | | .map(OnceCell::new_with_value) [INFO] [stderr] 245 | | .unwrap_or(OnceCell::new()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 242 | self.as_ref() [INFO] [stderr] 243 | .cloned() [INFO] [stderr] 244 | .map(OnceCell::new_with_value).unwrap_or_default() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.77s [INFO] running `"docker" "inspect" "1b47630f10e20dfcee5008a76c9844ce2207860dcbfa1cb42e2691175d60c911"` [INFO] running `"docker" "rm" "-f" "1b47630f10e20dfcee5008a76c9844ce2207860dcbfa1cb42e2691175d60c911"` [INFO] [stdout] 1b47630f10e20dfcee5008a76c9844ce2207860dcbfa1cb42e2691175d60c911