[INFO] crate minify 1.1.1 is already in cache [INFO] extracting crate minify 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/minify/1.1.1 [INFO] extracting crate minify 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minify/1.1.1 [INFO] validating manifest of minify-1.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of minify-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing minify-1.1.1 [INFO] finished frobbing minify-1.1.1 [INFO] frobbed toml for minify-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/minify/1.1.1/Cargo.toml [INFO] started frobbing minify-1.1.1 [INFO] finished frobbing minify-1.1.1 [INFO] frobbed toml for minify-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minify/1.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting minify-1.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/minify/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb6e33a546e4fafcbed6018d8e2c2e7e61a828f519d881946ca37d955ed79849 [INFO] running `"docker" "start" "-a" "bb6e33a546e4fafcbed6018d8e2c2e7e61a828f519d881946ca37d955ed79849"` [INFO] [stderr] Checking minify v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `int_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | #![cfg_attr(feature = "cargo-clippy", warn(int_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::int_plus_one` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_reuse` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::shadow_reuse` [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_same` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:58 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::shadow_same` [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_unrelated` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::shadow_unrelated` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_mut` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | #![cfg_attr(feature = "cargo-clippy", warn(mut_mut))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::mut_mut` [INFO] [stderr] [INFO] [stderr] warning: lint name `nonminimal_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | #![cfg_attr(feature = "cargo-clippy", warn(nonminimal_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::nonminimal_bool` [INFO] [stderr] [INFO] [stderr] warning: lint name `pub_enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | #![cfg_attr(feature = "cargo-clippy", warn(pub_enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::pub_enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `range_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | #![cfg_attr(feature = "cargo-clippy", warn(range_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::range_plus_one` [INFO] [stderr] [INFO] [stderr] warning: lint name `string_add` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:80:44 [INFO] [stderr] | [INFO] [stderr] 80 | #![cfg_attr(feature = "cargo-clippy", warn(string_add, string_add_assign))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::string_add` [INFO] [stderr] [INFO] [stderr] warning: lint name `string_add_assign` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:80:56 [INFO] [stderr] | [INFO] [stderr] 80 | #![cfg_attr(feature = "cargo-clippy", warn(string_add, string_add_assign))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::string_add_assign` [INFO] [stderr] [INFO] [stderr] warning: lint name `stutter` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | #![cfg_attr(feature = "cargo-clippy", warn(stutter))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::stutter` [INFO] [stderr] [INFO] [stderr] warning: lint name `result_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:82:44 [INFO] [stderr] | [INFO] [stderr] 82 | #![cfg_attr(feature = "cargo-clippy", warn(result_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::result_unwrap_used` [INFO] [stderr] [INFO] [stderr] warning: lint name `int_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | #![cfg_attr(feature = "cargo-clippy", warn(int_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::int_plus_one` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_reuse` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::shadow_reuse` [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_same` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:58 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::shadow_same` [INFO] [stderr] [INFO] [stderr] warning: lint name `shadow_unrelated` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | #![cfg_attr(feature = "cargo-clippy", warn(shadow_reuse, shadow_same, shadow_unrelated))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::shadow_unrelated` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_mut` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:76:44 [INFO] [stderr] | [INFO] [stderr] 76 | #![cfg_attr(feature = "cargo-clippy", warn(mut_mut))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::mut_mut` [INFO] [stderr] [INFO] [stderr] warning: lint name `nonminimal_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | #![cfg_attr(feature = "cargo-clippy", warn(nonminimal_bool))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::nonminimal_bool` [INFO] [stderr] [INFO] [stderr] warning: lint name `pub_enum_variant_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:78:44 [INFO] [stderr] | [INFO] [stderr] 78 | #![cfg_attr(feature = "cargo-clippy", warn(pub_enum_variant_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::pub_enum_variant_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `range_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | #![cfg_attr(feature = "cargo-clippy", warn(range_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::range_plus_one` [INFO] [stderr] [INFO] [stderr] warning: lint name `string_add` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:80:44 [INFO] [stderr] | [INFO] [stderr] 80 | #![cfg_attr(feature = "cargo-clippy", warn(string_add, string_add_assign))] [INFO] [stderr] | ^^^^^^^^^^ help: change it to: `clippy::string_add` [INFO] [stderr] [INFO] [stderr] warning: lint name `string_add_assign` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:80:56 [INFO] [stderr] | [INFO] [stderr] 80 | #![cfg_attr(feature = "cargo-clippy", warn(string_add, string_add_assign))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::string_add_assign` [INFO] [stderr] [INFO] [stderr] warning: lint name `stutter` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | #![cfg_attr(feature = "cargo-clippy", warn(stutter))] [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::stutter` [INFO] [stderr] [INFO] [stderr] warning: lint name `result_unwrap_used` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:82:44 [INFO] [stderr] | [INFO] [stderr] 82 | #![cfg_attr(feature = "cargo-clippy", warn(result_unwrap_used))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::result_unwrap_used` [INFO] [stderr] [INFO] [stderr] warning: lint name `int_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | #![cfg_attr(feature = "cargo-clippy", warn(int_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::int_plus_one` [INFO] [stderr] [INFO] [stderr] warning: lint name `int_plus_one` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:74:44 [INFO] [stderr] | [INFO] [stderr] 74 | #![cfg_attr(feature = "cargo-clippy", warn(int_plus_one))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::int_plus_one` [INFO] [stderr] [INFO] [stderr] warning: item name ends with its containing module's name [INFO] [stderr] --> src/io/reader.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub struct InternalReader { [INFO] [stderr] 11 | | iter: MultiFilter< [INFO] [stderr] 12 | | FilterMap, fn(result::Result) -> Option>, [INFO] [stderr] 13 | | P, [INFO] [stderr] ... | [INFO] [stderr] 17 | | pos_bytes: usize, [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | #![cfg_attr(feature = "cargo-clippy", warn(stutter))] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#stutter [INFO] [stderr] [INFO] [stderr] warning: item name ends with its containing module's name [INFO] [stderr] --> src/io/reader.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / pub struct InternalReader { [INFO] [stderr] 11 | | iter: MultiFilter< [INFO] [stderr] 12 | | FilterMap, fn(result::Result) -> Option>, [INFO] [stderr] 13 | | P, [INFO] [stderr] ... | [INFO] [stderr] 17 | | pos_bytes: usize, [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | #![cfg_attr(feature = "cargo-clippy", warn(stutter))] [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#stutter [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn equals_comment_end(item1: &char, item2: Option<&char>, item3: Option<&char>) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:88:12 [INFO] [stderr] | [INFO] [stderr] 88 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:104:68 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn is_whitespace_after_tag(minifier: &mut HtmlMinifier, item1: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/io/reader.rs:11:11 [INFO] [stderr] | [INFO] [stderr] 11 | iter: MultiFilter< [INFO] [stderr] | ___________^ [INFO] [stderr] 12 | | FilterMap, fn(result::Result) -> Option>, [INFO] [stderr] 13 | | P, [INFO] [stderr] 14 | | M, [INFO] [stderr] 15 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `pos` is only used to index `buf`. [INFO] [stderr] --> src/io/reader.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | for pos in buf_start..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in buf.iter_mut().skip(buf_start) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json/json_minifier.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json/json_minifier.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:43:12 [INFO] [stderr] | [INFO] [stderr] 43 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn equals_comment_end(item1: &char, item2: Option<&char>, item3: Option<&char>) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:88:12 [INFO] [stderr] | [INFO] [stderr] 88 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/html/html_minifier.rs:104:68 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn is_whitespace_after_tag(minifier: &mut HtmlMinifier, item1: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | let input = "\n".into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 91 | | [INFO] [stderr] 92 | | [INFO] [stderr] 93 | | [INFO] [stderr] ... | [INFO] [stderr] 96 | | [INFO] [stderr] 97 | | "#.into(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 90 | let input = r#" [INFO] [stderr] 91 | [INFO] [stderr] 92 | [INFO] [stderr] 93 | [INFO] [stderr] 94 | [INFO] [stderr] 95 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 106 | | [INFO] [stderr] 107 | | < head > [INFO] [stderr] 108 | | [INFO] [stderr] ... | [INFO] [stderr] 111 | | [INFO] [stderr] 112 | | "#.into(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 105 | let input = r#" [INFO] [stderr] 106 | [INFO] [stderr] 107 | < head > [INFO] [stderr] 108 | [INFO] [stderr] 109 | [INFO] [stderr] 110 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 121 | | [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | [INFO] [stderr] 123 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 140 | | [INFO] [stderr] 141 | | [INFO] [stderr] 142 | | [INFO] [stderr] 142 | > [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 158 | | test [INFO] [stderr] 159 | | [INFO] [stderr] 160 | | [INFO] [stderr] ... | [INFO] [stderr] 163 | | [INFO] [stderr] 164 | | "#.into(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 157 | let input = r#" [INFO] [stderr] 158 | test [INFO] [stderr] 159 | [INFO] [stderr] 160 | [INFO] [stderr] 161 | [INFO] [stderr] 162 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 173 | | test settings data [INFO] [stderr] 174 | | [INFO] [stderr] 175 | | [INFO] [stderr] ... | [INFO] [stderr] 178 | | [INFO] [stderr] 179 | | "#.into(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 172 | let input = r#" [INFO] [stderr] 173 | test settings data [INFO] [stderr] 174 | [INFO] [stderr] 175 | [INFO] [stderr] 176 | [INFO] [stderr] 177 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html/mod.rs:187:17 [INFO] [stderr] | [INFO] [stderr] 187 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 188 | | [INFO] [stderr] 189 | | [INFO] [stderr] 190 | | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/io/reader.rs:11:11 [INFO] [stderr] | [INFO] [stderr] 11 | iter: MultiFilter< [INFO] [stderr] | ___________^ [INFO] [stderr] 12 | | FilterMap, fn(result::Result) -> Option>, [INFO] [stderr] 13 | | P, [INFO] [stderr] 14 | | M, [INFO] [stderr] 15 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `pos` is only used to index `buf`. [INFO] [stderr] --> src/io/reader.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | for pos in buf_start..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in buf.iter_mut().skip(buf_start) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json/json_minifier.rs:25:12 [INFO] [stderr] | [INFO] [stderr] 25 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json/json_minifier.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | item1: &char, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/json/mod.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | let input = "\n".into(); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `"\n"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/json/mod.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let input = r#" [INFO] [stderr] | _________________^ [INFO] [stderr] 87 | | { [INFO] [stderr] 88 | | "test": "\" test2", [INFO] [stderr] 89 | | "test2": "", [INFO] [stderr] 90 | | "test3": " " [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | "#.into(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 86 | let input = r#" [INFO] [stderr] 87 | { [INFO] [stderr] 88 | "test": "\" test2", [INFO] [stderr] 89 | "test2": "", [INFO] [stderr] 90 | "test3": " " [INFO] [stderr] 91 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "bb6e33a546e4fafcbed6018d8e2c2e7e61a828f519d881946ca37d955ed79849"` [INFO] running `"docker" "rm" "-f" "bb6e33a546e4fafcbed6018d8e2c2e7e61a828f519d881946ca37d955ed79849"` [INFO] [stdout] bb6e33a546e4fafcbed6018d8e2c2e7e61a828f519d881946ca37d955ed79849