[INFO] crate mindjuice 0.1.1 is already in cache [INFO] extracting crate mindjuice 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/mindjuice/0.1.1 [INFO] extracting crate mindjuice 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mindjuice/0.1.1 [INFO] validating manifest of mindjuice-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mindjuice-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mindjuice-0.1.1 [INFO] finished frobbing mindjuice-0.1.1 [INFO] frobbed toml for mindjuice-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/mindjuice/0.1.1/Cargo.toml [INFO] started frobbing mindjuice-0.1.1 [INFO] finished frobbing mindjuice-0.1.1 [INFO] frobbed toml for mindjuice-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mindjuice/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mindjuice-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mindjuice/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f54825948bb899240108d7a89016ecc7faf4679cc099b283d299f9ce122e998b [INFO] running `"docker" "start" "-a" "f54825948bb899240108d7a89016ecc7faf4679cc099b283d299f9ce122e998b"` [INFO] [stderr] Checking mindjuice v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(instructions); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(instructions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(ExecutionTerminationCondition::MaximumIterationsReached); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ExecutionTerminationCondition::MaximumIterationsReached)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | return Ok(instructions); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(instructions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(ExecutionTerminationCondition::MaximumIterationsReached); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ExecutionTerminationCondition::MaximumIterationsReached)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &Error::UnbalancedRightBracket => { [INFO] [stderr] 66 | | write!(formatter, "Expected matching `[` before `]`, found lone `]` first.") [INFO] [stderr] 67 | | }, [INFO] [stderr] ... | [INFO] [stderr] 70 | | }, [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | Error::UnbalancedRightBracket => { [INFO] [stderr] 66 | write!(formatter, "Expected matching `[` before `]`, found lone `]` first.") [INFO] [stderr] 67 | }, [INFO] [stderr] 68 | Error::UnbalancedLeftBracket => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &ExecutionTerminationCondition::MaximumIterationsReached => { [INFO] [stderr] 79 | | write!(formatter, "Maximum iterations reached.") [INFO] [stderr] 80 | | }, [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | ExecutionTerminationCondition::MaximumIterationsReached => { [INFO] [stderr] 79 | write!(formatter, "Maximum iterations reached.") [INFO] [stderr] 80 | }, [INFO] [stderr] 81 | ExecutionTerminationCondition::AllInstructionsFinished => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &Error::UnbalancedRightBracket => { [INFO] [stderr] 66 | | write!(formatter, "Expected matching `[` before `]`, found lone `]` first.") [INFO] [stderr] 67 | | }, [INFO] [stderr] ... | [INFO] [stderr] 70 | | }, [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | Error::UnbalancedRightBracket => { [INFO] [stderr] 66 | write!(formatter, "Expected matching `[` before `]`, found lone `]` first.") [INFO] [stderr] 67 | }, [INFO] [stderr] 68 | Error::UnbalancedLeftBracket => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &ExecutionTerminationCondition::MaximumIterationsReached => { [INFO] [stderr] 79 | | write!(formatter, "Maximum iterations reached.") [INFO] [stderr] 80 | | }, [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | ExecutionTerminationCondition::MaximumIterationsReached => { [INFO] [stderr] 79 | write!(formatter, "Maximum iterations reached.") [INFO] [stderr] 80 | }, [INFO] [stderr] 81 | ExecutionTerminationCondition::AllInstructionsFinished => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "f54825948bb899240108d7a89016ecc7faf4679cc099b283d299f9ce122e998b"` [INFO] running `"docker" "rm" "-f" "f54825948bb899240108d7a89016ecc7faf4679cc099b283d299f9ce122e998b"` [INFO] [stdout] f54825948bb899240108d7a89016ecc7faf4679cc099b283d299f9ce122e998b