[INFO] crate microbench 0.3.3 is already in cache [INFO] extracting crate microbench 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/microbench/0.3.3 [INFO] extracting crate microbench 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/microbench/0.3.3 [INFO] validating manifest of microbench-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of microbench-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing microbench-0.3.3 [INFO] finished frobbing microbench-0.3.3 [INFO] frobbed toml for microbench-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/microbench/0.3.3/Cargo.toml [INFO] started frobbing microbench-0.3.3 [INFO] finished frobbing microbench-0.3.3 [INFO] frobbed toml for microbench-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/microbench/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting microbench-0.3.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/microbench/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e275e55315688038769bd7d5f0ba807d01d6f0571c806783834ee8a87beb1f5 [INFO] running `"docker" "start" "-a" "6e275e55315688038769bd7d5f0ba807d01d6f0571c806783834ee8a87beb1f5"` [INFO] [stderr] Checking microbench v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:52 [INFO] [stderr] | [INFO] [stderr] 141 | GeometricSequence { current: start as f64, factor: factor } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:238:49 [INFO] [stderr] | [INFO] [stderr] 238 | measurements.push(Measurement { iterations: iterations, elapsed: elapsed }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:238:73 [INFO] [stderr] | [INFO] [stderr] 238 | measurements.push(Measurement { iterations: iterations, elapsed: elapsed }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `elapsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:255:68 [INFO] [stderr] | [INFO] [stderr] 255 | Analysis { alpha: Nanoseconds(alpha), beta: Nanoseconds(beta), r2: r2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:141:52 [INFO] [stderr] | [INFO] [stderr] 141 | GeometricSequence { current: start as f64, factor: factor } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `factor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:238:49 [INFO] [stderr] | [INFO] [stderr] 238 | measurements.push(Measurement { iterations: iterations, elapsed: elapsed }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `iterations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:238:73 [INFO] [stderr] | [INFO] [stderr] 238 | measurements.push(Measurement { iterations: iterations, elapsed: elapsed }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `elapsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:255:68 [INFO] [stderr] | [INFO] [stderr] 255 | Analysis { alpha: Nanoseconds(alpha), beta: Nanoseconds(beta), r2: r2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `r2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | Nanoseconds((duration.as_secs() * 1_000_000_000) + duration.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `time::Stopwatch` [INFO] [stderr] --> src/time.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Stopwatch { start: Instant::now() } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for time::Stopwatch { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | Nanoseconds((duration.as_secs() * 1_000_000_000) + duration.subsec_nanos() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `time::Stopwatch` [INFO] [stderr] --> src/time.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | Stopwatch { start: Instant::now() } [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | impl Default for time::Stopwatch { [INFO] [stderr] 51 | fn default() -> Self { [INFO] [stderr] 52 | Self::new() [INFO] [stderr] 53 | } [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "6e275e55315688038769bd7d5f0ba807d01d6f0571c806783834ee8a87beb1f5"` [INFO] running `"docker" "rm" "-f" "6e275e55315688038769bd7d5f0ba807d01d6f0571c806783834ee8a87beb1f5"` [INFO] [stdout] 6e275e55315688038769bd7d5f0ba807d01d6f0571c806783834ee8a87beb1f5