[INFO] crate metfor 0.4.1 is already in cache [INFO] extracting crate metfor 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/metfor/0.4.1 [INFO] extracting crate metfor 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metfor/0.4.1 [INFO] validating manifest of metfor-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of metfor-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing metfor-0.4.1 [INFO] finished frobbing metfor-0.4.1 [INFO] frobbed toml for metfor-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/metfor/0.4.1/Cargo.toml [INFO] started frobbing metfor-0.4.1 [INFO] finished frobbing metfor-0.4.1 [INFO] frobbed toml for metfor-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metfor/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting metfor-0.4.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/metfor/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a9b6ee0c75259aa7be6bba90f188127f51e896803ce6de06f64f050876926e4 [INFO] running `"docker" "start" "-a" "3a9b6ee0c75259aa7be6bba90f188127f51e896803ce6de06f64f050876926e4"` [INFO] [stderr] Checking metfor v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:944:36 [INFO] [stderr] | [INFO] [stderr] 944 | ((000.0, 10.0), (0.0, -5.14444444)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5.144_444_44` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:945:31 [INFO] [stderr] | [INFO] [stderr] 945 | ((045.0, 10.0), (-3.637671549, -3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:945:45 [INFO] [stderr] | [INFO] [stderr] 945 | ((045.0, 10.0), (-3.637671549, -3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:946:31 [INFO] [stderr] | [INFO] [stderr] 946 | ((090.0, 10.0), (-5.14444444, 0.0)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5.144_444_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:947:31 [INFO] [stderr] | [INFO] [stderr] 947 | ((135.0, 10.0), (-3.637671549, 3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:947:44 [INFO] [stderr] | [INFO] [stderr] 947 | ((135.0, 10.0), (-3.637671549, 3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:948:35 [INFO] [stderr] | [INFO] [stderr] 948 | ((180.0, 10.0), (0.0, 5.14444444)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5.144_444_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:949:30 [INFO] [stderr] | [INFO] [stderr] 949 | ((225.0, 10.0), (3.637671549, 3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:949:43 [INFO] [stderr] | [INFO] [stderr] 949 | ((225.0, 10.0), (3.637671549, 3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:950:30 [INFO] [stderr] | [INFO] [stderr] 950 | ((270.0, 10.0), (5.14444444, 0.0)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5.144_444_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:951:30 [INFO] [stderr] | [INFO] [stderr] 951 | ((315.0, 10.0), (3.637671549, -3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/functions.rs:951:44 [INFO] [stderr] | [INFO] [stderr] 951 | ((315.0, 10.0), (3.637671549, -3.637671549)), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.637_671_549` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/functions.rs:545:65 [INFO] [stderr] | [INFO] [stderr] 545 | } else if self.step < 0.0 && self.start < self.stop { [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 546 | | None [INFO] [stderr] 547 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/functions.rs:543:58 [INFO] [stderr] | [INFO] [stderr] 543 | if self.step > 0.0 && self.start > self.stop { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 544 | | None [INFO] [stderr] 545 | | } else if self.step < 0.0 && self.start < self.stop { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/functions.rs:707:21 [INFO] [stderr] | [INFO] [stderr] 707 | Err(_) => panic!("Unexpected Error."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/functions.rs:711:28 [INFO] [stderr] | [INFO] [stderr] 711 | if t == dp { [INFO] [stderr] | ^^^^^^^ help: consider comparing them within some error: `(t - dp).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/functions.rs:711:28 [INFO] [stderr] | [INFO] [stderr] 711 | if t == dp { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/functions.rs:712:37 [INFO] [stderr] | [INFO] [stderr] 712 | assert!(rh == 1.0); [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(rh - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/functions.rs:712:37 [INFO] [stderr] | [INFO] [stderr] 712 | assert!(rh == 1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/functions.rs:727:21 [INFO] [stderr] | [INFO] [stderr] 727 | Err(_) => panic!("Unexpected Error."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/functions.rs:731:28 [INFO] [stderr] | [INFO] [stderr] 731 | if t == dp { [INFO] [stderr] | ^^^^^^^ help: consider comparing them within some error: `(t - dp).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/functions.rs:731:28 [INFO] [stderr] | [INFO] [stderr] 731 | if t == dp { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/functions.rs:732:37 [INFO] [stderr] | [INFO] [stderr] 732 | assert!(rh == 1.0); [INFO] [stderr] | ^^^^^^^^^ help: consider comparing them within some error: `(rh - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/functions.rs:732:37 [INFO] [stderr] | [INFO] [stderr] 732 | assert!(rh == 1.0); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/functions.rs:769:25 [INFO] [stderr] | [INFO] [stderr] 769 | / match back { [INFO] [stderr] 770 | | Ok(back) => { [INFO] [stderr] 771 | | println!( [INFO] [stderr] 772 | | "{} == {} with tolerance <= {}", [INFO] [stderr] ... | [INFO] [stderr] 779 | | Err(_) => { /* Ignore error that bubbled up. */ } [INFO] [stderr] 780 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 769 | if let Ok(back) = back { [INFO] [stderr] 770 | println!( [INFO] [stderr] 771 | "{} == {} with tolerance <= {}", [INFO] [stderr] 772 | dp, [INFO] [stderr] 773 | back, [INFO] [stderr] 774 | f64::abs(dp - back) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/functions.rs:794:21 [INFO] [stderr] | [INFO] [stderr] 794 | / match pressure_and_temperature_at_lcl(t, dp, p) { [INFO] [stderr] 795 | | Ok((p_lcl, t_lcl)) => { [INFO] [stderr] 796 | | let k = celsius_to_kelvin(t).unwrap(); [INFO] [stderr] 797 | | assert!(p_lcl <= p); [INFO] [stderr] ... | [INFO] [stderr] 802 | | Err(_) => { /* Ignore these for now. */ } [INFO] [stderr] 803 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 794 | if let Ok((p_lcl, t_lcl)) = pressure_and_temperature_at_lcl(t, dp, p) { [INFO] [stderr] 795 | let k = celsius_to_kelvin(t).unwrap(); [INFO] [stderr] 796 | assert!(p_lcl <= p); [INFO] [stderr] 797 | assert!((t_lcl - k) < 0.001); [INFO] [stderr] 798 | assert!(p_lcl > 0.0); [INFO] [stderr] 799 | assert!(t_lcl > 0.0); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/functions.rs:814:21 [INFO] [stderr] | [INFO] [stderr] 814 | / match pressure_hpa_at_lcl(t, dp, p) { [INFO] [stderr] 815 | | Ok(p_lcl) => { [INFO] [stderr] 816 | | assert!(p_lcl <= p); [INFO] [stderr] 817 | | assert!(p_lcl > 0.0); [INFO] [stderr] 818 | | } [INFO] [stderr] 819 | | Err(_) => { /* Ignore */ } [INFO] [stderr] 820 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 814 | if let Ok(p_lcl) = pressure_hpa_at_lcl(t, dp, p) { [INFO] [stderr] 815 | assert!(p_lcl <= p); [INFO] [stderr] 816 | assert!(p_lcl > 0.0); [INFO] [stderr] 817 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/functions.rs:842:21 [INFO] [stderr] | [INFO] [stderr] 842 | / match theta_e_kelvin(t, dp, p) { [INFO] [stderr] 843 | | Ok(theta_e) => { [INFO] [stderr] 844 | | let theta = theta_kelvin(p, t).unwrap(); [INFO] [stderr] 845 | | assert!(theta <= theta_e); [INFO] [stderr] 846 | | } [INFO] [stderr] 847 | | Err(_) => { /* Ignore forwarded errors. */ } [INFO] [stderr] 848 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 842 | if let Ok(theta_e) = theta_e_kelvin(t, dp, p) { [INFO] [stderr] 843 | let theta = theta_kelvin(p, t).unwrap(); [INFO] [stderr] 844 | assert!(theta <= theta_e); [INFO] [stderr] 845 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `metfor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3a9b6ee0c75259aa7be6bba90f188127f51e896803ce6de06f64f050876926e4"` [INFO] running `"docker" "rm" "-f" "3a9b6ee0c75259aa7be6bba90f188127f51e896803ce6de06f64f050876926e4"` [INFO] [stdout] 3a9b6ee0c75259aa7be6bba90f188127f51e896803ce6de06f64f050876926e4